Bump kLastGeneratedScriptWrappableTag to 2000 [chromium/src : main]

0 views
Skip to first unread message

Edman Anjos (Gerrit)

unread,
Feb 9, 2026, 11:30:26 AM (2 days ago) Feb 9
to Edman Anjos, Jeremy Roman, Michael Lippautz, Andreas Haas, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org

Edman Anjos voted and added 2 comments

Votes added by Edman Anjos

Commit-Queue+2

2 comments

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Edman Anjos . resolved

Thank you

File third_party/blink/renderer/platform/bindings/wrapper_type_info.h
Line 58, Patchset 3:// that this is too small, bump it up by another 100.
Jeremy Roman . resolved

nit: Why not give ourselves more space than this for now? uint16_t isn't infinite, but it seems like we could bump to like 2000 to make the need to update this a bit less frequent?

Edman Anjos

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I383d65d55d9586b4132066ffbbb37697e1203e5f
Gerrit-Change-Number: 7550633
Gerrit-PatchSet: 4
Gerrit-Owner: Edman Anjos <ed...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Morten Stenshorne <mste...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Mon, 09 Feb 2026 16:30:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jeremy Roman <jbr...@chromium.org>
satisfied_requirement
open
diffy

Jeremy Roman (Gerrit)

unread,
Feb 9, 2026, 11:31:29 AM (2 days ago) Feb 9
to Edman Anjos, Jeremy Roman, Michael Lippautz, Andreas Haas, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Edman Anjos

Jeremy Roman voted and added 1 comment

Votes added by Jeremy Roman

Code-Review+1

1 comment

File gin/public/wrappable_pointer_tags.h
Line 24, Patchset 4 (Latest): kFirstPointerTag = 2101,
Jeremy Roman . unresolved

2001?

Open in Gerrit

Related details

Attention is currently required from:
  • Edman Anjos
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I383d65d55d9586b4132066ffbbb37697e1203e5f
    Gerrit-Change-Number: 7550633
    Gerrit-PatchSet: 4
    Gerrit-Owner: Edman Anjos <ed...@chromium.org>
    Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
    Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
    Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Morten Stenshorne <mste...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Edman Anjos <ed...@chromium.org>
    Gerrit-Comment-Date: Mon, 09 Feb 2026 16:31:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jeremy Roman (Gerrit)

    unread,
    Feb 9, 2026, 11:32:34 AM (2 days ago) Feb 9
    to Edman Anjos, Jeremy Roman, Michael Lippautz, Andreas Haas, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
    Attention needed from Edman Anjos

    Jeremy Roman added 1 comment

    File gin/public/wrappable_pointer_tags.h
    Line 24, Patchset 4 (Latest): kFirstPointerTag = 2101,
    Jeremy Roman . resolved

    2001?

    Jeremy Roman

    Disregard, but maybe we should make the precise connection with ScriptWrappableArrayTag::kLastTag more explicit, since I missed it at first?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Edman Anjos
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I383d65d55d9586b4132066ffbbb37697e1203e5f
      Gerrit-Change-Number: 7550633
      Gerrit-PatchSet: 4
      Gerrit-Owner: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
      Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Michael Lippautz <mlip...@chromium.org>
      Gerrit-CC: Morten Stenshorne <mste...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Edman Anjos <ed...@chromium.org>
      Gerrit-Comment-Date: Mon, 09 Feb 2026 16:32:28 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Jeremy Roman <jbr...@chromium.org>
      satisfied_requirement
      open
      diffy

      Edman Anjos (Gerrit)

      unread,
      Feb 9, 2026, 11:58:08 AM (2 days ago) Feb 9
      to Edman Anjos, Jeremy Roman, Michael Lippautz, Andreas Haas, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org

      Edman Anjos added 1 comment

      File gin/public/wrappable_pointer_tags.h
      Line 24, Patchset 4 (Latest): kFirstPointerTag = 2101,
      Jeremy Roman . resolved

      2001?

      Jeremy Roman

      Disregard, but maybe we should make the precise connection with ScriptWrappableArrayTag::kLastTag more explicit, since I missed it at first?

      Edman Anjos

      I'm not sure we can make it explicit in code.

      What comes to mind is to change the lint comment to `// LINT.IfChange(LastScriptWrappableTag)`. Is that better?

      Another option is to increase the `LINT.IfChange` area to include the `ScriptWrappableArrayTag` enum. That shows the relationship but has more chance for false positives, as it's unlikely that changing the enum requires a change in the `gin::kFirstPointerTag`.

      If you have ideas for improvements here I'm happy to discuss and implement a separate change.

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I383d65d55d9586b4132066ffbbb37697e1203e5f
      Gerrit-Change-Number: 7550633
      Gerrit-PatchSet: 4
      Gerrit-Owner: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
      Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Michael Lippautz <mlip...@chromium.org>
      Gerrit-CC: Morten Stenshorne <mste...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Comment-Date: Mon, 09 Feb 2026 16:57:54 +0000
      satisfied_requirement
      open
      diffy

      Edman Anjos (Gerrit)

      unread,
      Feb 9, 2026, 12:28:40 PM (2 days ago) Feb 9
      to Edman Anjos, Jeremy Roman, Michael Lippautz, Andreas Haas, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org

      Edman Anjos voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Mon, 09 Feb 2026 17:28:28 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Feb 9, 2026, 1:42:38 PM (2 days ago) Feb 9
      to Edman Anjos, Jeremy Roman, Michael Lippautz, Andreas Haas, Morten Stenshorne, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Bump kLastGeneratedScriptWrappableTag to 2000

      We're adding a new ScriptWrappable, which hits the current limit of
      1500. This change increases kLastGeneratedScriptWrappableTag to 2000.

      With that we also need to update gin::kFirstPointerTag, as it shouldn't
      overlap with script wrappable tags.
      Bug: 480079149
      Test: the next CL in this chain compiles
      Change-Id: I383d65d55d9586b4132066ffbbb37697e1203e5f
      Commit-Queue: Edman Anjos <ed...@chromium.org>
      Reviewed-by: Andreas Haas <ah...@chromium.org>
      Reviewed-by: Jeremy Roman <jbr...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1581869}
      Files:
      • M gin/public/wrappable_pointer_tags.h
      • M third_party/blink/renderer/platform/bindings/wrapper_type_info.h
      Change size: S
      Delta: 2 files changed, 10 insertions(+), 2 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Jeremy Roman, +1 by Andreas Haas
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I383d65d55d9586b4132066ffbbb37697e1203e5f
      Gerrit-Change-Number: 7550633
      Gerrit-PatchSet: 5
      Gerrit-Owner: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages