[WebTransport] Add WebTransportSendGroup interface and createSendGroup() [chromium/src : main]

[krishna dheeraj Pannala (Gerrit)]

Attention needed from krishna dheeraj Pannala

Message from krishna dheeraj Pannala

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

• krishna dheeraj Pannala

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0b62675b5d10b71fa9af6424d8bc2a9579135740

Gerrit-Change-Number: 7602393

Gerrit-PatchSet: 7

Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Comment-Date: Thu, 05 Mar 2026 06:58:59 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Himanshu Panwar (Gerrit)]

Attention needed from Adam Rice and krishna dheeraj Pannala

Himanshu Panwar added 3 comments

File third_party/blink/renderer/modules/webtransport/web_transport.h

Line 48, Patchset 7:class WebTransport;

Himanshu Panwar . unresolved

do we need this forward declaration here ?

File third_party/blink/renderer/modules/webtransport/web_transport.cc

Line 1299, Patchset 7: visitor->Trace(send_groups_);

Himanshu Panwar . unresolved

I dont see where we are clearing this send_groups_ , Dispose() clears incoming_stream_map_, outgoing_stream_map_, and closed_potentially_pending_streams_, but send_groups_ isn't cleared here.

File third_party/blink/renderer/modules/webtransport/web_transport_send_group.cc

Line 10, Patchset 7:#include "third_party/blink/renderer/platform/bindings/exception_state.h"

Himanshu Panwar . unresolved

Nit/: are we using this include in this cl? if not ,shouldn't we add this in the follow up cl's where it is needed?

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• krishna dheeraj Pannala

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0b62675b5d10b71fa9af6424d8bc2a9579135740

Gerrit-Change-Number: 7602393

Gerrit-PatchSet: 7

Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 05 Mar 2026 07:26:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[krishna dheeraj Pannala (Gerrit)]

Attention needed from Adam Rice and Himanshu Panwar

krishna dheeraj Pannala added 3 comments

File third_party/blink/renderer/modules/webtransport/web_transport.h

Line 48, Patchset 7:class WebTransport;

Himanshu Panwar . resolved

do we need this forward declaration here ?

krishna dheeraj Pannala

The forward declaration is needed here `WebTransportSendGroup` is used as a return type for `createSendGroup()` and in the `HeapVector<Member<WebTransportSendGroup>> send_groups_ member`. Using a forward declaration avoids pulling in the full header.

File third_party/blink/renderer/modules/webtransport/web_transport.cc

Line 1299, Patchset 7: visitor->Trace(send_groups_);

Himanshu Panwar . resolved

I dont see where we are clearing this send_groups_ , Dispose() clears incoming_stream_map_, outgoing_stream_map_, and closed_potentially_pending_streams_, but send_groups_ isn't cleared here.

krishna dheeraj Pannala

Added `send_groups_.clear()` in `Dispose()` alongside the other collection clears.

File third_party/blink/renderer/modules/webtransport/web_transport_send_group.cc

Line 10, Patchset 7:#include "third_party/blink/renderer/platform/bindings/exception_state.h"

Himanshu Panwar . resolved

Nit/: are we using this include in this cl? if not ,shouldn't we add this in the follow up cl's where it is needed?

krishna dheeraj Pannala

`script_promise_resolver.h` and `exception_state.h` aren't needed in this CL. Removed both, they can be added back in the follow-up when they're actually used. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Himanshu Panwar

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0b62675b5d10b71fa9af6424d8bc2a9579135740

Gerrit-Change-Number: 7602393

Gerrit-PatchSet: 10

Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 05 Mar 2026 07:43:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Himanshu Panwar <himp...@microsoft.com>

[Himanshu Panwar (Gerrit)]

Attention needed from Adam Rice and krishna dheeraj Pannala

Himanshu Panwar added 1 comment

File third_party/blink/renderer/modules/webtransport/web_transport.h

Line 48, Patchset 7:class WebTransport;

Himanshu Panwar . unresolved

do we need this forward declaration here ?

krishna dheeraj Pannala

The forward declaration is needed here `WebTransportSendGroup` is used as a return type for `createSendGroup()` and in the `HeapVector<Member<WebTransportSendGroup>> send_groups_ member`. Using a forward declaration avoids pulling in the full header.

Himanshu Panwar

WebTransportSendGroup is defiantly needed, i am taking about "class WebTransport" line48 isn't that already defined at line 55. sorry for not being clear in the first comment.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• krishna dheeraj Pannala

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0b62675b5d10b71fa9af6424d8bc2a9579135740

Gerrit-Change-Number: 7602393

Gerrit-PatchSet: 10

Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 05 Mar 2026 07:51:26 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Himanshu Panwar <himp...@microsoft.com>

Comment-In-Reply-To: krishna dheeraj Pannala <kpan...@microsoft.com>

[krishna dheeraj Pannala (Gerrit)]

Attention needed from Adam Rice and Himanshu Panwar

krishna dheeraj Pannala added 1 comment

File third_party/blink/renderer/modules/webtransport/web_transport.h

Line 48, Patchset 7:class WebTransport;

Himanshu Panwar . resolved

do we need this forward declaration here ?

krishna dheeraj Pannala

The forward declaration is needed here `WebTransportSendGroup` is used as a return type for `createSendGroup()` and in the `HeapVector<Member<WebTransportSendGroup>> send_groups_ member`. Using a forward declaration avoids pulling in the full header.

Himanshu Panwar

WebTransportSendGroup is defiantly needed, i am taking about "class WebTransport" line48 isn't that already defined at line 55. sorry for not being clear in the first comment.

krishna dheeraj Pannala

Done

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Himanshu Panwar

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0b62675b5d10b71fa9af6424d8bc2a9579135740

Gerrit-Change-Number: 7602393

Gerrit-PatchSet: 11

Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 05 Mar 2026 08:08:03 +0000

[Adam Rice (Gerrit)]

Attention needed from Himanshu Panwar, Nidhi Jaju and krishna dheeraj Pannala

Adam Rice added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Adam Rice . resolved

+nidhijaju for spec expertise.

Open in Gerrit

Related details

Attention is currently required from:

• Himanshu Panwar
• Nidhi Jaju
• krishna dheeraj Pannala

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0b62675b5d10b71fa9af6424d8bc2a9579135740

Gerrit-Change-Number: 7602393

Gerrit-PatchSet: 11

Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-CC: Adam Rice <ri...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>

Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Comment-Date: Fri, 06 Mar 2026 03:17:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Adam Rice (Gerrit)]

Attention needed from Himanshu Panwar, Nidhi Jaju and krishna dheeraj Pannala

Adam Rice added 2 comments

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Adam Rice . resolved

Just one thing pointed out by Gemini.

File third_party/blink/renderer/modules/webtransport/web_transport.h

Line 287, Patchset 11 (Latest): HeapVector<Member<WebTransportSendGroup>> send_groups_;

Adam Rice . unresolved

If we don't need to keep track of groups that the caller has discarded, then this structure could be a `HeapHashSet<WeakMember<WebTransportSendGroup>>` to permit garbage collection.

Open in Gerrit

Related details

Attention is currently required from:

• Himanshu Panwar
• Nidhi Jaju
• krishna dheeraj Pannala

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0b62675b5d10b71fa9af6424d8bc2a9579135740

Gerrit-Change-Number: 7602393

Gerrit-PatchSet: 11

Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-CC: Adam Rice <ri...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>

Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Comment-Date: Fri, 06 Mar 2026 03:32:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Nidhi Jaju (Gerrit)]

Attention needed from Himanshu Panwar and krishna dheeraj Pannala

Nidhi Jaju added 3 comments

File third_party/blink/renderer/modules/webtransport/web_transport.cc

Line 1747, Patchset 11 (Latest): MakeGarbageCollected<WebTransportSendGroup>(this, next_send_group_id_++);

Nidhi Jaju . unresolved

Should we use `base::CheckAdd()` here in case of overflow?

File third_party/blink/renderer/modules/webtransport/web_transport_send_options.idl

Line 6, Patchset 11 (Latest):dictionary WebTransportSendOptions {

Nidhi Jaju . unresolved

I don't think we wire this up on the C++ side, can we move this to the CLs where we actually implement this?

File third_party/blink/renderer/modules/webtransport/web_transport_send_stream_options.idl

Line 6, Patchset 11 (Latest):dictionary WebTransportSendStreamOptions : WebTransportSendOptions {

Nidhi Jaju . unresolved

Same comment as for the WebTransportSendOptions IDL file.

Open in Gerrit

Related details

Attention is currently required from:

• Himanshu Panwar
• krishna dheeraj Pannala

Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Comment-Date: Fri, 06 Mar 2026 07:53:05 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[krishna dheeraj Pannala (Gerrit)]

Attention needed from Adam Rice, Himanshu Panwar and Nidhi Jaju

krishna dheeraj Pannala added 4 comments

File third_party/blink/renderer/modules/webtransport/web_transport.h

Line 287, Patchset 11: HeapVector<Member<WebTransportSendGroup>> send_groups_;

Adam Rice . resolved

If we don't need to keep track of groups that the caller has discarded, then this structure could be a `HeapHashSet<WeakMember<WebTransportSendGroup>>` to permit garbage collection.

krishna dheeraj Pannala

Done

File third_party/blink/renderer/modules/webtransport/web_transport.cc

Line 1747, Patchset 11: MakeGarbageCollected<WebTransportSendGroup>(this, next_send_group_id_++);

Nidhi Jaju . resolved

Should we use `base::CheckAdd()` here in case of overflow?

krishna dheeraj Pannala

Done

File third_party/blink/renderer/modules/webtransport/web_transport_send_options.idl

Line 6, Patchset 11:dictionary WebTransportSendOptions {

Nidhi Jaju . resolved

I don't think we wire this up on the C++ side, can we move this to the CLs where we actually implement this?

krishna dheeraj Pannala

Done

File third_party/blink/renderer/modules/webtransport/web_transport_send_stream_options.idl

Line 6, Patchset 11:dictionary WebTransportSendStreamOptions : WebTransportSendOptions {

Nidhi Jaju . resolved

Same comment as for the WebTransportSendOptions IDL file.

krishna dheeraj Pannala

Done

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Himanshu Panwar
• Nidhi Jaju

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0b62675b5d10b71fa9af6424d8bc2a9579135740

Gerrit-Change-Number: 7602393

Gerrit-PatchSet: 13

Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-CC: Adam Rice <ri...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>

Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 09 Mar 2026 09:39:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Nidhi Jaju <nidh...@chromium.org>

Comment-In-Reply-To: Adam Rice <ri...@chromium.org>

[Adam Rice (Gerrit)]

Attention needed from Himanshu Panwar, Nidhi Jaju and krishna dheeraj Pannala

Adam Rice added 1 comment

File third_party/blink/renderer/modules/webtransport/web_transport_send_group.cc

Line 23, Patchset 13 (Latest): auto* stats = MakeGarbageCollected<WebTransportSendStreamStats>();

Adam Rice . unresolved

We'll need a test for this method. Either a unit test or a web platform test would be fine.

Open in Gerrit

Related details

Attention is currently required from:

• Himanshu Panwar

• Nidhi Jaju
• krishna dheeraj Pannala

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0b62675b5d10b71fa9af6424d8bc2a9579135740

Gerrit-Change-Number: 7602393

Gerrit-PatchSet: 13

Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-CC: Adam Rice <ri...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>

Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Comment-Date: Tue, 10 Mar 2026 00:22:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Nidhi Jaju (Gerrit)]

Attention needed from Himanshu Panwar and krishna dheeraj Pannala

Nidhi Jaju voted and added 1 comment

Votes added by Nidhi Jaju

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Nidhi Jaju . resolved

lgtm % Adam's comment

Open in Gerrit

Related details

Attention is currently required from:

• Himanshu Panwar
• krishna dheeraj Pannala

Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Comment-Date: Wed, 11 Mar 2026 07:45:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[krishna dheeraj Pannala (Gerrit)]

Attention needed from Adam Rice, Himanshu Panwar and Nidhi Jaju

krishna dheeraj Pannala added 1 comment

File third_party/blink/renderer/modules/webtransport/web_transport_send_group.cc

Line 23, Patchset 13: auto* stats = MakeGarbageCollected<WebTransportSendStreamStats>();

Adam Rice . resolved

We'll need a test for this method. Either a unit test or a web platform test would be fine.

krishna dheeraj Pannala

Done, Added a unit test.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Himanshu Panwar
• Nidhi Jaju

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0b62675b5d10b71fa9af6424d8bc2a9579135740

Gerrit-Change-Number: 7602393

Gerrit-PatchSet: 14

Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-CC: Adam Rice <ri...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>

Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Mar 2026 18:27:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Adam Rice <ri...@chromium.org>

[Nidhi Jaju (Gerrit)]

Attention needed from Adam Rice and krishna dheeraj Pannala

Nidhi Jaju voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• krishna dheeraj Pannala

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0b62675b5d10b71fa9af6424d8bc2a9579135740

Gerrit-Change-Number: 7602393

Gerrit-PatchSet: 14

Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-CC: Adam Rice <ri...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Mar 2026 23:48:50 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Nidhi Jaju (Gerrit)]

Attention needed from Adam Rice and krishna dheeraj Pannala

Nidhi Jaju added 1 comment

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Nidhi Jaju . resolved

I think Adam still needs to review this as a //third_party/blink/renderer/modules/webtransport/ owner.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• krishna dheeraj Pannala

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0b62675b5d10b71fa9af6424d8bc2a9579135740

Gerrit-Change-Number: 7602393

Gerrit-PatchSet: 14

Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Himanshu Panwar <himp...@microsoft.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Mar 2026 23:50:40 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No