[v8] Remove use of to-be-deprecated enum values in PromiseRejectHandler [chromium/src : main]

33 views
Skip to first unread message

Olivier Flückiger (Gerrit)

unread,
Mar 30, 2026, 6:00:13 AM (3 days ago) Mar 30
to Kevin Gibbons, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Gibbons and Michael Lippautz

Olivier Flückiger added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Olivier Flückiger . resolved

@mlippautz ptal. (lgtm)

Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Gibbons
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8c8ae8c4bd9a10acde37de8a5a4509ce0c45743d
Gerrit-Change-Number: 7692381
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Gibbons <bak...@gmail.com>
Gerrit-Reviewer: Kevin Gibbons <bak...@gmail.com>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Olivier Flückiger <ol...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Kevin Gibbons <bak...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Mar 2026 09:59:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Mar 30, 2026, 6:05:56 AM (3 days ago) Mar 30
to Kevin Gibbons, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Gibbons

Michael Lippautz voted and added 1 comment

Votes added by Michael Lippautz

Code-Review+1

1 comment

File third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
Line 331, Patchset 1 (Latest): // The only other types are kPromiseRejectAfterResolved and
Michael Lippautz . unresolved

If those are removed "asap" (in the next days), then you don't even need the comment.

Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Gibbons
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8c8ae8c4bd9a10acde37de8a5a4509ce0c45743d
Gerrit-Change-Number: 7692381
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Gibbons <bak...@gmail.com>
Gerrit-Reviewer: Kevin Gibbons <bak...@gmail.com>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Olivier Flückiger <ol...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Kevin Gibbons <bak...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Mar 2026 10:05:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kevin Gibbons (Gerrit)

unread,
Mar 30, 2026, 10:51:48 AM (3 days ago) Mar 30
to Michael Lippautz, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Michael Lippautz

Kevin Gibbons added 1 comment

File third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
Line 331, Patchset 1 (Latest): // The only other types are kPromiseRejectAfterResolved and
Michael Lippautz . unresolved

If those are removed "asap" (in the next days), then you don't even need the comment.

Kevin Gibbons

They're going to be deprecated but not actually removed until this has had a chance to go out in a release, so that consumers have an opportunity to see the deprecation and remove their use.

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8c8ae8c4bd9a10acde37de8a5a4509ce0c45743d
Gerrit-Change-Number: 7692381
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Gibbons <bak...@gmail.com>
Gerrit-Reviewer: Kevin Gibbons <bak...@gmail.com>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Olivier Flückiger <ol...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Mon, 30 Mar 2026 14:51:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Lippautz <mlip...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages