[v8] Remove use of to-be-deprecated enum values in PromiseRejectHandler [chromium/src : main]
38 views
Skip to first unread message
Olivier Flückiger (Gerrit)
Mar 30, 2026, 6:00:13 AMMar 30
to Kevin Gibbons, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Gibbons and Michael Lippautz
Olivier Flückiger added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Kevin Gibbons
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Mar 30, 2026, 6:05:56 AMMar 30
to Kevin Gibbons, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Gibbons
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
Line 331, Patchset 1 (Latest):
// The only other types are kPromiseRejectAfterResolved andMichael Lippautz . unresolved
If those are removed "asap" (in the next days), then you don't even need the comment.
Related details
Attention is currently required from:
- Kevin Gibbons
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Gibbons (Gerrit)
Mar 30, 2026, 10:51:48 AMMar 30
to Michael Lippautz, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Michael Lippautz
Kevin Gibbons added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
Line 331, Patchset 1 (Latest):
// The only other types are kPromiseRejectAfterResolved andMichael Lippautz . unresolved
If those are removed "asap" (in the next days), then you don't even need the comment.
Kevin Gibbons
They're going to be deprecated but not actually removed until this has had a chance to go out in a release, so that consumers have an opportunity to see the deprecation and remove their use.
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Apr 13, 2026, 3:14:03 AMApr 13
to Kevin Gibbons, Kouhei Ueno, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Gibbons, Kouhei Ueno and Michael Lippautz
Olivier Flückiger added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Kevin Gibbons
- Kouhei Ueno
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Apr 16, 2026, 10:36:40 AM (11 days ago) Apr 16
to Kevin Gibbons, Michael Lippautz, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Gibbons and Michael Lippautz
Kouhei Ueno voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kevin Gibbons
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Apr 17, 2026, 8:59:12 AM (10 days ago) Apr 17
to Kevin Gibbons, Kouhei Ueno, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Gibbons
Michael Lippautz added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
Line 331, Patchset 1 (Latest):
// The only other types are kPromiseRejectAfterResolved andMichael Lippautz . resolved
Kevin GibbonsIf those are removed "asap" (in the next days), then you don't even need the comment.
They're going to be deprecated but not actually removed until this has had a chance to go out in a release, so that consumers have an opportunity to see the deprecation and remove their use.
Michael Lippautz
Just to be clear. This is fine as-is.
Related details
Attention is currently required from:
- Kevin Gibbons
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Gibbons (Gerrit)
Apr 17, 2026, 10:26:00 AM (10 days ago) Apr 17
to Kouhei Ueno, Michael Lippautz, Olivier Flückiger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Kevin Gibbons voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 17, 2026, 11:30:06 AM (10 days ago) Apr 17
to Kevin Gibbons, Kouhei Ueno, Michael Lippautz, Olivier Flückiger, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[v8] Remove use of to-be-deprecated enum values in PromiseRejectHandler
We intend to deprecate and later remove these values as part of
https://chromium-review.googlesource.com/c/v8/v8/+/7646250
Bug: 42213031
Change-Id: I8c8ae8c4bd9a10acde37de8a5a4509ce0c45743d
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Kevin Gibbons <bak...@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1616589}
Files:
- M third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
Change size: XS
Delta: 1 file changed, 4 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz, +1 by Kouhei Ueno
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages