[bindings] Split generate_bindings_all into per-type actions [chromium/src : main]

38 views
Skip to first unread message

Neri Marschik (Gerrit)

unread,
Apr 13, 2026, 1:17:54 AMApr 13
to Philipp Wollermann, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Philipp Wollermann

Message from Neri Marschik

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Philipp Wollermann
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9cf70a36c2e7237a24a10482c9366c1efb374e31
Gerrit-Change-Number: 7754182
Gerrit-PatchSet: 1
Gerrit-Owner: Neri Marschik <ner...@google.com>
Gerrit-Reviewer: Philipp Wollermann <phi...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Philipp Wollermann <phi...@google.com>
Gerrit-Comment-Date: Mon, 13 Apr 2026 05:17:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Philipp Wollermann (Gerrit)

unread,
Apr 13, 2026, 1:28:16 AMApr 13
to Neri Marschik, Kouhei Ueno, Chromium LUCI CQ, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kouhei Ueno and Neri Marschik

Philipp Wollermann voted and added 1 comment

Votes added by Philipp Wollermann

Code-Review+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Philipp Wollermann . resolved

Whoah! 85s down to 56s for this action that ALWAYS shows up during the Chrome build and takes ages to complete... thank you Neri!

Open in Gerrit

Related details

Attention is currently required from:
  • Kouhei Ueno
  • Neri Marschik
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9cf70a36c2e7237a24a10482c9366c1efb374e31
    Gerrit-Change-Number: 7754182
    Gerrit-PatchSet: 1
    Gerrit-Owner: Neri Marschik <ner...@google.com>
    Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Reviewer: Neri Marschik <ner...@google.com>
    Gerrit-Reviewer: Philipp Wollermann <phi...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Neri Marschik <ner...@google.com>
    Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 05:27:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Neri Marschik (Gerrit)

    unread,
    Apr 13, 2026, 1:32:06 AMApr 13
    to Kouhei Ueno, Philipp Wollermann, Chromium LUCI CQ, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Kouhei Ueno

    Neri Marschik added 1 comment

    Patchset-level comments
    Philipp Wollermann . resolved

    Whoah! 85s down to 56s for this action that ALWAYS shows up during the Chrome build and takes ages to complete... thank you Neri!

    Neri Marschik

    I am still running more benchmarks on my cloudtop to see how it affects wall time of a Chrome build. I will report back / amend the commit message.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kouhei Ueno
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9cf70a36c2e7237a24a10482c9366c1efb374e31
    Gerrit-Change-Number: 7754182
    Gerrit-PatchSet: 1
    Gerrit-Owner: Neri Marschik <ner...@google.com>
    Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Reviewer: Neri Marschik <ner...@google.com>
    Gerrit-Reviewer: Philipp Wollermann <phi...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 05:31:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Philipp Wollermann <phi...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kouhei Ueno (Gerrit)

    unread,
    Apr 16, 2026, 10:37:16 AM (11 days ago) Apr 16
    to Neri Marschik, Philipp Wollermann, Chromium LUCI CQ, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Neri Marschik

    Kouhei Ueno voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Neri Marschik
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9cf70a36c2e7237a24a10482c9366c1efb374e31
    Gerrit-Change-Number: 7754182
    Gerrit-PatchSet: 1
    Gerrit-Owner: Neri Marschik <ner...@google.com>
    Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Reviewer: Neri Marschik <ner...@google.com>
    Gerrit-Reviewer: Philipp Wollermann <phi...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Neri Marschik <ner...@google.com>
    Gerrit-Comment-Date: Thu, 16 Apr 2026 14:36:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Neri Marschik (Gerrit)

    unread,
    Apr 23, 2026, 10:14:17 PM (3 days ago) Apr 23
    to Kouhei Ueno, Philipp Wollermann, Chromium LUCI CQ, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, blink-...@chromium.org

    Neri Marschik voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9cf70a36c2e7237a24a10482c9366c1efb374e31
    Gerrit-Change-Number: 7754182
    Gerrit-PatchSet: 1
    Gerrit-Owner: Neri Marschik <ner...@google.com>
    Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Reviewer: Neri Marschik <ner...@google.com>
    Gerrit-Reviewer: Philipp Wollermann <phi...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Comment-Date: Fri, 24 Apr 2026 02:13:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 23, 2026, 11:19:07 PM (3 days ago) Apr 23
    to Neri Marschik, Kouhei Ueno, Philipp Wollermann, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [bindings] Split generate_bindings_all into per-type actions

    Split the monolithic generate_bindings_all action into 11 per-type
    actions (one per IDL construct type) to enable parallel execution
    on RBE. A group target preserves the original name so all existing
    dependencies continue to work unchanged.

    Previously, a single action generated all 5,698 output files on one
    RBE worker (85s remote exec). Now each type runs on its own worker
    in parallel, with the critical path reduced to 56s (interface
    generation alone).
    Change-Id: I9cf70a36c2e7237a24a10482c9366c1efb374e31
    Reviewed-by: Kouhei Ueno <kou...@chromium.org>
    Reviewed-by: Philipp Wollermann <phi...@google.com>
    Commit-Queue: Neri Marschik <ner...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1619938}
    Files:
    • M third_party/blink/renderer/bindings/BUILD.gn
    Change size: M
    Delta: 1 file changed, 93 insertions(+), 44 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kouhei Ueno, +1 by Philipp Wollermann
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9cf70a36c2e7237a24a10482c9366c1efb374e31
    Gerrit-Change-Number: 7754182
    Gerrit-PatchSet: 2
    Gerrit-Owner: Neri Marschik <ner...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Reviewer: Neri Marschik <ner...@google.com>
    Gerrit-Reviewer: Philipp Wollermann <phi...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages