Stop generating *NonNull accessors in IDL dictionaries [chromium/src : main]
0 views
Skip to first unread message
Fredrik Söderquist (Gerrit)
Sep 29, 2025, 9:22:44 AM (7 days ago) Sep 29
to Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, video-networking...@google.com
Attention needed from Yuki Shiino
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Yuki Shiino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuki Shiino (Gerrit)
Sep 30, 2025, 2:34:19 AM (6 days ago) Sep 30
to Fredrik Söderquist, Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, video-networking...@google.com
Attention needed from Fredrik Söderquist
Yuki Shiino voted and added 2 comments![]( "Open in Gerrit")
Votes added by Yuki Shiino
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/renderer/bindings/scripts/bind_gen/dictionary.py
Line 1027, Patchset 1 (Latest):
# blink_to_v8_decls, blink_to_v8_defs = make_blink_to_v8_function(cg_context)Yuki Shiino . unresolved
Not related to your change at all, but would you mind removing this comment-out? This is a leftover. (It's totally fine to not remove this in this CL. It's totally optional.)
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
Sep 30, 2025, 5:07:16 AM (6 days ago) Sep 30
to Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, video-networking...@google.com
Fredrik Söderquist voted and added 1 comment![]( "Open in Gerrit")
Votes added by Fredrik Söderquist
| Commit-Queue | +2 |
1 comment
File third_party/blink/renderer/bindings/scripts/bind_gen/dictionary.py
Line 1027, Patchset 1:
# blink_to_v8_decls, blink_to_v8_defs = make_blink_to_v8_function(cg_context)Yuki Shiino . resolved
Not related to your change at all, but would you mind removing this comment-out? This is a leftover. (It's totally fine to not remove this in this CL. It's totally optional.)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 30, 2025, 5:54:13 AM (6 days ago) Sep 30
to Fredrik Söderquist, Yuki Shiino, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, video-networking...@google.com
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/bindings/scripts/bind_gen/dictionary.py
Insertions: 0, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Stop generating *NonNull accessors in IDL dictionaries
Convert remaining users of Dictionary::{has,get}...NonNull(), and then
stop generating them.
Bug: 40126515
Change-Id: Ia03ada8e4c3e352bca4f54e98dfaa3cda08bec16
Reviewed-by: Yuki Shiino <yukis...@chromium.org>
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Cr-Commit-Position: refs/heads/main@{#1522754}
Files:
- M third_party/blink/renderer/bindings/scripts/bind_gen/dictionary.py
- M third_party/blink/renderer/core/frame/reporting_observer.cc
- M third_party/blink/renderer/modules/ad_auction/navigator_auction.cc
- M third_party/blink/renderer/modules/cookie_store/cookie_store.cc
- M third_party/blink/renderer/modules/device_orientation/device_motion_event_acceleration.cc
- M third_party/blink/renderer/modules/device_orientation/device_motion_event_rotation_rate.cc
- M third_party/blink/renderer/modules/file_system_access/file_system_underlying_sink.cc
- M third_party/blink/renderer/modules/peerconnection/rtc_ice_candidate.cc
- M third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
Change size: M
Delta: 9 files changed, 35 insertions(+), 100 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuki Shiino
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages