webcodecs: IDL for manual reference frame control in VideoEncoder [chromium/src : main]
72 views
Skip to first unread message
Jeremy Roman (Gerrit)
Jun 18, 2024, 2:19:04 PM (11 days ago) Jun 18
to Eugene Zemtsov, Jeremy Roman, Daniel Cheng, Dan Sanders, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Sanders, Daniel Cheng and Eugene Zemtsov
Jeremy Roman added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Jeremy Roman . resolved
Can you clarify what you'd like my attention on? The IDL seems to match what's in the GitHub issue and isn't obviously incorrect, but I don't have enough domain knowledge to evaluate it beyond that.
Or am I here simply for runtime_enabled_features.json5, and sandersd@ will provide the substantive review?
Related details
Attention is currently required from:
- Dan Sanders
- Daniel Cheng
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jun 18, 2024, 3:51:19 PM (11 days ago) Jun 18
to Eugene Zemtsov, Jeremy Roman, Daniel Cheng, Dan Sanders, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Sanders, Daniel Cheng and Jeremy Roman
Eugene Zemtsov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jeremy Roman . resolved
Can you clarify what you'd like my attention on? The IDL seems to match what's in the GitHub issue and isn't obviously incorrect, but I don't have enough domain knowledge to evaluate it beyond that.
Or am I here simply for runtime_enabled_features.json5, and sandersd@ will provide the substantive review?
Eugene Zemtsov
Yeah, I added you solely for runtime_enabled_features.json5. Sorry about the confusion.
Related details
Attention is currently required from:
- Dan Sanders
- Daniel Cheng
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Jun 18, 2024, 3:52:02 PM (11 days ago) Jun 18
to Eugene Zemtsov, Jeremy Roman, Daniel Cheng, Dan Sanders, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Sanders, Daniel Cheng and Eugene Zemtsov
Jeremy Roman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dan Sanders
- Daniel Cheng
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jun 18, 2024, 3:58:21 PM (11 days ago) Jun 18
to Eugene Zemtsov, Jeremy Roman, Daniel Cheng, Dan Sanders, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Sanders and Eugene Zemtsov
Daniel Cheng added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Daniel Cheng . resolved
(like jbroman, I'm wondering what my review is being requested for :)
Related details
Attention is currently required from:
- Dan Sanders
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jun 18, 2024, 4:04:17 PM (11 days ago) Jun 18
to Eugene Zemtsov, Jeremy Roman, Dan Sanders, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dan Sanders
Eugene Zemtsov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Daniel Cheng . resolved
(like jbroman, I'm wondering what my review is being requested for :)
Eugene Zemtsov
sorry, removed
Related details
Attention is currently required from:
- Dan Sanders
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dan Sanders (Gerrit)
Jun 18, 2024, 4:36:14 PM (11 days ago) Jun 18
to Eugene Zemtsov, Jeremy Roman, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Eugene Zemtsov
Dan Sanders voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jun 18, 2024, 6:45:26 PM (11 days ago) Jun 18
to Eugene Zemtsov, Dan Sanders, Jeremy Roman, Tricium, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Eugene Zemtsov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2024, 6:49:08 PM (11 days ago) Jun 18
to Eugene Zemtsov, Dan Sanders, Jeremy Roman, Tricium, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
webcodecs: IDL for manual reference frame control in VideoEncoder
Bug: 347676170
Change-Id: I1e7e5aa67ee2e59cbf4aff3791bcbfbad390c17c
Reviewed-by: Dan Sanders <sand...@chromium.org>
Reviewed-by: Jeremy Roman <jbr...@chromium.org>
Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1316743}
Files:
- M third_party/blink/renderer/bindings/generated_in_modules.gni
- M third_party/blink/renderer/bindings/idl_in_modules.gni
- M third_party/blink/renderer/modules/webcodecs/BUILD.gn
- M third_party/blink/renderer/modules/webcodecs/video_encoder.cc
- M third_party/blink/renderer/modules/webcodecs/video_encoder.h
- M third_party/blink/renderer/modules/webcodecs/video_encoder.idl
- A third_party/blink/renderer/modules/webcodecs/video_encoder_buffer.cc
- A third_party/blink/renderer/modules/webcodecs/video_encoder_buffer.h
- A third_party/blink/renderer/modules/webcodecs/video_encoder_buffer.idl
- M third_party/blink/renderer/modules/webcodecs/video_encoder_encode_options.idl
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
- M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
Change size: M
Delta: 13 files changed, 97 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dan Sanders, +1 by Jeremy Roman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Jun 18, 2024, 7:21:37 PM (11 days ago) Jun 18
to Eugene Zemtsov, Chromium LUCI CQ, Dan Sanders, Jeremy Roman, Tricium, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Eugene Zemtsov
Dale Curtis added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/runtime_enabled_features.json5
Line 4482, Patchset 6 (Latest):
status: "experimental",Dale Curtis . unresolved
Probably `test` is more appropriate given the current state.
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jun 18, 2024, 8:17:26 PM (11 days ago) Jun 18
to Eugene Zemtsov, Chromium LUCI CQ, Dale Curtis, Dan Sanders, Jeremy Roman, Tricium, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Eugene Zemtsov added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/runtime_enabled_features.json5
Line 4482, Patchset 6 (Latest):
status: "experimental",Dale Curtis . resolved
Probably `test` is more appropriate given the current state.
Eugene Zemtsov
"experimental" -
These features may be turned on using the "Experimental Web Platform features" flag in chrome://flags/#enable-experimental-web-platform-features.
I'd really like this
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jun 18, 2024, 8:23:11 PM (11 days ago) Jun 18
to Eugene Zemtsov, Chromium LUCI CQ, Dale Curtis, Dan Sanders, Jeremy Roman, Tricium, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Eugene Zemtsov added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/runtime_enabled_features.json5
Line 4482, Patchset 6 (Latest):
status: "experimental",Dale Curtis . resolved
Eugene ZemtsovProbably `test` is more appropriate given the current state.
"experimental" -
These features may be turned on using the "Experimental Web Platform features" flag in chrome://flags/#enable-experimental-web-platform-features.
I'd really like this
Eugene Zemtsov
we have the same status for MediaSourceExtensionsForWebCodecs
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Jun 18, 2024, 9:57:55 PM (11 days ago) Jun 18
to Eugene Zemtsov, Chromium LUCI CQ, Dan Sanders, Jeremy Roman, Tricium, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Eugene Zemtsov
Dale Curtis added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/runtime_enabled_features.json5
Line 4482, Patchset 6 (Latest):
status: "experimental",Dale Curtis . unresolved
Eugene ZemtsovProbably `test` is more appropriate given the current state.
Eugene Zemtsov"experimental" -
These features may be turned on using the "Experimental Web Platform features" flag in chrome://flags/#enable-experimental-web-platform-features.
I'd really like this
we have the same status for MediaSourceExtensionsForWebCodecs
Dale Curtis
I think it's fine once you implement it, but right now this is just stubbed out?
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages