Remove base::MakeCheckedNum<>(). [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Jan 15, 2026, 3:37:41 PM (23 hours ago) Jan 15
to Tom Sepez, Daniel Cheng, Kentaro Hara, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, lize...@chromium.org, bartek...@chromium.org, enne...@chromium.org, lizeb...@chromium.org, blink-...@chromium.org, edgesto...@microsoft.com, jbroma...@chromium.org, storage...@chromium.org, blink-revie...@chromium.org, wfh+...@chromium.org, dmurph+wa...@chromium.org, net-r...@chromium.org
Attention needed from Tom Sepez

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 13 (Latest):
Daniel Cheng . unresolved

LGTM w/two thoughts.

1. I would remove the actual `MakeCheckedNum()` implementation in a separate CL, just in case there's a random builder that uses this that we don't have covered by default here.
2. Supporting older C++ isn't an issue anymore right? There was previously even a time when we couldn't use explicit deduction guides due to some projects depending on C++14.

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ied9d7a72c7013b67f4f1af599bc8408e49b650ac
Gerrit-Change-Number: 7467258
Gerrit-PatchSet: 13
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Jan 2026 20:37:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Jan 15, 2026, 3:39:11 PM (23 hours ago) Jan 15
to Daniel Cheng, Kentaro Hara, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, lize...@chromium.org, bartek...@chromium.org, enne...@chromium.org, lizeb...@chromium.org, blink-...@chromium.org, edgesto...@microsoft.com, jbroma...@chromium.org, storage...@chromium.org, blink-revie...@chromium.org, wfh+...@chromium.org, dmurph+wa...@chromium.org, net-r...@chromium.org

Tom Sepez voted and added 1 comment

Votes added by Tom Sepez

Commit-Queue+1

1 comment

Patchset-level comments
Daniel Cheng . resolved

LGTM w/two thoughts.

1. I would remove the actual `MakeCheckedNum()` implementation in a separate CL, just in case there's a random builder that uses this that we don't have covered by default here.
2. Supporting older C++ isn't an issue anymore right? There was previously even a time when we couldn't use explicit deduction guides due to some projects depending on C++14.

Tom Sepez

1. HFTB.
2. Right.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ied9d7a72c7013b67f4f1af599bc8408e49b650ac
    Gerrit-Change-Number: 7467258
    Gerrit-PatchSet: 13
    Gerrit-Owner: Tom Sepez <tse...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 20:39:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tom Sepez (Gerrit)

    unread,
    Jan 15, 2026, 4:32:31 PM (22 hours ago) Jan 15
    to Evan Stade, David Benjamin, Daniel Cheng, Kentaro Hara, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, lize...@chromium.org, bartek...@chromium.org, enne...@chromium.org, lizeb...@chromium.org, blink-...@chromium.org, edgesto...@microsoft.com, jbroma...@chromium.org, storage...@chromium.org, blink-revie...@chromium.org, wfh+...@chromium.org, dmurph+wa...@chromium.org, net-r...@chromium.org
    Attention needed from David Benjamin and Evan Stade

    Tom Sepez added 1 comment

    Patchset-level comments
    Tom Sepez . resolved

    +Evan for leveldb, +David for dns

    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Benjamin
    • Evan Stade
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ied9d7a72c7013b67f4f1af599bc8408e49b650ac
    Gerrit-Change-Number: 7467258
    Gerrit-PatchSet: 13
    Gerrit-Owner: Tom Sepez <tse...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
    Gerrit-Reviewer: Evan Stade <evan...@microsoft.com>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Evan Stade <evan...@microsoft.com>
    Gerrit-Attention: David Benjamin <davi...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 21:32:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Benjamin (Gerrit)

    unread,
    Jan 15, 2026, 4:33:32 PM (22 hours ago) Jan 15
    to Tom Sepez, Evan Stade, Daniel Cheng, Kentaro Hara, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, lize...@chromium.org, bartek...@chromium.org, enne...@chromium.org, lizeb...@chromium.org, blink-...@chromium.org, edgesto...@microsoft.com, jbroma...@chromium.org, storage...@chromium.org, blink-revie...@chromium.org, wfh+...@chromium.org, dmurph+wa...@chromium.org, net-r...@chromium.org
    Attention needed from Evan Stade and Tom Sepez

    David Benjamin voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Evan Stade
    • Tom Sepez
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Evan Stade <evan...@microsoft.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 21:33:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Evan Stade (Gerrit)

    unread,
    Jan 15, 2026, 6:05:17 PM (20 hours ago) Jan 15
    to Tom Sepez, David Benjamin, Daniel Cheng, Kentaro Hara, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, lize...@chromium.org, bartek...@chromium.org, enne...@chromium.org, lizeb...@chromium.org, blink-...@chromium.org, edgesto...@microsoft.com, jbroma...@chromium.org, storage...@chromium.org, blink-revie...@chromium.org, wfh+...@chromium.org, dmurph+wa...@chromium.org, net-r...@chromium.org
    Attention needed from Tom Sepez

    Evan Stade voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tom Sepez
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ied9d7a72c7013b67f4f1af599bc8408e49b650ac
    Gerrit-Change-Number: 7467258
    Gerrit-PatchSet: 13
    Gerrit-Owner: Tom Sepez <tse...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
    Gerrit-Reviewer: Evan Stade <evan...@microsoft.com>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:05:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Tom Sepez (Gerrit)

    unread,
    Jan 15, 2026, 7:03:47 PM (19 hours ago) Jan 15
    to Evan Stade, David Benjamin, Daniel Cheng, Kentaro Hara, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, lize...@chromium.org, bartek...@chromium.org, enne...@chromium.org, lizeb...@chromium.org, blink-...@chromium.org, edgesto...@microsoft.com, jbroma...@chromium.org, storage...@chromium.org, blink-revie...@chromium.org, wfh+...@chromium.org, dmurph+wa...@chromium.org, net-r...@chromium.org

    Tom Sepez voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Fri, 16 Jan 2026 00:03:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 15, 2026, 7:07:28 PM (19 hours ago) Jan 15
    to Tom Sepez, Evan Stade, David Benjamin, Daniel Cheng, Kentaro Hara, Raphael Kubo da Costa, AyeAye, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, lize...@chromium.org, bartek...@chromium.org, enne...@chromium.org, lizeb...@chromium.org, blink-...@chromium.org, edgesto...@microsoft.com, jbroma...@chromium.org, storage...@chromium.org, blink-revie...@chromium.org, wfh+...@chromium.org, dmurph+wa...@chromium.org, net-r...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove base::MakeCheckedNum<>().

    Prefer CTAD which correctly handles mismatch between an explicit
    type specification (if any) and the actual argument.

    -- automated conversion of remaining callers.
    Change-Id: Ied9d7a72c7013b67f4f1af599bc8408e49b650ac
    Reviewed-by: Evan Stade <evan...@microsoft.com>
    Reviewed-by: Daniel Cheng <dch...@chromium.org>
    Reviewed-by: David Benjamin <davi...@chromium.org>
    Commit-Queue: Tom Sepez <tse...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1570076}
    Files:
    • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/numerics/checked_math.h
    • M base/numerics/README.md
    • M base/numerics/checked_math.h
    • M base/safe_numerics_unittest.cc
    • M components/base32/base32.cc
    • M components/chromeos_camera/common/mjpeg_decode_accelerator_mojom_traits.cc
    • M content/browser/indexed_db/indexed_db_leveldb_coding.cc
    • M net/dns/dns_response_result_extractor.cc
    • M services/webnn/dml/graph_impl_dml.cc
    • M services/webnn/dml/tensor_desc.cc
    • M services/webnn/ort/graph_builder_ort.cc
    • M services/webnn/public/cpp/graph_validation_utils.cc
    • M services/webnn/tflite/graph_builder_tflite.cc
    • M skia/public/mojom/image_info_mojom_traits.cc
    • M third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_deserializer.cc
    • M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
    Change size: M
    Delta: 16 files changed, 96 insertions(+), 120 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Evan Stade, +1 by Daniel Cheng, +1 by David Benjamin
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ied9d7a72c7013b67f4f1af599bc8408e49b650ac
    Gerrit-Change-Number: 7467258
    Gerrit-PatchSet: 14
    Gerrit-Owner: Tom Sepez <tse...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
    Gerrit-Reviewer: Evan Stade <evan...@microsoft.com>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages