Revert "Make DataObject not Supplementable." [chromium/src : main]

0 views
Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,
Dec 10, 2025, 7:46:40 AM (4 days ago) Dec 10
to Arnaud Mandy, Permissions Reviews, Rijubrata Bhaumik, Kaan Icer, Nate Chapin, Raphael Kubo da Costa, Simon Hangl, Hiroki Nakagawa, Luna Lu, Fredrik Söderquist, Menard, Alexis, Kentaro Hara, Gyuyoung Kim, Daniel Cheng, Wanming Lin, srirama chandra sekhar, Olga Gerchikov, chromium...@chromium.org, Wang, Wei4, Andrew Rayskiy, Xida Chen, Kenneth R Christiansen, prerendering-reviews, Stephen Chenney, David Bokan, Christian Biesinger, Hongchan Choi, Yoav Weiss (@Shopify), Dirk Schulze, Peter Beverloo, iclella...@chromium.org, blink-rev...@chromium.org, nator...@chromium.org, pdr+svgw...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, npm+...@chromium.org, dtapuska+...@chromium.org, storage...@chromium.org, blink-...@chromium.org, blink-revi...@chromium.org, dmurph+watch...@chromium.org, print-rev...@chromium.org, mfoltz+wa...@chromium.org, cros-print...@google.com, kinuko...@chromium.org, giovax...@chromium.org, chromium-a...@chromium.org, jmedle...@chromium.org, tommyw+w...@chromium.org, kinuko+...@chromium.org, kainin...@chromium.org, zol...@webkit.org, apavlo...@chromium.org, servicewor...@chromium.org, dcheng+c...@chromium.org, speed-metrics...@chromium.org, eric.c...@apple.com, rmcelra...@chromium.org, kouhe...@chromium.org, webap...@microsoft.com, blink-re...@chromium.org, odejesu...@chromium.org, horo+...@chromium.org, mattreyno...@chromium.org, blink-revi...@chromium.org, oshima...@chromium.org, feature-v...@chromium.org, loading...@chromium.org, sloboda...@chromium.org, loading-rev...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, dmurph+watchi...@chromium.org, toyosh...@chromium.org, webauthn...@chromium.org, dmurph+wa...@chromium.org, jkarli...@chromium.org, rayanka...@chromium.org, yigu+...@chromium.org, aleventh...@chromium.org, mgiuca...@chromium.org, kinuko+ser...@chromium.org, gavinp...@chromium.org, fmalit...@chromium.org, cwalle...@chromium.org, devtools-re...@chromium.org, blink-work...@chromium.org, blink-revi...@chromium.org, video-networking...@google.com, edgesto...@microsoft.com, derinel+wat...@google.com, gavinp+p...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, enne...@chromium.org, mfoltz+wa...@chromium.org, pkotwic...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, web-schedulin...@chromium.org, dominicc+...@chromium.org, extension...@chromium.org
Attention needed from Daniel Cheng

Steinar H Gunderson has uploaded the change for review

Steinar H Gunderson would like Daniel Cheng to review this change.

Commit message

Revert "Make DataObject not Supplementable."

This reverts commit 664cfd60fd204d038a4ea708f712add661b7514d.
(See blink-dev for background.)
Bug: 460165754
Change-Id: Ia9bdcc32c2a80cb6441b27ea23c18c0ac9dd7f10

Change diff


Change information

Files:
  • M third_party/blink/renderer/core/clipboard/data_object.cc
  • M third_party/blink/renderer/core/clipboard/data_object.h
  • M third_party/blink/renderer/modules/filesystem/dragged_isolated_file_system_impl.cc
  • M third_party/blink/renderer/modules/filesystem/dragged_isolated_file_system_impl.h
Change size: S
Delta: 4 files changed, 14 insertions(+), 23 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia9bdcc32c2a80cb6441b27ea23c18c0ac9dd7f10
Gerrit-Change-Number: 7245789
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Gyuyoung Kim <gyuyou...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Wang, Wei4 <wei4...@intel.com>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Dec 10, 2025, 3:28:52 PM (4 days ago) Dec 10
to Steinar H Gunderson, Daniel Cheng, Menard, Alexis, Arnaud Mandy, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Gyuyoung Kim, Kentaro Hara, Hongchan Choi, Kaan Icer, Nate Chapin, Kenneth R Christiansen, Raphael Kubo da Costa, Luna Lu, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Wanming Lin, Wang, Wei4, Xida Chen, Yoav Weiss (@Shopify), aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, cros-print...@google.com, cwalle...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watch...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, giovax...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, yigu+...@chromium.org, zol...@webkit.org
Attention needed from Steinar H Gunderson

Daniel Cheng voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Wed, 10 Dec 2025 20:28:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Steinar H Gunderson (Gerrit)

unread,
Dec 11, 2025, 9:06:08 AM (3 days ago) Dec 11
to Chromium LUCI CQ, Daniel Cheng, Menard, Alexis, Arnaud Mandy, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Gyuyoung Kim, Kentaro Hara, Hongchan Choi, Kaan Icer, Nate Chapin, Kenneth R Christiansen, Raphael Kubo da Costa, Luna Lu, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Wanming Lin, Wang, Wei4, Xida Chen, Yoav Weiss (@Shopify), gl...@chromium.org, silv...@chromium.org, aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, cros-print...@google.com, cwalle...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watch...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, giovax...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, yigu+...@chromium.org, zol...@webkit.org

Steinar H Gunderson voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia9bdcc32c2a80cb6441b27ea23c18c0ac9dd7f10
Gerrit-Change-Number: 7245789
Gerrit-PatchSet: 6
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 14:05:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 11, 2025, 1:27:02 PM (3 days ago) Dec 11
to Steinar H Gunderson, Daniel Cheng, Menard, Alexis, Arnaud Mandy, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Andrew Rayskiy, Gyuyoung Kim, Kentaro Hara, Hongchan Choi, Kaan Icer, Nate Chapin, Kenneth R Christiansen, Raphael Kubo da Costa, Luna Lu, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Wanming Lin, Wang, Wei4, Xida Chen, Yoav Weiss (@Shopify), gl...@chromium.org, silv...@chromium.org, aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, core-timi...@chromium.org, cros-print...@google.com, cwalle...@chromium.org, dcheng+c...@chromium.org, derinel+wat...@google.com, devtools-re...@chromium.org, dmurph+watchi...@chromium.org, dmurph+wa...@chromium.org, dmurph+watch...@chromium.org, dominicc+...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, gavinp...@chromium.org, gavinp+p...@chromium.org, giovax...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, sloboda...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, yigu+...@chromium.org, zol...@webkit.org

Chromium LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Revert "Make DataObject not Supplementable."

This reverts commit 664cfd60fd204d038a4ea708f712add661b7514d.
(See blink-dev for background.)
Bug: 460165754
Change-Id: Ia9bdcc32c2a80cb6441b27ea23c18c0ac9dd7f10
Commit-Queue: Steinar H Gunderson <se...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1557532}
Files:
  • M third_party/blink/renderer/core/clipboard/data_object.cc
  • M third_party/blink/renderer/core/clipboard/data_object.h
  • M third_party/blink/renderer/modules/filesystem/dragged_isolated_file_system_impl.cc
  • M third_party/blink/renderer/modules/filesystem/dragged_isolated_file_system_impl.h
Change size: S
Delta: 4 files changed, 14 insertions(+), 23 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia9bdcc32c2a80cb6441b27ea23c18c0ac9dd7f10
Gerrit-Change-Number: 7245789
Gerrit-PatchSet: 8
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages