Forwarding abort reason from AbortController.abort() to fetch() promise [chromium/src : main]
Taylor Brandstetter (Gerrit)
Taylor Brandstetter added 2 comments![]( "Open in Gerrit")
I'm doing this following a discussion with Adam. The context is that we (Meet developers) would like the stack information that CreateOrEmpty provides, so we were thinking of just changing body.cc to use that, and preferably adding the fetch URL in the message as well for additional debuggability.
That would require an experiment for changing the message. But Adam also noticed that we should be providing the abort reason as well (if one is provided), which also would require an experiment. In which case we might as well do both at once.
A question though: What would be the best way to go about getting the URL into this message, assuming that's not problematic? The error is now coming from AbortSignal (https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/abort_signal.cc;l=279;drc=0a4317210c4de343411da25ccf8145d3091b3007) which doesn't have that context. Could I provide an optional string to its constructor for a default abort reason? Or would the memory footprint for that be a concern?
await promise_rejects_exactly(t, error1, fetchPromise, 'fetch() should reject with abort reason when aborted after fetch() called');This was already working but I added a test for it for good measure.
Related details
- Taylor Brandstetter
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |