Migrate partial interfaces to mixin in WindowOrWorkerGlobalScope [chromium/src : main]

0 views
Skip to first unread message

Suyeon Ji (Gerrit)

unread,
Oct 3, 2025, 2:37:37 AM (3 days ago) Oct 3
to Jinho Bang, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jmedle...@chromium.org
Attention needed from Jinho Bang

Suyeon Ji added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Suyeon Ji . resolved

Please take a look. Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Jinho Bang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I90639bdf9f81c2b31788556da611bf3ee14b58a4
Gerrit-Change-Number: 7004848
Gerrit-PatchSet: 2
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Jinho Bang <zi...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Oct 2025 06:37:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Suyeon Ji (Gerrit)

unread,
Oct 3, 2025, 2:48:11 AM (3 days ago) Oct 3
to Fergal Daly, Jinho Bang, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jmedle...@chromium.org
Attention needed from Fergal Daly and Jinho Bang

Suyeon Ji added 1 comment

Patchset-level comments
Suyeon Ji . resolved

Hi, Please take a look. Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Fergal Daly
  • Jinho Bang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I90639bdf9f81c2b31788556da611bf3ee14b58a4
Gerrit-Change-Number: 7004848
Gerrit-PatchSet: 2
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Jinho Bang <zi...@chromium.org>
Gerrit-Attention: Fergal Daly <fer...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Oct 2025 06:47:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jinho Bang (Gerrit)

unread,
Oct 3, 2025, 2:48:55 AM (3 days ago) Oct 3
to Suyeon Ji, Fergal Daly, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jmedle...@chromium.org
Attention needed from Fergal Daly and Suyeon Ji

Jinho Bang voted and added 1 comment

Votes added by Jinho Bang

Code-Review+1

1 comment

Patchset-level comments
Jinho Bang . resolved

non-owner lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Fergal Daly
  • Suyeon Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I90639bdf9f81c2b31788556da611bf3ee14b58a4
Gerrit-Change-Number: 7004848
Gerrit-PatchSet: 2
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
Gerrit-Attention: Fergal Daly <fer...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Oct 2025 06:48:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fergal Daly (Gerrit)

unread,
Oct 3, 2025, 3:28:59 AM (3 days ago) Oct 3
to Suyeon Ji, Fergal Daly, Jinho Bang, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jmedle...@chromium.org
Attention needed from Suyeon Ji

Fergal Daly voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Suyeon Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I90639bdf9f81c2b31788556da611bf3ee14b58a4
Gerrit-Change-Number: 7004848
Gerrit-PatchSet: 2
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 07:28:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Suyeon Ji (Gerrit)

unread,
Oct 3, 2025, 10:04:31 AM (3 days ago) Oct 3
to Fergal Daly, Jinho Bang, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jmedle...@chromium.org

Suyeon Ji voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I90639bdf9f81c2b31788556da611bf3ee14b58a4
Gerrit-Change-Number: 7004848
Gerrit-PatchSet: 2
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 14:03:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 3, 2025, 10:18:35 AM (3 days ago) Oct 3
to Suyeon Ji, Fergal Daly, Jinho Bang, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, jmedle...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Migrate partial interfaces to mixin in WindowOrWorkerGlobalScope

This patch migrates partial interfaces to a partial interface mixin
to align with the specification.

This CL has no behavior changes.
Bug: 449023252
Change-Id: I90639bdf9f81c2b31788556da611bf3ee14b58a4
Commit-Queue: Suyeon Ji <zees...@gmail.com>
Reviewed-by: Jinho Bang <zi...@chromium.org>
Reviewed-by: Fergal Daly <fer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1524762}
Files:
  • M third_party/blink/renderer/bindings/idl_in_modules.gni
  • D third_party/blink/renderer/modules/indexeddb/window_indexed_database.idl
  • A third_party/blink/renderer/modules/indexeddb/window_or_worker_global_scope_indexed_database.idl
  • D third_party/blink/renderer/modules/indexeddb/worker_global_scope_indexed_database.idl
Change size: M
Delta: 4 files changed, 12 insertions(+), 64 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jinho Bang, +1 by Fergal Daly
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I90639bdf9f81c2b31788556da611bf3ee14b58a4
Gerrit-Change-Number: 7004848
Gerrit-PatchSet: 3
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages