Convert ByteCount to ByteSize in SysInfo, except AmountOfPhysicalMemory [chromium/src : main]

0 views

Skip to first unread message

Francois Pierre Doray (Gerrit)

unread,

Dec 12, 2025, 11:17:06 AM (2 days ago) Dec 12

to Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Kentaro Hara, Raphael Kubo da Costa, Zijie He, blink-revie...@chromium.org, blink-...@chromium.org, cros-report...@google.com, fuchsia...@chromium.org, kinuko+...@chromium.org, mac-r...@chromium.org, performance-m...@chromium.org, storage...@chromium.org

Attention needed from Joe Mason

Francois Pierre Doray voted and added 1 comment

Votes added by Francois Pierre Doray

Code-Review	+1
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Francois Pierre Doray . resolved

OO+1 for mechanical changes outside of //base

Open in Gerrit

Related details

Attention is currently required from:

Joe Mason

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Dec 12, 2025, 11:49:53 AM (2 days ago) Dec 12

to Francois Pierre Doray, chromium...@chromium.org, Enterprise Policy Reviews, Kentaro Hara, Raphael Kubo da Costa, Zijie He, blink-revie...@chromium.org, blink-...@chromium.org, cros-report...@google.com, fuchsia...@chromium.org, kinuko+...@chromium.org, mac-r...@chromium.org, performance-m...@chromium.org, storage...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Convert ByteCount to ByteSize in SysInfo, except AmountOfPhysicalMemory

AmountOfPhysicalMemory has over 80 callers, so isn't converted yet

Bug: 448661443

Change-Id: I78d51ceffc48607be0d2264b21e673d5fc50e28f

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7254075

Owners-Override: Francois Pierre Doray <fdo...@chromium.org>

Commit-Queue: Joe Mason <joenot...@google.com>

Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1558092}

Files:

M base/process/process_metrics_unittest.cc
M base/system/sys_info.cc
M base/system/sys_info.h
M base/system/sys_info_fuchsia.cc
M base/system/sys_info_ios.mm
M base/system/sys_info_linux.cc
M base/system/sys_info_mac.mm
M base/system/sys_info_posix.cc
M base/system/sys_info_unittest.cc
M base/system/sys_info_win.cc
M chrome/browser/ash/policy/status_collector/device_status_collector.cc
M chrome/browser/performance_manager/metrics/metrics_provider_common.cc
M gin/isolate_holder.cc
M storage/browser/file_system/obfuscated_file_util_memory_delegate.cc
M third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
M third_party/blink/renderer/controller/memory_saver_controller.cc
M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py

Change size: M

Delta: 17 files changed, 67 insertions(+), 61 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Francois Pierre Doray

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages