Implement CSSContainerRule.conditions [chromium/src : main]

0 views

Skip to first unread message

Rune Lillesveen (Gerrit)

unread,

4:14 AM (2 hours ago) 4:14 AM

to Rune Lillesveen, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, Menard, Alexis, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org

Attention needed from Anders Hartvoll Ruud

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Anders Hartvoll Ruud

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Anders Hartvoll Ruud (Gerrit)

unread,

5:13 AM (1 hour ago) 5:13 AM

to Rune Lillesveen, Chromium LUCI CQ, chromium...@chromium.org, Menard, Alexis, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, android-web...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org

Attention needed from Rune Lillesveen

Anders Hartvoll Ruud voted and added 1 comment

Votes added by Anders Hartvoll Ruud

Code-Review

1 comment

File third_party/blink/renderer/core/css/css_container_rule.cc

Line 70, Patchset 1: if (!conditions_) {

Anders Hartvoll Ruud . unresolved

Don't we need to null this on `SetConditionText`? (And test it?)