[v8] Prepare for deprecation of v8::PropertyCallbackInfo<T>::This() [chromium/src : main]

0 views
Skip to first unread message

Igor Sheludko (Gerrit)

unread,
Oct 30, 2025, 5:33:12 AM (3 days ago) Oct 30
to Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Yuki Shiino

Igor Sheludko added 2 comments

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Igor Sheludko . resolved

Yuki, PTAL

File third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
Open in Gerrit

Related details

Attention is currently required from:
  • Yuki Shiino
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a8e3a268135a2282bf70f0604c2a19cf652a7c8
Gerrit-Change-Number: 7088747
Gerrit-PatchSet: 7
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Yuki Shiino <yukis...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 09:32:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuki Shiino (Gerrit)

unread,
Oct 30, 2025, 9:01:16 AM (3 days ago) Oct 30
to Igor Sheludko, Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Igor Sheludko

Yuki Shiino voted and added 2 comments

Votes added by Yuki Shiino

Code-Review+1

2 comments

Patchset-level comments
Yuki Shiino . resolved

LGTM.

File third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
Line 2966, Patchset 7 (Latest):// (V8 calls this callback only when that's the case).\
Igor Sheludko . resolved
Yuki Shiino

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a8e3a268135a2282bf70f0604c2a19cf652a7c8
Gerrit-Change-Number: 7088747
Gerrit-PatchSet: 7
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 13:00:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Igor Sheludko <ish...@chromium.org>
satisfied_requirement
open
diffy

Igor Sheludko (Gerrit)

unread,
Oct 30, 2025, 9:03:49 AM (3 days ago) Oct 30
to Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org

Igor Sheludko voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a8e3a268135a2282bf70f0604c2a19cf652a7c8
Gerrit-Change-Number: 7088747
Gerrit-PatchSet: 7
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 13:03:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 30, 2025, 9:20:23 AM (3 days ago) Oct 30
to Igor Sheludko, Yuki Shiino, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[v8] Prepare for deprecation of v8::PropertyCallbackInfo<T>::This()

Blink was using v8::PropertyCallbackInfo<T>::This() according to the
specification of [[Set]] operation for legacy platform object
(see https://webidl.spec.whatwg.org/#legacy-platform-object-set).
However, this semantics is guaranteed by V8's interceptors Api -
i.e. the setter callback is called only when the receiver is the
holder.
Bug: 455600234
Change-Id: I4a8e3a268135a2282bf70f0604c2a19cf652a7c8
Reviewed-by: Yuki Shiino <yukis...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1537875}
Files:
  • M third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
Change size: S
Delta: 1 file changed, 18 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Yuki Shiino
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a8e3a268135a2282bf70f0604c2a19cf652a7c8
Gerrit-Change-Number: 7088747
Gerrit-PatchSet: 8
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages