[v8] Prepare for deprecation of v8::PropertyCallbackInfo<T>::This() [chromium/src : main]
0 views
Skip to first unread message
Igor Sheludko (Gerrit)
Oct 30, 2025, 5:33:12 AM (3 days ago) Oct 30
to Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Yuki Shiino
Igor Sheludko added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
Line 2966, Patchset 7 (Latest):
// (V8 calls this callback only when that's the case).\Related details
Attention is currently required from:
- Yuki Shiino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuki Shiino (Gerrit)
Oct 30, 2025, 9:01:16 AM (3 days ago) Oct 30
to Igor Sheludko, Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Igor Sheludko
Yuki Shiino voted and added 2 comments![]( "Open in Gerrit")
Votes added by Yuki Shiino
| Code-Review | +1 |
2 comments
Patchset-level comments
Yuki Shiino . resolved
LGTM.
File third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
Line 2966, Patchset 7 (Latest):
// (V8 calls this callback only when that's the case).\Igor Sheludko . resolved
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Oct 30, 2025, 9:03:49 AM (3 days ago) Oct 30
to Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Igor Sheludko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 30, 2025, 9:20:23 AM (3 days ago) Oct 30
to Igor Sheludko, Yuki Shiino, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[v8] Prepare for deprecation of v8::PropertyCallbackInfo<T>::This()
Blink was using v8::PropertyCallbackInfo<T>::This() according to the
specification of [[Set]] operation for legacy platform object
(see https://webidl.spec.whatwg.org/#legacy-platform-object-set).
However, this semantics is guaranteed by V8's interceptors Api -
i.e. the setter callback is called only when the receiver is the
holder.
Bug: 455600234
Change-Id: I4a8e3a268135a2282bf70f0604c2a19cf652a7c8
Reviewed-by: Yuki Shiino <yukis...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1537875}
Files:
- M third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
Change size: S
Delta: 1 file changed, 18 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuki Shiino
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages