[html-in-canvas] Support offscreen canvas [chromium/src : main]

0 views
Skip to first unread message

AI Code Reviewer (Gerrit)

unread,
Mar 28, 2026, 6:49:14 PM (4 days ago) Mar 28
to Philip Rogers, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jmedle...@chromium.org

AI Code Reviewer added 1 comment

File third_party/blink/renderer/core/html/canvas/element_image.h
Line 24, Patchset 1 (Latest): const std::optional<CanvasChildPaintRecord>& GetPaintRecord() const {
AI Code Reviewer . unresolved

nit: Blink Style Guide: Naming - Precede setters with the word “Set”; use bare words for getters. Consider renaming this getter to `Record()` to match the member variable `record_`, or rename the variable to `paint_record_` and the getter to `PaintRecord()`.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I78037b55987045c209a158421130b939394653f0
Gerrit-Change-Number: 7708746
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Rogers <p...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Sat, 28 Mar 2026 22:49:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
Mar 28, 2026, 11:31:54 PM (4 days ago) Mar 28
to Philip Jägenstedt, Chromium LUCI CQ, AI Code Reviewer, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jmedle...@chromium.org

Philip Rogers voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I78037b55987045c209a158421130b939394653f0
Gerrit-Change-Number: 7708746
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Philip Jägenstedt <foo...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Sun, 29 Mar 2026 03:31:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
Mar 30, 2026, 1:09:43 PM (3 days ago) Mar 30
to Hiroki Nakagawa, AyeAye, Philip Jägenstedt, Chromium LUCI CQ, AI Code Reviewer, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, kenjibah...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, shimazu+se...@chromium.org, kinuko+ser...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jmedle...@chromium.org

Philip Rogers added 1 comment

File third_party/blink/renderer/core/html/canvas/element_image.h
Line 24, Patchset 1: const std::optional<CanvasChildPaintRecord>& GetPaintRecord() const {
AI Code Reviewer . resolved

nit: Blink Style Guide: Naming - Precede setters with the word “Set”; use bare words for getters. Consider renaming this getter to `Record()` to match the member variable `record_`, or rename the variable to `paint_record_` and the getter to `PaintRecord()`.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Philip Rogers

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I78037b55987045c209a158421130b939394653f0
    Gerrit-Change-Number: 7708746
    Gerrit-PatchSet: 3
    Gerrit-Owner: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Philip Jägenstedt <foo...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Comment-Date: Mon, 30 Mar 2026 17:09:33 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Philip Rogers (Gerrit)

    unread,
    Mar 30, 2026, 8:36:27 PM (2 days ago) Mar 30
    to Stefan Zager, Stephen Chenney, Dirk Schulze, Hiroki Nakagawa, AyeAye, Philip Jägenstedt, Chromium LUCI CQ, AI Code Reviewer, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, kenjibah...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, shimazu+se...@chromium.org, kinuko+ser...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jmedle...@chromium.org

    Philip Rogers voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I78037b55987045c209a158421130b939394653f0
    Gerrit-Change-Number: 7708746
    Gerrit-PatchSet: 8
    Gerrit-Owner: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Philip Jägenstedt <foo...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stefan Zager <sza...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Comment-Date: Tue, 31 Mar 2026 00:36:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages