[bindings] Add includes of runtime_enabled_features.h when needed [chromium/src : main]

0 views
Skip to first unread message

David Sanders (Gerrit)

unread,
Nov 21, 2025, 3:16:25 AM (yesterday) Nov 21
to Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org, sloboda...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from David Sanders

Message from David Sanders

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id8d451334df24da61a286c303a76d9dee98b81de
Gerrit-Change-Number: 7181554
Gerrit-PatchSet: 11
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Fri, 21 Nov 2025 08:16:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrey Kosyakov (Gerrit)

unread,
Nov 21, 2025, 12:30:44 PM (yesterday) Nov 21
to David Sanders, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org, sloboda...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from David Sanders

Andrey Kosyakov voted and added 1 comment

Votes added by Andrey Kosyakov

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Andrey Kosyakov . resolved

Thanks, lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id8d451334df24da61a286c303a76d9dee98b81de
Gerrit-Change-Number: 7181554
Gerrit-PatchSet: 11
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Fri, 21 Nov 2025 17:30:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

David Sanders (Gerrit)

unread,
Nov 21, 2025, 2:01:27 PM (yesterday) Nov 21
to Andrey Kosyakov, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org, sloboda...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

David Sanders voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id8d451334df24da61a286c303a76d9dee98b81de
Gerrit-Change-Number: 7181554
Gerrit-PatchSet: 11
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Fri, 21 Nov 2025 19:01:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 21, 2025, 2:21:54 PM (yesterday) Nov 21
to David Sanders, Andrey Kosyakov, Raphael Kubo da Costa, Kentaro Hara, AyeAye, feature-me...@chromium.org, sloboda...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[bindings] Add includes of runtime_enabled_features.h when needed

Ensures that an include of runtime_enabled_features.h is added to
generated bindings when needed, instead of the current behavior
which is unintentionally relying on transitive includes.
Change-Id: Id8d451334df24da61a286c303a76d9dee98b81de
Commit-Queue: David Sanders <dsand...@ucsbalum.com>
Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1548634}
Files:
  • M third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
Change size: S
Delta: 1 file changed, 15 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Andrey Kosyakov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id8d451334df24da61a286c303a76d9dee98b81de
Gerrit-Change-Number: 7181554
Gerrit-PatchSet: 12
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages