[identifiability] Remove HighEntropy idl extended attribute [chromium/src : main]

0 views
Skip to first unread message

Antonio Sartori (Gerrit)

unread,
Nov 21, 2025, 10:54:28 AM (yesterday) Nov 21
to Mike Taylor, Mike West, AyeAye, Chromium LUCI CQ, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Kentaro Hara, Hongchan Choi, Kaan Icer, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Luna Lu, Peter Beverloo, Stephen Chenney, srirama chandra sekhar, Xida Chen, antoniosartori+wa...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, cwalle...@chromium.org, derinel+wat...@google.com, dtapuska+...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kouhe...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, rayanka...@chromium.org, sloboda...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Mike Taylor and Mike West

Antonio Sartori added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Antonio Sartori . resolved

+MikeT for //third_party/blink/renderer/extensions
+MikeW for everything else

Open in Gerrit

Related details

Attention is currently required from:
  • Mike Taylor
  • Mike West
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I23a1f4a07674af9ad7798141f47d40bcbc51aece
Gerrit-Change-Number: 7184259
Gerrit-PatchSet: 4
Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Attention: Mike Taylor <mike...@chromium.org>
Gerrit-Comment-Date: Fri, 21 Nov 2025 15:54:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mike West (Gerrit)

unread,
Nov 21, 2025, 11:09:10 AM (yesterday) Nov 21
to Antonio Sartori, Mike Taylor, AyeAye, Chromium LUCI CQ, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Kentaro Hara, Hongchan Choi, Kaan Icer, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Luna Lu, Peter Beverloo, Stephen Chenney, srirama chandra sekhar, Xida Chen, antoniosartori+wa...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, cwalle...@chromium.org, derinel+wat...@google.com, dtapuska+...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kouhe...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, rayanka...@chromium.org, sloboda...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Antonio Sartori and Mike Taylor

Mike West voted and added 1 comment

Votes added by Mike West

Code-Review+1

1 comment

Patchset-level comments
Antonio Sartori . resolved

+MikeT for //third_party/blink/renderer/extensions
+MikeW for everything else

Mike West

Sure is nice that we've solved all the problems we introduced this attribute to track so that we don't have to keep it around anymore!

+MikeT for //third_party/blink/renderer/extensions

Now I wanna be an API owner again. :(

+MikeW for everything else

If you wait another month, we could land this to celebrate the 7th anniversary of https://chromium-review.googlesource.com/c/chromium/src/+/1367657!

Open in Gerrit

Related details

Attention is currently required from:
  • Antonio Sartori
  • Mike Taylor
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Mike Taylor <mike...@chromium.org>
    Gerrit-Attention: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Comment-Date: Fri, 21 Nov 2025 16:08:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Antonio Sartori <antonio...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mike Taylor (Gerrit)

    unread,
    Nov 21, 2025, 11:09:52 AM (yesterday) Nov 21
    to Antonio Sartori, Mike West, AyeAye, Chromium LUCI CQ, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Kentaro Hara, Hongchan Choi, Kaan Icer, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Luna Lu, Peter Beverloo, Stephen Chenney, srirama chandra sekhar, Xida Chen, antoniosartori+wa...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, cwalle...@chromium.org, derinel+wat...@google.com, dtapuska+...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kouhe...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, rayanka...@chromium.org, sloboda...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, webauthn...@chromium.org, yigu+...@chromium.org
    Attention needed from Antonio Sartori

    Mike Taylor voted and added 1 comment

    Votes added by Mike Taylor

    Code-Review+1

    1 comment

    Patchset-level comments
    Mike Taylor . resolved

    😎 lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Antonio Sartori
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    Gerrit-Attention: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Comment-Date: Fri, 21 Nov 2025 16:09:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Antonio Sartori (Gerrit)

    unread,
    Nov 21, 2025, 11:23:28 AM (yesterday) Nov 21
    to Mike Taylor, Mike West, AyeAye, Chromium LUCI CQ, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Kentaro Hara, Hongchan Choi, Kaan Icer, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Luna Lu, Peter Beverloo, Stephen Chenney, srirama chandra sekhar, Xida Chen, antoniosartori+wa...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, cwalle...@chromium.org, derinel+wat...@google.com, dtapuska+...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kouhe...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, rayanka...@chromium.org, sloboda...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, webauthn...@chromium.org, yigu+...@chromium.org

    Antonio Sartori added 1 comment

    Patchset-level comments
    Antonio Sartori . resolved

    +MikeT for //third_party/blink/renderer/extensions
    +MikeW for everything else

    Mike West

    Sure is nice that we've solved all the problems we introduced this attribute to track so that we don't have to keep it around anymore!

    +MikeT for //third_party/blink/renderer/extensions

    Now I wanna be an API owner again. :(

    +MikeW for everything else

    If you wait another month, we could land this to celebrate the 7th anniversary of https://chromium-review.googlesource.com/c/chromium/src/+/1367657!

    Antonio Sartori

    I think I'll land it now and celebrate it while on vacation :)

    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Fri, 21 Nov 2025 16:23:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mike West <mk...@chromium.org>
    Comment-In-Reply-To: Antonio Sartori <antonio...@chromium.org>
    satisfied_requirement
    open
    diffy

    Antonio Sartori (Gerrit)

    unread,
    Nov 21, 2025, 11:24:05 AM (yesterday) Nov 21
    to Mike Taylor, Mike West, AyeAye, Chromium LUCI CQ, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Kentaro Hara, Hongchan Choi, Kaan Icer, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Luna Lu, Peter Beverloo, Stephen Chenney, srirama chandra sekhar, Xida Chen, antoniosartori+wa...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, cwalle...@chromium.org, derinel+wat...@google.com, dtapuska+...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kouhe...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, rayanka...@chromium.org, sloboda...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, webauthn...@chromium.org, yigu+...@chromium.org

    Antonio Sartori voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Fri, 21 Nov 2025 16:23:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Nov 21, 2025, 11:27:23 AM (yesterday) Nov 21
    to Antonio Sartori, Mike Taylor, Mike West, AyeAye, David Bokan, Christian Biesinger, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Kentaro Hara, Hongchan Choi, Kaan Icer, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Luna Lu, Peter Beverloo, Stephen Chenney, srirama chandra sekhar, Xida Chen, antoniosartori+wa...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, cwalle...@chromium.org, derinel+wat...@google.com, dtapuska+...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, iclella...@chromium.org, jkarli...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org, kouhe...@chromium.org, mattreyno...@chromium.org, mcasas+med...@chromium.org, nator...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, pdr+svgw...@chromium.org, pkotwic...@chromium.org, rayanka...@chromium.org, sloboda...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com, webauthn...@chromium.org, yigu+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [identifiability] Remove HighEntropy idl extended attribute

    This CL removes support for the HighEntropy extended attribute in IDL
    files and cleans up all such attributes from all IDL files. The
    attribute was used for the Identifiability Study and for tracing high
    entropy API calls via perfetto, but that is no longer needed.
    Bug: 451513879
    Change-Id: I23a1f4a07674af9ad7798141f47d40bcbc51aece
    Commit-Queue: Antonio Sartori <antonio...@chromium.org>
    Reviewed-by: Mike Taylor <mike...@chromium.org>
    Reviewed-by: Mike West <mk...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1548511}
    Files:
    • M chrome/browser/privacy_budget/privacy_budget_browsertest.cc
    • M third_party/blink/renderer/bindings/IDLExtendedAttributes.md
    • M third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
    • M third_party/blink/renderer/bindings/scripts/validator/rules/supported_extended_attributes.py
    • M third_party/blink/renderer/core/events/mouse_event.idl
    • M third_party/blink/renderer/core/events/navigator_events.idl
    • M third_party/blink/renderer/core/events/wheel_event.idl
    • M third_party/blink/renderer/core/frame/history.idl
    • M third_party/blink/renderer/core/frame/navigator.idl
    • M third_party/blink/renderer/core/frame/navigator_automation_information.idl
    • M third_party/blink/renderer/core/frame/navigator_concurrent_hardware.idl
    • M third_party/blink/renderer/core/frame/navigator_cookies.idl
    • M third_party/blink/renderer/core/frame/navigator_cpu_performance.idl
    • M third_party/blink/renderer/core/frame/navigator_id.idl
    • M third_party/blink/renderer/core/frame/navigator_language.idl
    • M third_party/blink/renderer/core/frame/screen.idl
    • M third_party/blink/renderer/core/frame/visual_viewport.idl
    • M third_party/blink/renderer/core/frame/window.idl
    • M third_party/blink/renderer/core/html/canvas/html_canvas_element.idl
    • M third_party/blink/renderer/core/html/media/html_video_element.idl
    • M third_party/blink/renderer/core/input/input_device_capabilities.idl
    • M third_party/blink/renderer/core/input/touch.idl
    • M third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.idl
    • M third_party/blink/renderer/core/permissions_policy/feature_policy.idl
    • M third_party/blink/renderer/core/svg/svg_geometry_element.idl
    • M third_party/blink/renderer/core/svg/svg_tests.idl
    • M third_party/blink/renderer/core/svg/svg_text_content_element.idl
    • M third_party/blink/renderer/extensions/webview/media_integrity/media_integrity_token_provider.idl
    • M third_party/blink/renderer/extensions/webview/web_view.idl
    • M third_party/blink/renderer/modules/app_banner/before_install_prompt_event.idl
    • M third_party/blink/renderer/modules/background_fetch/background_fetch_registration.idl
    • M third_party/blink/renderer/modules/battery/battery_manager.idl
    • M third_party/blink/renderer/modules/bluetooth/bluetooth_advertising_event.idl
    • M third_party/blink/renderer/modules/bluetooth/bluetooth_device.idl
    • M third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.idl
    • M third_party/blink/renderer/modules/canvas/canvas2d/canvas_2d_recorder_context.idl
    • M third_party/blink/renderer/modules/canvas/canvas2d/canvas_path.idl
    • M third_party/blink/renderer/modules/canvas/htmlcanvas/html_canvas_element_module.idl
    • M third_party/blink/renderer/modules/credentialmanagement/authenticator_attestation_response.idl
    • M third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope.idl
    • M third_party/blink/renderer/modules/donottrack/navigator_do_not_track.idl
    • M third_party/blink/renderer/modules/gamepad/gamepad.idl
    • M third_party/blink/renderer/modules/keyboard/keyboard.idl
    • M third_party/blink/renderer/modules/media_capabilities/media_capabilities.idl
    • M third_party/blink/renderer/modules/mediacapturefromelement/html_canvas_element_capture.idl
    • M third_party/blink/renderer/modules/mediarecorder/media_recorder.idl
    • M third_party/blink/renderer/modules/mediastream/media_devices.idl
    • M third_party/blink/renderer/modules/mediastream/navigator_media_stream.idl
    • M third_party/blink/renderer/modules/netinfo/network_information.idl
    • M third_party/blink/renderer/modules/payments/payment_request.idl
    • M third_party/blink/renderer/modules/peerconnection/rtc_ice_candidate.idl
    • M third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.idl
    • M third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.idl
    • M third_party/blink/renderer/modules/plugins/plugin.idl
    • M third_party/blink/renderer/modules/push_messaging/push_manager.idl
    • M third_party/blink/renderer/modules/screen_details/screen_detailed.idl
    • M third_party/blink/renderer/modules/screen_details/screen_details.idl
    • M third_party/blink/renderer/modules/webaudio/analyser_node.idl
    • M third_party/blink/renderer/modules/webaudio/audio_buffer.idl
    • M third_party/blink/renderer/modules/webaudio/audio_context.idl
    • M third_party/blink/renderer/modules/webaudio/audio_node.idl
    • M third_party/blink/renderer/modules/webaudio/base_audio_context.idl
    • M third_party/blink/renderer/modules/webaudio/offline_audio_context.idl
    • M third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.idl
    • M third_party/blink/renderer/modules/webgl/webgl_compressed_texture_astc.idl
    • M third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.idl
    • M third_party/blink/renderer/modules/webgpu/gpu_adapter_info.idl
    Change size: L
    Delta: 67 files changed, 196 insertions(+), 352 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mike West, +1 by Mike Taylor
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I23a1f4a07674af9ad7798141f47d40bcbc51aece
    Gerrit-Change-Number: 7184259
    Gerrit-PatchSet: 5
    Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages