Move Internals.dumpContentNode{,Tree} to a partial interface [chromium/src : main]

0 views
Skip to first unread message

Fredrik Söderquist (Gerrit)

unread,
Nov 12, 2025, 9:07:31 AM (10 days ago) Nov 12
to Khushal Sagar, Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, aleventh...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Khushal Sagar and Philip Rogers

Fredrik Söderquist voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Khushal Sagar
  • Philip Rogers
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifc0434a832c0bf11af58eef0ab139f2c0a83181d
Gerrit-Change-Number: 7147098
Gerrit-PatchSet: 2
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Khushal Sagar <khusha...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Nov 2025 14:07:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
Nov 12, 2025, 7:21:46 PM (10 days ago) Nov 12
to Fredrik Söderquist, Khushal Sagar, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, aleventh...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Fredrik Söderquist and Khushal Sagar

Philip Rogers voted and added 1 comment

Votes added by Philip Rogers

Code-Review+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Philip Rogers . unresolved

LGTM here but please wait for Khushal to review.

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Khushal Sagar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifc0434a832c0bf11af58eef0ab139f2c0a83181d
Gerrit-Change-Number: 7147098
Gerrit-PatchSet: 2
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Khushal Sagar <khusha...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Thu, 13 Nov 2025 00:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Aaron Leventhal (Gerrit)

unread,
Nov 13, 2025, 2:42:05 PM (9 days ago) Nov 13
to Fredrik Söderquist, Philip Rogers, Khushal Sagar, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, aleventh...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Fredrik Söderquist and Khushal Sagar

Aaron Leventhal voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
  • Khushal Sagar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifc0434a832c0bf11af58eef0ab139f2c0a83181d
Gerrit-Change-Number: 7147098
Gerrit-PatchSet: 2
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Khushal Sagar <khusha...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Thu, 13 Nov 2025 19:41:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Khushal Sagar (Gerrit)

unread,
Nov 13, 2025, 9:18:25 PM (9 days ago) Nov 13
to Fredrik Söderquist, Aaron Leventhal, Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, aleventh...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Fredrik Söderquist

Khushal Sagar voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifc0434a832c0bf11af58eef0ab139f2c0a83181d
Gerrit-Change-Number: 7147098
Gerrit-PatchSet: 2
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Fri, 14 Nov 2025 02:17:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Nov 14, 2025, 7:49:55 AM (8 days ago) Nov 14
to Khushal Sagar, Aaron Leventhal, Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, aleventh...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Khushal Sagar

Fredrik Söderquist voted and added 1 comment

Votes added by Fredrik Söderquist

Auto-Submit+0

1 comment

Patchset-level comments
Philip Rogers . resolved

LGTM here but please wait for Khushal to review.

Fredrik Söderquist

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Khushal Sagar
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifc0434a832c0bf11af58eef0ab139f2c0a83181d
    Gerrit-Change-Number: 7147098
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Khushal Sagar <khusha...@chromium.org>
    Gerrit-Comment-Date: Fri, 14 Nov 2025 12:49:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Philip Rogers <p...@chromium.org>
    satisfied_requirement
    open
    diffy

    Fredrik Söderquist (Gerrit)

    unread,
    Nov 14, 2025, 7:50:02 AM (8 days ago) Nov 14
    to Khushal Sagar, Aaron Leventhal, Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, aleventh...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Khushal Sagar

    Fredrik Söderquist voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Fri, 14 Nov 2025 12:49:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Nov 14, 2025, 8:45:08 AM (8 days ago) Nov 14
    to Fredrik Söderquist, Khushal Sagar, Aaron Leventhal, Philip Rogers, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, aleventh...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Move Internals.dumpContentNode{,Tree} to a partial interface

    Rather than having a faux public interface to work around layering,
    implement the functions as part of the content_extraction module.

    Change to throw an exception for the "No AIPageContentAgent" case rather
    than returning a string.
    Bug: 419149271
    Change-Id: Ifc0434a832c0bf11af58eef0ab139f2c0a83181d
    Reviewed-by: Aaron Leventhal <aleve...@google.com>
    Reviewed-by: Philip Rogers <p...@chromium.org>
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Reviewed-by: Khushal Sagar <khusha...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1544906}
    Files:
    • M third_party/blink/public/BUILD.gn
    • D third_party/blink/public/web/web_content_extraction.h
    • M third_party/blink/renderer/bindings/idl_in_modules.gni
    • M third_party/blink/renderer/core/testing/internals.cc
    • M third_party/blink/renderer/core/testing/internals.h
    • M third_party/blink/renderer/core/testing/internals.idl
    • M third_party/blink/renderer/modules/BUILD.gn
    • A third_party/blink/renderer/modules/content_extraction/testing/internals_content_extraction.cc
    • A third_party/blink/renderer/modules/content_extraction/testing/internals_content_extraction.h
    • A third_party/blink/renderer/modules/content_extraction/testing/internals_content_extraction.idl
    • M third_party/blink/renderer/modules/exported/BUILD.gn
    • D third_party/blink/renderer/modules/exported/web_content_extraction.cc
    Change size: M
    Delta: 12 files changed, 111 insertions(+), 130 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Aaron Leventhal, +1 by Philip Rogers, +1 by Khushal Sagar
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifc0434a832c0bf11af58eef0ab139f2c0a83181d
    Gerrit-Change-Number: 7147098
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Khushal Sagar <khusha...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages