[webauthn] Renderer implementation for CMTGK [chromium/src : main]

0 views
Skip to first unread message

Nina Satragno (Gerrit)

unread,
May 15, 2026, 11:25:05 AM (4 days ago) May 15
to Ken Buchanan, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Ken Buchanan

Nina Satragno voted and added 1 comment

Votes added by Nina Satragno

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Nina Satragno . resolved

Ken, please take a look. Thank you! ^_^

Open in Gerrit

Related details

Attention is currently required from:
  • Ken Buchanan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3a75a7d7d598ec8078d5424e292ec724eaf497b9
Gerrit-Change-Number: 7841424
Gerrit-PatchSet: 4
Gerrit-Owner: Nina Satragno <nsat...@chromium.org>
Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
Gerrit-Reviewer: Nina Satragno <nsat...@chromium.org>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
Gerrit-Comment-Date: Fri, 15 May 2026 15:24:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ken Buchanan (Gerrit)

unread,
May 15, 2026, 3:40:11 PM (4 days ago) May 15
to Nina Satragno, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Nina Satragno

Ken Buchanan voted and added 2 comments

Votes added by Ken Buchanan

Code-Review+1

2 comments

Patchset-level comments
Ken Buchanan . resolved

lgtm

File third_party/blink/renderer/modules/credentialmanagement/credential_manager_type_converters.cc
Line 333, Patchset 4 (Latest): Convert(const blink::mojom::blink::CmtgKeyResponsePtr& cmtg_key) {
Ken Buchanan . unresolved

There is an `std::move()` on this argument when the function is called, and below moves on its fields to avoid copies. Since this is a reference, the key and signature moves are likely turned into copies though. Maybe change this to a by-value call?

The other converters have the same problem, it looks like, although their callers mostly don't do moves.

Open in Gerrit

Related details

Attention is currently required from:
  • Nina Satragno
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3a75a7d7d598ec8078d5424e292ec724eaf497b9
    Gerrit-Change-Number: 7841424
    Gerrit-PatchSet: 4
    Gerrit-Owner: Nina Satragno <nsat...@chromium.org>
    Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
    Gerrit-Reviewer: Nina Satragno <nsat...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Nina Satragno <nsat...@chromium.org>
    Gerrit-Comment-Date: Fri, 15 May 2026 19:40:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nina Satragno (Gerrit)

    unread,
    May 15, 2026, 4:18:35 PM (4 days ago) May 15
    to Jeremy Roman, Ken Buchanan, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
    Attention needed from Jeremy Roman

    Nina Satragno voted and added 2 comments

    Votes added by Nina Satragno

    Auto-Submit+1
    Commit-Queue+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Nina Satragno . resolved

    Jeremy, please take a look at third_party/blink/renderer/platform/runtime_enabled_features.json5.

    Thank you! ^_^

    File third_party/blink/renderer/modules/credentialmanagement/credential_manager_type_converters.cc
    Line 333, Patchset 4: Convert(const blink::mojom::blink::CmtgKeyResponsePtr& cmtg_key) {
    Ken Buchanan . resolved

    There is an `std::move()` on this argument when the function is called, and below moves on its fields to avoid copies. Since this is a reference, the key and signature moves are likely turned into copies though. Maybe change this to a by-value call?

    The other converters have the same problem, it looks like, although their callers mostly don't do moves.

    Nina Satragno

    It seems this can't be passed by value or the type converter machinery complains, so I removed the `std::move`s instead.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jeremy Roman
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3a75a7d7d598ec8078d5424e292ec724eaf497b9
      Gerrit-Change-Number: 7841424
      Gerrit-PatchSet: 5
      Gerrit-Owner: Nina Satragno <nsat...@chromium.org>
      Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
      Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
      Gerrit-Reviewer: Nina Satragno <nsat...@chromium.org>
      Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
      Gerrit-Comment-Date: Fri, 15 May 2026 20:18:26 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Ken Buchanan <ke...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages