Plumb MlModelManager to AudioProcessorHandler to enable passing the residual echo estimator model to webrtc. [chromium/src : main]

0 views

Skip to first unread message

AI Code Reviewer (Gerrit)

unread,

Oct 24, 2025, 7:51:39 AM (9 days ago) Oct 24

to Jesús de Vicente Peña, Christian Biesinger, Enterprise Policy Reviews, Kentaro Hara, Sean Maher, Stephen Chenney, Raphael Kubo da Costa, Alexis Menard, Thiabaud Engelbrecht, Dirk Schulze, Kaan Icer, Chromium Metrics Reviews, AyeAye, Ale Bzk, chromium...@chromium.org, Per Åhgren, Sam Zackrisson, chromeos-gfx-...@google.com, vasilii+watchlis...@chromium.org, storage...@chromium.org, browser-comp...@chromium.org, gcasto+w...@chromium.org, fserb...@chromium.org, yigu+...@chromium.org, drott+bl...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, wfh+...@chromium.org, msrame...@chromium.org, telemetr...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, tmartino+tran...@chromium.org, rkgibso...@chromium.org, net-r...@chromium.org, csharris...@chromium.org, chromiumme...@microsoft.com, permissio...@chromium.org, odejesu...@chromium.org, edgesto...@microsoft.com, cros-report...@google.com, grt+...@chromium.org, asvitkine...@chromium.org, nickdiego+wa...@igalia.com, dmurph+watchi...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, npm+...@chromium.org, extension...@chromium.org, ios-revie...@chromium.org, asvitki...@chromium.org, speed-metrics...@chromium.org, mattreyno...@chromium.org, dullweb...@chromium.org, blink-revie...@chromium.org, media-cro...@chromium.org, devtools-re...@chromium.org, max+watc...@igalia.com, devtools...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org, fmalit...@chromium.org, chromium-a...@chromium.org, sky+...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, ios-r...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, tommyw+w...@chromium.org

AI Code Reviewer added 1 comment

File third_party/blink/renderer/core/css/style_rule.h

Line 226, Patchset 3 (Latest): const MixinParameterBindings* GetParentMixin() const { return parent_mixin_; }

AI Code Reviewer . unresolved

nit: Per the Blink Style Guide: Naming - 'use bare words for getters', these function names should be `Bindings()` and `ParentMixin()` respectively, as they are simple getters and their names do not conflict with type names.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jesús de Vicente Peña (Gerrit)

unread,

Oct 24, 2025, 9:00:42 AM (9 days ago) Oct 24

to AI Code Reviewer, Christian Biesinger, Enterprise Policy Reviews, Kentaro Hara, Sean Maher, Stephen Chenney, Raphael Kubo da Costa, Alexis Menard, Thiabaud Engelbrecht, Dirk Schulze, Kaan Icer, Chromium Metrics Reviews, AyeAye, Ale Bzk, chromium...@chromium.org, Per Åhgren, Sam Zackrisson, chromeos-gfx-...@google.com, vasilii+watchlis...@chromium.org, storage...@chromium.org, browser-comp...@chromium.org, gcasto+w...@chromium.org, fserb...@chromium.org, yigu+...@chromium.org, drott+bl...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org, roblia...@chromium.org, wfh+...@chromium.org, msrame...@chromium.org, telemetr...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, tmartino+tran...@chromium.org, rkgibso...@chromium.org, net-r...@chromium.org, csharris...@chromium.org, chromiumme...@microsoft.com, permissio...@chromium.org, odejesu...@chromium.org, edgesto...@microsoft.com, cros-report...@google.com, grt+...@chromium.org, asvitkine...@chromium.org, nickdiego+wa...@igalia.com, dmurph+watchi...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org, npm+...@chromium.org, extension...@chromium.org, ios-revie...@chromium.org, asvitki...@chromium.org, speed-metrics...@chromium.org, mattreyno...@chromium.org, dullweb...@chromium.org, blink-revie...@chromium.org, media-cro...@chromium.org, devtools-re...@chromium.org, max+watc...@igalia.com, devtools...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org, fmalit...@chromium.org, chromium-a...@chromium.org, sky+...@chromium.org, blink-re...@chromium.org, apavlo...@chromium.org, speed-metr...@chromium.org, blink-revie...@chromium.org, ios-r...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, marinacio...@chromium.org, olka+...@chromium.org, tommyw+w...@chromium.org

Jesús de Vicente Peña abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages