webauthn: Make PublicKeyCredential.toJSON() confirm to the spec again [chromium/src : main]

0 views

Skip to first unread message

Martin Kreichgauer (Gerrit)

unread,

Jun 20, 2024, 8:02:22 PM (9 days ago) Jun 20

to Martin Kreichgauer, Adam Langley, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org

Attention needed from Adam Langley

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Adam Langley

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Adam Langley (Gerrit)

unread,

Jun 20, 2024, 8:19:35 PM (9 days ago) Jun 20

to Martin Kreichgauer, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org

Attention needed from Martin Kreichgauer

Adam Langley voted and added 2 comments

Votes added by Adam Langley

Code-Review

2 comments

Commit Message

Line 7, Patchset 3 (Latest):webauthn: Make PublicKeyCredential.toJSON() confirm to the spec again

Adam Langley . unresolved

typo: "conform"

File third_party/blink/renderer/modules/credentialmanagement/public_key_credential.cc

Line 141, Patchset 3 (Latest): [this, script_state](auto* json, auto* response) {

Adam Langley . resolved

I don't know how C++ works any more.