Make ScriptState::isolate_ a const and CHECK() it's not null [chromium/src : main]
0 views
Skip to first unread message
Andrey Kosyakov (Gerrit)
Oct 28, 2025, 6:34:23 PM (5 days ago) Oct 28
to Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Nate Chapin
Andrey Kosyakov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Andrey Kosyakov . resolved
PTAL! Note I tried to use raw_ref<> right away (ps1), but it blew binary size checks.
Related details
Attention is currently required from:
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Chapin (Gerrit)
Oct 28, 2025, 6:41:48 PM (5 days ago) Oct 28
to Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Andrey Kosyakov
Nate Chapin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Oct 28, 2025, 6:41:59 PM (5 days ago) Oct 28
to Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Andrey Kosyakov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 28, 2025, 7:03:04 PM (5 days ago) Oct 28
to Andrey Kosyakov, Nate Chapin, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Make ScriptState::isolate_ a const and CHECK() it's not null
To avoid confusion wrt its nullability.
As a drive-by, avoid v8::Isolate::Current() and use the one in the
DOMWorld instead.
Change-Id: I2f073be81f55d7785b38a03f4791c0e550dd7763
Commit-Queue: Andrey Kosyakov <ca...@chromium.org>
Reviewed-by: Nate Chapin <jap...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536967}
Files:
- M third_party/blink/renderer/platform/bindings/script_state.cc
- M third_party/blink/renderer/platform/bindings/script_state.h
Change size: S
Delta: 2 files changed, 7 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Chapin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages