WebNN: Prototype range based dynamic shapes [chromium/src : main]

38 views
Skip to first unread message

Miao, Bin (Gerrit)

unread,
Jan 7, 2026, 1:37:43 AM (10 days ago) Jan 7
to Hu, Ningxin, Lin, Wanming, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Hu, Ningxin

Miao, Bin added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Miao, Bin . resolved

The latest PS updates IDL design from shape range to per-dimension ranges. Now we can create input by:
`const input = builder.input('input', {dataType: 'float32', shape: [1, {min:1, max:8, preferred:3}]});`

Next I'll update the mojom definition to match the new IDL design.

Open in Gerrit

Related details

Attention is currently required from:
  • Hu, Ningxin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2eee080c7e3563f07e92afc70080c13b58d32e7c
Gerrit-Change-Number: 7212610
Gerrit-PatchSet: 5
Gerrit-Owner: Miao, Bin <bin....@intel.com>
Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Lin, Wanming <wanmi...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
Gerrit-Comment-Date: Wed, 07 Jan 2026 06:37:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hu, Ningxin (Gerrit)

unread,
Jan 11, 2026, 10:33:26 PM (5 days ago) Jan 11
to Miao, Bin, Lin, Wanming, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org
Attention needed from Miao, Bin

Hu, Ningxin added 3 comments

Commit Message
Line 7, Patchset 6 (Latest):WebNN: Prototype range based dynamic shapes
Hu, Ningxin . unresolved

Mark this draft CL is [WIP]

File services/webnn/public/mojom/webnn_graph.mojom
Line 40, Patchset 6 (Latest): array<uint32> shape;
Hu, Ningxin . unresolved

Align the shape definition with WebIDL and support static or range dimension.

File third_party/blink/renderer/modules/ml/webnn/ml_operand_descriptor.idl
Line 34, Patchset 6 (Latest):dictionary MLInputOperandDescriptor {
Hu, Ningxin . unresolved

The operator descriptor supporting range dimension should also be used by `MLOperand`. Having "Input" in its name may confuse. One alternative way is to let the default `MLOperandDescritptor` support range dimension, and rename the previous one to `MLStaticOperandDescriptor` which could be used by Constant and MLTensor.

Open in Gerrit

Related details

Attention is currently required from:
  • Miao, Bin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2eee080c7e3563f07e92afc70080c13b58d32e7c
    Gerrit-Change-Number: 7212610
    Gerrit-PatchSet: 6
    Gerrit-Owner: Miao, Bin <bin....@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Lin, Wanming <wanmi...@intel.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Miao, Bin <bin....@intel.com>
    Gerrit-Comment-Date: Mon, 12 Jan 2026 03:33:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages