Introduce custom phrase. [chromium/src : main]

76 views
Skip to first unread message

Evan Liu (Gerrit)

unread,
Jan 9, 2026, 3:53:36 PM (7 days ago) Jan 9
to Ziran Sun, Kent Tamura, Manuel Rego, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, peter+watch...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Kent Tamura, Manuel Rego and Ziran Sun

Evan Liu added 6 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Evan Liu . resolved

Code-wise, this seems fine to me. Whether or not this is something that should be added is something I'll defer to the Blink owners.

File third_party/blink/renderer/modules/custom_phrase/BUILD.gn
Line 1, Patchset 2 (Latest):# Copyright 2025 The Chromium Authors
Evan Liu . unresolved

2026

File third_party/blink/renderer/modules/custom_phrase/custom_phrase.h
Line 1, Patchset 2 (Latest):// Copyright 2024 The Chromium Authors
Evan Liu . unresolved

2026

File third_party/blink/renderer/modules/custom_phrase/custom_phrase.cc
Line 1, Patchset 2 (Latest):// Copyright 2024 The Chromium Authors
Evan Liu . unresolved

2026

Line 14, Patchset 2 (Latest): "Speech recognition phrase boost value "
Evan Liu . unresolved

I guess this is no longer just for speech recognition?

File third_party/blink/renderer/modules/custom_phrase/custom_phrase.idl
Line 1, Patchset 2 (Latest):// Copyright 2024 The Chromium Authors
Evan Liu . unresolved

2026

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
  • Manuel Rego
  • Ziran Sun
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2e5e628dafda27ec09185e2f120e28321e1ebdd1
Gerrit-Change-Number: 7277249
Gerrit-PatchSet: 2
Gerrit-Owner: Ziran Sun <zs...@igalia.com>
Gerrit-Reviewer: Evan Liu <ev...@google.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Manuel Rego <re...@igalia.com>
Gerrit-Reviewer: Ziran Sun <zs...@igalia.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Manuel Rego <re...@igalia.com>
Gerrit-Attention: Ziran Sun <zs...@igalia.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 20:53:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Jan 12, 2026, 6:02:02 PM (4 days ago) Jan 12
to Ziran Sun, Evan Liu, Kent Tamura, Manuel Rego, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, peter+watch...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Manuel Rego and Ziran Sun

Kent Tamura added 1 comment

Commit Message
Line 14, Patchset 2 (Latest):There should be no behaviour change with this CL.
Kent Tamura . unresolved

This CL exposes `window.CustomPhrase`, so this needs an intent-to-ship.
If this feature is under development, please add a runtime flag and guard the new interface.

Open in Gerrit

Related details

Attention is currently required from:
  • Manuel Rego
  • Ziran Sun
Gerrit-Comment-Date: Mon, 12 Jan 2026 23:01:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages