blink: Add APIs to test WebMCP [chromium/src : main]
AI Code Reviewer (Gerrit)
AI Code Reviewer added 1 comment![]( "Open in Gerrit")
void set_tools_changed_callback(std::optional<base::RepeatingClosure> cb) {Function names should use `CamelCase()` starting with an uppercase letter. As this is a setter, it should be named `SetToolsChangedCallback`. (Blink Style Guide: Naming - Use 'CamelCase' for all function names; Precede setters with the word “Set”)
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason
This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Related details
- David Bokan
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Khushal Sagar (Gerrit)
Khushal Sagar voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
- David Bokan
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Bokan (Gerrit)
David Bokan voted and added 4 comments![]( "Open in Gerrit")
Votes added by David Bokan
| Code-Review | +1 |
4 comments
Add hooks that can be used to test WebMCP tools. The APIs list andmaybe mention that it's for live/extension testing since a reader would normally expect it's for e.g. web/WPT tests in which case the question would be why not user something like internals?
void set_tools_changed_callback(std::optional<base::RepeatingClosure> cb) {Function names should use `CamelCase()` starting with an uppercase letter. As this is a setter, it should be named `SetToolsChangedCallback`. (Blink Style Guide: Naming - Use 'CamelCase' for all function names; Precede setters with the word “Set”)
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reasonThis comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
+1 I think this is a difference between Blink and Chromium
testRunner.dumpAsText();Eh, maybe not worth rewriting but any reason not to use testharness.js? I thought test runner is effectively deprecated?
Related details
- Khushal Sagar
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Khushal Sagar (Gerrit)
Khushal Sagar voted and added 3 comments![]( "Open in Gerrit")
Votes added by Khushal Sagar
| Auto-Submit | +1 |
| Commit-Queue | +2 |
3 comments
Add hooks that can be used to test WebMCP tools. The APIs list andmaybe mention that it's for live/extension testing since a reader would normally expect it's for e.g. web/WPT tests in which case the question would be why not user something like internals?
Done
void set_tools_changed_callback(std::optional<base::RepeatingClosure> cb) {David BokanFunction names should use `CamelCase()` starting with an uppercase letter. As this is a setter, it should be named `SetToolsChangedCallback`. (Blink Style Guide: Naming - Use 'CamelCase' for all function names; Precede setters with the word “Set”)
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reasonThis comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
+1 I think this is a difference between Blink and Chromium
Done
Eh, maybe not worth rewriting but any reason not to use testharness.js? I thought test runner is effectively deprecated?
I copied from an existing test. :)
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Bokan (Gerrit)
David Bokan voted![]( "Open in Gerrit")
- Khushal Sagar
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
blink: Add APIs to test WebMCP
Add hooks that can be used to test WebMCP tools. The APIs list and
execute registered tools and also register a callback to invoke when the
set of tools changes.
This allows testing tools from an extension by injecting script.
- M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
- M third_party/blink/renderer/bindings/generated_in_core.gni
- M third_party/blink/renderer/bindings/idl_in_core.gni
- M third_party/blink/renderer/core/script_tools/build.gni
- M third_party/blink/renderer/core/script_tools/model_context.cc
- M third_party/blink/renderer/core/script_tools/model_context.h
- M third_party/blink/renderer/core/script_tools/model_context_supplement.cc
- M third_party/blink/renderer/core/script_tools/model_context_supplement.h
- M third_party/blink/renderer/core/script_tools/model_context_supplement.idl
- A third_party/blink/renderer/core/script_tools/model_context_testing.cc
- A third_party/blink/renderer/core/script_tools/model_context_testing.h
- A third_party/blink/renderer/core/script_tools/model_context_testing.idl
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- A third_party/blink/web_tests/fast/webmcp/execute_tool-expected.txt
- A third_party/blink/web_tests/fast/webmcp/execute_tool.html
- A third_party/blink/web_tests/fast/webmcp/list_tools-expected.txt
- A third_party/blink/web_tests/fast/webmcp/list_tools.html
- A third_party/blink/web_tests/fast/webmcp/tools_changed-expected.txt
- A third_party/blink/web_tests/fast/webmcp/tools_changed.html
- M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
Code-Review: +1 by David Bokan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |