Domenic Denicola (Gerrit)

unread,

Jun 21, 2024, 5:04:50 AM (8 days ago) Jun 21

to Mingyu Lei, Fergal Daly, Kentaro Hara, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Attention needed from Fergal Daly, Kentaro Hara and Mingyu Lei

Domenic Denicola voted and added 2 comments

Votes added by Domenic Denicola

Code-Review

-1

2 comments

File third_party/blink/renderer/modules/ai/ai.idl

Line 59, Patchset 3 (Latest): Promise<AITextSessionOptions> defaultGenericSessionOptions();

Domenic Denicola . unresolved

Add `ontextmodeldownloadprogress` event handler

File third_party/blink/renderer/modules/ai/text_model_download_progress_event.idl

Line 10, Patchset 3 (Latest):interface TextModelDownloadProgressEvent : Event {

Domenic Denicola . unresolved

Use the normal `ProgressEvent`, don't invent a new one.

Open in Gerrit

Related details

Attention is currently required from:

Fergal Daly
Kentaro Hara
Mingyu Lei

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Kentaro Hara (Gerrit)

unread,

Jun 21, 2024, 5:07:37 AM (8 days ago) Jun 21

to Mingyu Lei, Domenic Denicola, Fergal Daly, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Attention needed from Fergal Daly and Mingyu Lei

Kentaro Hara added 2 comments

File third_party/blink/renderer/modules/ai/text_model_download_progress_event.idl

Line 11, Patchset 3 (Latest): attribute long long loaded;

Kentaro Hara . unresolved

nit: should this be "unsigned long long"?

Line 12, Patchset 3 (Latest): attribute long long total;

Kentaro Hara . unresolved

ditto.

Open in Gerrit

Related details

Attention is currently required from:

Fergal Daly
Mingyu Lei

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Kentaro Hara (Gerrit)

unread,

Jun 21, 2024, 5:07:54 AM (8 days ago) Jun 21

to Mingyu Lei, Domenic Denicola, Fergal Daly, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Attention needed from Fergal Daly and Mingyu Lei

Kentaro Hara added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Kentaro Hara . resolved

Where are you planning to add tests?

Open in Gerrit

Related details

Attention is currently required from:

Fergal Daly
Mingyu Lei

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

unsatisfied_requirement

open

diffy

Mingyu Lei (Gerrit)

unread,

Jun 24, 2024, 6:10:10 AM (5 days ago) Jun 24

to Domenic Denicola, Fergal Daly, Kentaro Hara, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Attention needed from Domenic Denicola, Fergal Daly and Kentaro Hara

Mingyu Lei added 5 comments

Patchset-level comments

File-level comment, Patchset 3:

Kentaro Hara . resolved

Where are you planning to add tests?

Mingyu Lei

In the next CL, I'll add a mock implementation of the download progress update event from EchoAIManagerImpl, and test it with WPT.

File third_party/blink/renderer/modules/ai/ai.idl

Line 59, Patchset 3: Promise<AITextSessionOptions> defaultGenericSessionOptions();

Domenic Denicola . resolved

Add `ontextmodeldownloadprogress` event handler

Mingyu Lei

Done

File third_party/blink/renderer/modules/ai/text_model_download_progress_event.idl

Line 10, Patchset 3:interface TextModelDownloadProgressEvent : Event {

Domenic Denicola . resolved

Use the normal `ProgressEvent`, don't invent a new one.

Mingyu Lei

Oh I didn't know there is `ProgressEvent`. Done.

Line 11, Patchset 3: attribute long long loaded;

Kentaro Hara . resolved

nit: should this be "unsigned long long"?

Mingyu Lei

This is not applicable anymore since we use the default ProgressEvent instead.

Line 12, Patchset 3: attribute long long total;

Kentaro Hara . resolved

ditto.

Mingyu Lei

This is not applicable anymore since we use the default ProgressEvent instead.

Open in Gerrit

Related details

Attention is currently required from:

Domenic Denicola
Fergal Daly
Kentaro Hara

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

open

diffy

Domenic Denicola (Gerrit)

unread,

Jun 24, 2024, 10:25:13 PM (5 days ago) Jun 24

to Mingyu Lei, Chromium LUCI CQ, Fergal Daly, Kentaro Hara, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Attention needed from Fergal Daly, Kentaro Hara and Mingyu Lei

Domenic Denicola voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Fergal Daly
Kentaro Hara
Mingyu Lei

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Prompt API: implement the download progress JS event listener [chromium/src : main]

Domenic Denicola (Gerrit)

Domenic Denicola voted and added 2 comments

Votes added by Domenic Denicola

2 comments

Related details

Kentaro Hara (Gerrit)

Kentaro Hara added 2 comments

Related details

Kentaro Hara (Gerrit)

Kentaro Hara added 1 comment

Related details

Mingyu Lei (Gerrit)

Mingyu Lei added 5 comments

Related details

Domenic Denicola (Gerrit)

Domenic Denicola voted Code-Review+1

Related details