Introduce V8<GeneratedCallbackFunction>::InvokeAndCatch() [chromium/src : main]
0 views
Skip to first unread message
Andrey Kosyakov (Gerrit)
Dec 11, 2025, 6:48:26 PM (3 days ago) Dec 11
to Nate Chapin, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Nate Chapin
Andrey Kosyakov voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Chapin (Gerrit)
Dec 11, 2025, 6:55:17 PM (3 days ago) Dec 11
to Andrey Kosyakov, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Andrey Kosyakov
Nate Chapin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nate Chapin
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Nate Chapin . unresolved
For thoroughness, would you mind posting an example of the generated code?
File third_party/blink/renderer/bindings/scripts/bind_gen/callback_function.py
Line 492, Patchset 2 (Latest):
assert cg_context.callback_functionNate Chapin . unresolved
Why is this in the middle, instead of at the top?
Related details
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Dec 11, 2025, 9:24:05 PM (3 days ago) Dec 11
to Nate Chapin, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Andrey Kosyakov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Commit-Queue | +1 |
For thoroughness, would you mind posting an example of the generated code?
Andrey Kosyakov
Done (in the CL description)
File third_party/blink/renderer/bindings/scripts/bind_gen/callback_function.py
Why is this in the middle, instead of at the top?
Andrey Kosyakov
Because that's where a similar `if` in the code that I used as reference :-) Moved it to the top.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Dec 11, 2025, 10:26:35 PM (3 days ago) Dec 11
to Nate Chapin, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Andrey Kosyakov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 11, 2025, 11:07:37 PM (3 days ago) Dec 11
to Andrey Kosyakov, Nate Chapin, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/bindings/scripts/bind_gen/callback_function.py
Insertions: 2, Deletions: 3.
@@ -463,6 +463,7 @@
def make_invoke_and_catch_function(cg_context, function_name,
invoke_function_name):
assert isinstance(cg_context, CodeGenContext)
+ assert cg_context.callback_function
T = TextNode
F = FormatNode
@@ -489,8 +490,6 @@
class_name=cg_context.class_name)
func_decl = func_def.make_decl(nodiscard=True)
- assert cg_context.callback_function
-
body = func_def.body
body.extend([
T("v8::TryCatch try_catch(GetIsolate());"),
@@ -499,7 +498,7 @@
api_func_name=invoke_function_name,
arg_names=", ".join(arg_names)),
CxxLikelyIfNode(cond="result.IsJust()",
- attribute=None,
+ attribute="[[likely]]",
body=T("return base::ok({});".format(
"" if is_void else "result.FromJust()"))),
T("return base::unexpected(ScriptValue(GetIsolate(), try_catch.Exception()));"
```
Change information
Commit message:
Introduce V8<GeneratedCallbackFunction>::InvokeAndCatch()
... to reduce boilerplate for callers that need to retrieve potential
exceptions to pass them further.
Example generated method:
```
base::expected<ScriptValue, ScriptValue> V8Mapper::InvokeAndCatch(
bindings::V8ValueOrScriptWrappableAdapter arg0_receiver,
const ScriptValue& arg1_element,
uint64_t arg2_index) {
v8::TryCatch try_catch(GetIsolate());
auto result = Invoke(arg0_receiver, arg1_element, arg2_index);
if (result.IsJust()) [[likely]] {
return base::ok(result.FromJust());
}
return base::unexpected(ScriptValue(GetIsolate(),
try_catch.Exception()));
}
```
Bug: 462010740
Change-Id: Ibc0df892f2248c7cd6ec915b291acf581c208b35
Reviewed-by: Nate Chapin <jap...@chromium.org>
Commit-Queue: Andrey Kosyakov <ca...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1557828}
Files:
- M third_party/blink/renderer/bindings/scripts/bind_gen/callback_function.py
- M third_party/blink/renderer/core/dom/observable.cc
Change size: L
Delta: 2 files changed, 131 insertions(+), 153 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Chapin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages