[BRP] Add RAW_PTR_EXCLUSION based on automated output of the rewriter [chromium/src : main]

0 views
Skip to first unread message

Bartek Nowierski (Gerrit)

unread,
Jun 21, 2024, 11:03:33 AM (8 days ago) Jun 21
to Keishi Hattori, Tricium, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Stephen Chenney, android-web...@chromium.org, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, video-networking...@google.com
Attention needed from Keishi Hattori

Bartek Nowierski voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4441ef09932be9bc8a5be9b16007e48a91a8b1c8
Gerrit-Change-Number: 5645486
Gerrit-PatchSet: 1
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Comment-Date: Fri, 21 Jun 2024 15:03:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keishi Hattori (Gerrit)

unread,
Jun 23, 2024, 2:30:40 AM (7 days ago) Jun 23
to Bartek Nowierski, Chromium LUCI CQ, Tricium, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Stephen Chenney, android-web...@chromium.org, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, video-networking...@google.com
Attention needed from Bartek Nowierski

Keishi Hattori voted and added 1 comment

Votes added by Keishi Hattori

Code-Review+1
Commit-Queue+2
Owners-Override+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Keishi Hattori . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Bartek Nowierski
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4441ef09932be9bc8a5be9b16007e48a91a8b1c8
Gerrit-Change-Number: 5645486
Gerrit-PatchSet: 2
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Bartek Nowierski <bar...@chromium.org>
Gerrit-Comment-Date: Sun, 23 Jun 2024 06:30:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 23, 2024, 9:08:10 AM (6 days ago) Jun 23
to Bartek Nowierski, Keishi Hattori, Tricium, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Stephen Chenney, android-web...@chromium.org, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, video-networking...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
[BRP] Add RAW_PTR_EXCLUSION based on automated output of the rewriter

This includes un-rewriting a pointer that has been rewritten in crrev.com/c/5645505 but shouldn't have
Change-Id: I4441ef09932be9bc8a5be9b16007e48a91a8b1c8
Auto-Submit: Bartek Nowierski <bar...@chromium.org>
Reviewed-by: Keishi Hattori <kei...@chromium.org>
Commit-Queue: Keishi Hattori <kei...@chromium.org>
Owners-Override: Keishi Hattori <kei...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1318330}
Files:
  • M third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.cc
  • M third_party/blink/renderer/modules/screen_orientation/screen_orientation.cc
  • M third_party/blink/renderer/platform/bindings/v8_per_context_data.cc
  • M third_party/blink/renderer/platform/bindings/wrapper_type_info.h
  • M third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image_test.cc
  • M third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context.h
  • M third_party/blink/renderer/platform/media/video_decode_stats_reporter_unittest.cc
  • M third_party/blink/renderer/platform/text/segmented_string.h
  • M third_party/blink/renderer/platform/text/text_run.cc
  • M third_party/blink/renderer/platform/text/text_run.h
  • M third_party/blink/renderer/platform/widget/compositing/android_webview/synchronous_layer_tree_frame_sink.h
Change size: M
Delta: 11 files changed, 37 insertions(+), 17 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Keishi Hattori
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4441ef09932be9bc8a5be9b16007e48a91a8b1c8
Gerrit-Change-Number: 5645486
Gerrit-PatchSet: 3
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages