Use UnwrappingCrossThreadHandle in ImageCaptureFrameGrabber [chromium/src : main]

[Daniel Cheng (Gerrit)]

Attention needed from Michael Lippautz and Reilly Grant

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Michael Lippautz
• Reilly Grant

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Icba0ebf829e6dfaa094f2f08862b79a838a2f362

Gerrit-Change-Number: 7167966

Gerrit-PatchSet: 1

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Hirokazu Honda <hi...@chromium.org>

Gerrit-CC: Hongchan Choi <hong...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Michael Wilson <mjwi...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Comment-Date: Tue, 18 Nov 2025 16:12:50 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Reilly Grant (Gerrit)]

Attention needed from Daniel Cheng and Michael Lippautz

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng
• Michael Lippautz

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 06:20:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Michael Lippautz (Gerrit)]

Attention needed from Daniel Cheng

Michael Lippautz voted and added 1 comment

Votes added by Michael Lippautz

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Michael Lippautz . resolved

lgtm, thanks

IIUC that's actually what the initial use case of `CrossThreadPersistent` was (but was broadened much more) and why we introduced the `CrossThreadHandle`.

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 08:57:34 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Daniel Cheng (Gerrit)]

Daniel Cheng voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Gerrit-Comment-Date: Thu, 20 Nov 2025 04:29:47 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Use UnwrappingCrossThreadHandle in ImageCaptureFrameGrabber

While this code appears to work, Persistents are not safe to pass across
threads. Rewrite this to use UnwrappingCrossThreadHandle instead.

Additional fixes and cleanups:
- Make ScopedPromiseResolver an inner class. There is already another
  `blink::ScopedPromiseResolver` that is not templated that would
  conflict with it if both definitions were ever visible in the same
  translation unit.
- Remove unnecessary callbacks to remove indirections and simplify the
  code. Callback trampolines are not free, and this helper is used in
  exactly one place.
- Related: return an image by value rather than by callback, so the
  compiler can warn if a path forgets to return an image.

Bug: 460743390

Change-Id: Icba0ebf829e6dfaa094f2f08862b79a838a2f362

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7167966

Reviewed-by: Reilly Grant <rei...@chromium.org>

Reviewed-by: Michael Lippautz <mlip...@chromium.org>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1547631}

Files:

• M third_party/blink/renderer/modules/imagecapture/image_capture_frame_grabber.cc
• M third_party/blink/renderer/modules/imagecapture/image_capture_frame_grabber.h
• M third_party/blink/renderer/platform/wtf/cross_thread_copier_base.h

Change size: M

Delta: 3 files changed, 95 insertions(+), 144 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Reilly Grant, +1 by Michael Lippautz

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Icba0ebf829e6dfaa094f2f08862b79a838a2f362

Gerrit-Change-Number: 7167966

Gerrit-PatchSet: 2

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>