quick-answers: add feature type [chromium/src : main]

0 views
Skip to first unread message

Xiaohui Chen (Gerrit)

unread,
Jun 21, 2024, 4:59:29 PM (8 days ago) Jun 21
to Yuki Awano, Hans Wennborg, Kentaro Hara, AyeAye, Assistive Code Review, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, chrome-waff...@google.com, blink-...@chromium.org, iclella...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, chasej...@chromium.org, feature-me...@chromium.org, alemat...@chromium.org, blundell+...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, oshima...@chromium.org, rrsilva+wat...@google.com
Attention needed from Yuki Awano

Xiaohui Chen added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Xiaohui Chen . resolved

I am playing with the new cider-g, but apparently it does not respect .gitignore and has one click amend feature :) I will "amend back" in a bit.

Open in Gerrit

Related details

Attention is currently required from:
  • Yuki Awano
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I23f27e06997252576cc7c2a526990cd140c80201
Gerrit-Change-Number: 5641737
Gerrit-PatchSet: 7
Gerrit-Owner: Yuki Awano <yaw...@google.com>
Gerrit-Reviewer: Xiaohui Chen <xiao...@chromium.org>
Gerrit-Reviewer: Yuki Awano <yaw...@google.com>
Gerrit-CC: Assistive Code Review <assistive-...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Yuki Awano <yaw...@google.com>
Gerrit-Comment-Date: Fri, 21 Jun 2024 20:59:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Xiaohui Chen (Gerrit)

unread,
Jun 21, 2024, 7:22:46 PM (8 days ago) Jun 21
to Yuki Awano, Hans Wennborg, Kentaro Hara, AyeAye, Assistive Code Review, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, chrome-waff...@google.com, blink-...@chromium.org, iclella...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, chasej...@chromium.org, feature-me...@chromium.org, alemat...@chromium.org, blundell+...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, oshima...@chromium.org, rrsilva+wat...@google.com
Attention needed from Yuki Awano

Xiaohui Chen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yuki Awano
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I23f27e06997252576cc7c2a526990cd140c80201
Gerrit-Change-Number: 5641737
Gerrit-PatchSet: 10
Gerrit-Owner: Yuki Awano <yaw...@google.com>
Gerrit-Reviewer: Xiaohui Chen <xiao...@chromium.org>
Gerrit-Reviewer: Yuki Awano <yaw...@google.com>
Gerrit-CC: Assistive Code Review <assistive-...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Yuki Awano <yaw...@google.com>
Gerrit-Comment-Date: Fri, 21 Jun 2024 23:22:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Yuki Awano (Gerrit)

unread,
Jun 21, 2024, 7:43:34 PM (8 days ago) Jun 21
to Xiaohui Chen, Hans Wennborg, Kentaro Hara, AyeAye, Assistive Code Review, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, chrome-waff...@google.com, blink-...@chromium.org, iclella...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, chasej...@chromium.org, feature-me...@chromium.org, alemat...@chromium.org, blundell+...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, oshima...@chromium.org, rrsilva+wat...@google.com

Yuki Awano voted and added 1 comment

Votes added by Yuki Awano

Auto-Submit+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Yuki Awano . resolved

Thank you for the review!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I23f27e06997252576cc7c2a526990cd140c80201
Gerrit-Change-Number: 5641737
Gerrit-PatchSet: 10
Gerrit-Owner: Yuki Awano <yaw...@google.com>
Gerrit-Reviewer: Xiaohui Chen <xiao...@chromium.org>
Gerrit-Reviewer: Yuki Awano <yaw...@google.com>
Gerrit-CC: Assistive Code Review <assistive-...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Comment-Date: Fri, 21 Jun 2024 23:43:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 21, 2024, 7:48:57 PM (8 days ago) Jun 21
to Yuki Awano, Xiaohui Chen, Hans Wennborg, Kentaro Hara, AyeAye, Assistive Code Review, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, chrome-waff...@google.com, blink-...@chromium.org, iclella...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, chasej...@chromium.org, feature-me...@chromium.org, alemat...@chromium.org, blundell+...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, oshima...@chromium.org, rrsilva+wat...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
quick-answers: add feature type

- Add a concept feature type to QuickAnswersState. This is to support
  MagicBoost.
- QuickAnswersState now allows you to query a state of Quick Answers
  capability in a specified feature type.
Bug: b:340628526
Test: chromeos_components_unittests --gtest_filter=*QuickAnswersState*
Change-Id: I23f27e06997252576cc7c2a526990cd140c80201
Reviewed-by: Xiaohui Chen <xiao...@chromium.org>
Auto-Submit: Yuki Awano <yaw...@google.com>
Commit-Queue: Yuki Awano <yaw...@google.com>
Cr-Commit-Position: refs/heads/main@{#1318220}
Files:
  • M chrome/browser/ui/quick_answers/lacros/quick_answers_state_lacros.cc
  • M chrome/browser/ui/quick_answers/quick_answers_browsertest_base.cc
  • M chrome/browser/ui/quick_answers/quick_answers_controller_browsertest.cc
  • M chrome/browser/ui/quick_answers/quick_answers_controller_impl.cc
  • M chrome/browser/ui/quick_answers/quick_answers_controller_unittest.cc
  • M chrome/browser/ui/quick_answers/quick_answers_state_ash.cc
  • M chrome/browser/ui/quick_answers/quick_answers_state_ash_unittest.cc
  • M chrome/browser/ui/quick_answers/read_write_cards_manager_impl.cc
  • M chrome/browser/ui/quick_answers/read_write_cards_manager_impl_unittest.cc
  • M chrome/browser/ui/webui/ash/settings/pages/languages/languages_section.cc
  • M chrome/browser/ui/webui/ash/settings/pages/search/search_section.cc
  • M chromeos/components/quick_answers/BUILD.gn
  • M chromeos/components/quick_answers/public/cpp/BUILD.gn
  • M chromeos/components/quick_answers/public/cpp/quick_answers_state.cc
  • M chromeos/components/quick_answers/public/cpp/quick_answers_state.h
  • A chromeos/components/quick_answers/public/cpp/quick_answers_state_unittest.cc
  • M chromeos/components/quick_answers/test/fake_quick_answers_state.cc
  • M chromeos/components/quick_answers/utils/spell_checker.cc
Change size: L
Delta: 18 files changed, 237 insertions(+), 53 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Xiaohui Chen
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I23f27e06997252576cc7c2a526990cd140c80201
Gerrit-Change-Number: 5641737
Gerrit-PatchSet: 11
Gerrit-Owner: Yuki Awano <yaw...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Xiaohui Chen <xiao...@chromium.org>
Gerrit-Reviewer: Yuki Awano <yaw...@google.com>
Gerrit-CC: Assistive Code Review <assistive-...@google.com>
open
diffy
satisfied_requirement

Ken Rockot (Gerrit)

unread,
Jun 21, 2024, 9:42:16 PM (8 days ago) Jun 21
to Yuki Awano, Chromium LUCI CQ, Xiaohui Chen, Hans Wennborg, Kentaro Hara, AyeAye, Assistive Code Review, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, chrome-waff...@google.com, blink-...@chromium.org, iclella...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, chasej...@chromium.org, feature-me...@chromium.org, alemat...@chromium.org, blundell+...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, oshima...@chromium.org, rrsilva+wat...@google.com, Ken Rockot

Ken Rockot has created a revert of this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: revert
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages