Dominic Farolino (Gerrit)

unread,

Jan 9, 2026, 4:31:33 PM (7 days ago) Jan 9

to Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org

Attention needed from Daniel Cheng, Nasko Oskov and mmenke

Dominic Farolino voted and added 1 comment

Votes added by Dominic Farolino

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Dominic Farolino . resolved

mmenke@: reporting_browsertest.cc
nasko@: //content/browser/renderer_host
dcheng@: the rest!

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Nasko Oskov
mmenke

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

mmenke (Gerrit)

unread,

Jan 9, 2026, 4:32:12 PM (7 days ago) Jan 9

to Dominic Farolino, Chromium LUCI CQ, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org

Attention needed from Daniel Cheng, Dominic Farolino and Nasko Oskov

mmenke voted and added 1 comment

Votes added by mmenke

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

mmenke . resolved

LGTM, rubberstamp

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Dominic Farolino
Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nasko Oskov (Gerrit)

unread,

Jan 9, 2026, 4:44:01 PM (7 days ago) Jan 9

to Dominic Farolino, Chromium LUCI CQ, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org

Attention needed from Daniel Cheng and Dominic Farolino

Nasko Oskov voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Dominic Farolino

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Blink W3C Test Autoroller (Gerrit)

unread,

Jan 9, 2026, 4:49:51 PM (7 days ago) Jan 9

to Dominic Farolino, Chromium LUCI CQ, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org

Attention needed from Daniel Cheng and Dominic Farolino

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57117.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Dominic Farolino

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Jan 10, 2026, 8:58:22 PM (6 days ago) Jan 10

to Dominic Farolino, AyeAye, Blink W3C Test Autoroller, Chromium LUCI CQ, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org

Attention needed from Dominic Farolino, Nasko Oskov and mmenke

Daniel Cheng added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Daniel Cheng . unresolved

The change seems fine but it looks like some WPTs still need to be updated?

Open in Gerrit

Related details

Attention is currently required from:

Dominic Farolino
Nasko Oskov
mmenke

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Farolino (Gerrit)

unread,

Jan 12, 2026, 10:33:14 AM (4 days ago) Jan 12

to AyeAye, Blink W3C Test Autoroller, Chromium LUCI CQ, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org

Attention needed from Daniel Cheng, Nasko Oskov and mmenke

Dominic Farolino voted and added 2 comments

Votes added by Dominic Farolino

Commit-Queue

+1

2 comments

Patchset-level comments

File-level comment, Patchset 3:

Daniel Cheng . resolved

The change seems fine but it looks like some WPTs still need to be updated?

Dominic Farolino

Yes, should be done now.

File-level comment, Patchset 6 (Latest):

Dominic Farolino . resolved

PTAL! Fixed a failing test that I didn't catch in the first PS.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Nasko Oskov
mmenke

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

mmenke (Gerrit)

unread,

Jan 12, 2026, 10:40:54 AM (4 days ago) Jan 12

to Dominic Farolino, AyeAye, Blink W3C Test Autoroller, Chromium LUCI CQ, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org

Attention needed from Daniel Cheng, Dominic Farolino and Nasko Oskov

mmenke voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Dominic Farolino
Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Jan 12, 2026, 3:30:01 PM (4 days ago) Jan 12

to Dominic Farolino, Daniel Cheng, AyeAye, Blink W3C Test Autoroller, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org

Attention needed from Dominic Farolino and Nasko Oskov

Daniel Cheng voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Dominic Farolino
Nasko Oskov

satisfied_requirement

open

diffy

Nasko Oskov (Gerrit)

unread,

Jan 12, 2026, 8:24:44 PM (4 days ago) Jan 12

to Dominic Farolino, Daniel Cheng, AyeAye, Blink W3C Test Autoroller, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org

Attention needed from Dominic Farolino

Nasko Oskov voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Dominic Farolino

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Dominic Farolino (Gerrit)

unread,

Jan 12, 2026, 8:35:08 PM (4 days ago) Jan 12

to Daniel Cheng, AyeAye, Blink W3C Test Autoroller, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org

Dominic Farolino voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 12, 2026, 8:39:57 PM (4 days ago) Jan 12

to Dominic Farolino, Daniel Cheng, AyeAye, Blink W3C Test Autoroller, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Rename CrashReportStorage, and its remove() method

This CL renames CrashReportStorage to CrashReportContext, per W3C TAG
feedback [1], and the remove() method to delete(), per other community
feedback [2].

https://github.com/WICG/crash-reporting/pull/37 will be updated
separately.

[1]: https://github.com/w3ctag/design-reviews/issues/1129
[2]: https://github.com/WICG/crash-reporting/issues/38

R=dcheng

Bug: 400432195

Change-Id: I41025804d22b0bbd11a5fe93f8bdf6656df82b20

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7422847

Commit-Queue: Dominic Farolino <d...@chromium.org>

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Reviewed-by: mmenke <mme...@chromium.org>

Reviewed-by: Nasko Oskov <na...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1568186}

Files:

M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
M chrome/browser/net/reporting_browsertest.cc
M content/browser/renderer_host/document_associated_data.cc
M content/browser/renderer_host/document_associated_data.h
M content/browser/renderer_host/render_frame_host_impl.cc
M content/browser/renderer_host/render_frame_host_impl.h
M third_party/blink/public/mojom/frame/frame.mojom
M third_party/blink/renderer/bindings/generated_in_core.gni
M third_party/blink/renderer/bindings/idl_in_core.gni
M third_party/blink/renderer/core/frame/DEPS
M third_party/blink/renderer/core/frame/build.gni
R third_party/blink/renderer/core/frame/crash_report_context.cc
R third_party/blink/renderer/core/frame/crash_report_context.h
R third_party/blink/renderer/core/frame/crash_report_context.idl
M third_party/blink/renderer/core/frame/local_dom_window.cc
M third_party/blink/renderer/core/frame/local_dom_window.h
M third_party/blink/renderer/core/frame/window.idl
M third_party/blink/renderer/core/testing/fake_local_frame_host.cc
M third_party/blink/renderer/core/testing/fake_local_frame_host.h
M third_party/blink/web_tests/external/wpt/reporting/crashReport-test.html
M third_party/blink/web_tests/http/tests/origin_trials/webexposed/crashReport-interface.html
M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

Change size: M

Delta: 22 files changed, 75 insertions(+), 76 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng, +1 by Nasko Oskov, +1 by mmenke

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,

Jan 12, 2026, 9:15:52 PM (4 days ago) Jan 12

to Dominic Farolino, Chromium LUCI CQ, Daniel Cheng, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57117

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Rename CrashReportStorage, and its remove() method [chromium/src : main]

Dominic Farolino (Gerrit)

Dominic Farolino voted and added 1 comment

Votes added by Dominic Farolino

1 comment

Related details

mmenke (Gerrit)

mmenke voted and added 1 comment

Votes added by mmenke

1 comment

Related details

Nasko Oskov (Gerrit)

Nasko Oskov voted Code-Review+1

Related details

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details

Daniel Cheng (Gerrit)

Daniel Cheng added 1 comment

Related details

Dominic Farolino (Gerrit)

Dominic Farolino voted and added 2 comments

Votes added by Dominic Farolino

2 comments

Related details

mmenke (Gerrit)

mmenke voted Code-Review+1

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted Code-Review+1

Related details

Nasko Oskov (Gerrit)

Nasko Oskov voted Code-Review+1

Related details

Dominic Farolino (Gerrit)

Dominic Farolino voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details