[M144-LTS] [bindings] Retain underlying array buffer for [PassAsSpan] arrays... [chromium/src : refs/branch-heads/7559]

0 views

Skip to first unread message

Tiago Vignatti (xWF) (Gerrit)

unread,

Apr 15, 2026, 10:03:25 AM (12 days ago) Apr 15

to Andrey Kosyakov, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org

Attention needed from Andrey Kosyakov

Tiago Vignatti (xWF) added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Tiago Vignatti (xWF) . resolved

Hi caseq@. PTAL. I'm evaluating this one for M144 LTS but I ran into this fuchsia-binary-size problem spotted by the bots. Do you believe this is fine, specially for the sake of backport merge? Thank you very much.

Open in Gerrit

Related details

Attention is currently required from:

Andrey Kosyakov

Submit Requirements:

Code-Owners
Code-Review
Lint
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Andrey Kosyakov (Gerrit)

unread,

Apr 16, 2026, 1:37:03 PM (11 days ago) Apr 16

to Tiago Vignatti (xWF), Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org

Attention needed from Tiago Vignatti (xWF)

Andrey Kosyakov voted and added 1 comment

Votes added by Andrey Kosyakov

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Tiago Vignatti (xWF) . unresolved

Hi caseq@. PTAL. I'm evaluating this one for M144 LTS but I ran into this fuchsia-binary-size problem spotted by the bots. Do you believe this is fine, specially for the sake of backport merge? Thank you very much.

Andrey Kosyakov

Interesting, I don't think we've seen a comparable increase on trunk (https://chromium-review.git.corp.google.com/c/chromium/src/+/7595948), it's some 568 bytes for android apks and even shows negative for Fuchsia. I'm not sure if the bot can be trusted here given compressed increase >> uncompressed increase.

Anyway, I'm not sure if you want this for LTS -- technically, this approach turned out to be against the spec (we're instead supposed to treat detached arrays as empty, although in reality it would only manifest in specially crafted corner cases that are rarely useful outside of trying to write an exploit).

We ended up revising this after quite a bit of trial-and-error :-/
You may want to consider the following CLs instead:

https://chromium-review.googlesource.com/c/chromium/src/+/7746207
https://chromium-review.googlesource.com/c/chromium/src/+/7737852
https://chromium-review.googlesource.com/c/chromium/src/+/7677065

I'm stamping this one nevertheless if you still choose to go with it.

Open in Gerrit

Related details

Attention is currently required from:

Tiago Vignatti (xWF)

Submit Requirements:

Code-Owners
Code-Review
Lint

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages