WebTransport: wire up WebTransportReceiveStream construction [chromium/src : main]

0 views
Skip to first unread message

Himanshu Panwar (Gerrit)

unread,
May 15, 2026, 6:52:16 AM (4 days ago) May 15
to Nidhi Jaju, Adam Rice, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Adam Rice and Nidhi Jaju

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Nidhi Jaju
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I67faef82f29598833353bff76bfb896d3d418c22
Gerrit-Change-Number: 7817014
Gerrit-PatchSet: 9
Gerrit-Owner: Himanshu Panwar <himp...@microsoft.com>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Himanshu Panwar <himp...@microsoft.com>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Comment-Date: Fri, 15 May 2026 10:51:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nidhi Jaju (Gerrit)

unread,
May 18, 2026, 3:09:13 AM (yesterday) May 18
to Himanshu Panwar, Adam Rice, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Adam Rice and Himanshu Panwar

Nidhi Jaju voted and added 5 comments

Votes added by Nidhi Jaju

Code-Review+1

5 comments

Patchset-level comments
Commit Message
Line 10, Patchset 10 (Latest):CL.This change makes the runtime flag actually take effect by:
Nidhi Jaju . unresolved

```suggestion
CL. This change makes the runtime flag actually take effect by:
```

Line 16, Patchset 10 (Latest):UpdatingBidirectionalStream'sconstructor, Init(), and
Nidhi Jaju . unresolved

```suggestion
UpdatingBidirectionalStream's constructor, Init(), and
```

Line 17, Patchset 10 (Latest):GetIncomingStream() toconstruct and dispatch to
Nidhi Jaju . unresolved

```suggestion
GetIncomingStream() to construct and dispatch to
```

File third_party/blink/renderer/modules/webtransport/web_transport.cc
Line 724, Patchset 10 (Latest): if (RuntimeEnabledFeatures::WebTransportReceiveStreamEnabled(
ExecutionContext::From(script_state_))) {
auto* s = MakeGarbageCollected<WebTransportReceiveStream>(
script_state_, web_transport_, stream_id, std::move(readable));
s->Init(PassThroughException(isolate));
stream_to_enqueue = s;
incoming_stream = s->GetIncomingStream();
} else {
auto* s = MakeGarbageCollected<ReceiveStream>(
script_state_, web_transport_, stream_id, std::move(readable));
s->Init(PassThroughException(isolate));
stream_to_enqueue = s;
incoming_stream = s->GetIncomingStream();
}
Nidhi Jaju . unresolved
nit: We can reduce code duplication:
```suggestion
    auto init_stream = [&](auto* s) {
      s->Init(PassThroughException(isolate));
      stream_to_enqueue = s;
      incoming_stream = s->GetIncomingStream();
    };
    if (RuntimeEnabledFeatures::WebTransportReceiveStreamEnabled(
            ExecutionContext::From(script_state_))) {
      init_stream(MakeGarbageCollected<WebTransportReceiveStream>(
          script_state_, web_transport_, stream_id, std::move(readable)));
    } else {
      init_stream(MakeGarbageCollected<ReceiveStream>(
          script_state_, web_transport_, stream_id, std::move(readable)));
    }
```
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Himanshu Panwar
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I67faef82f29598833353bff76bfb896d3d418c22
    Gerrit-Change-Number: 7817014
    Gerrit-PatchSet: 10
    Gerrit-Owner: Himanshu Panwar <himp...@microsoft.com>
    Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
    Gerrit-Reviewer: Himanshu Panwar <himp...@microsoft.com>
    Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>
    Gerrit-Attention: Adam Rice <ri...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 May 2026 07:08:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Himanshu Panwar (Gerrit)

    unread,
    May 18, 2026, 5:35:31 AM (24 hours ago) May 18
    to Nidhi Jaju, Adam Rice, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
    Attention needed from Adam Rice and Nidhi Jaju

    Himanshu Panwar added 4 comments

    Commit Message
    Line 10, Patchset 10:CL.This change makes the runtime flag actually take effect by:
    Nidhi Jaju . resolved

    ```suggestion
    CL. This change makes the runtime flag actually take effect by:
    ```

    Himanshu Panwar

    Marked as resolved.

    Line 16, Patchset 10:UpdatingBidirectionalStream'sconstructor, Init(), and
    Nidhi Jaju . resolved

    ```suggestion
    UpdatingBidirectionalStream's constructor, Init(), and
    ```

    Himanshu Panwar

    Marked as resolved.

    Line 17, Patchset 10:GetIncomingStream() toconstruct and dispatch to
    Nidhi Jaju . resolved

    ```suggestion
    GetIncomingStream() to construct and dispatch to
    ```

    Himanshu Panwar

    Marked as resolved.

    File third_party/blink/renderer/modules/webtransport/web_transport.cc
    Line 724, Patchset 10: if (RuntimeEnabledFeatures::WebTransportReceiveStreamEnabled(

    ExecutionContext::From(script_state_))) {
    auto* s = MakeGarbageCollected<WebTransportReceiveStream>(
    script_state_, web_transport_, stream_id, std::move(readable));
    s->Init(PassThroughException(isolate));
    stream_to_enqueue = s;
    incoming_stream = s->GetIncomingStream();
    } else {
    auto* s = MakeGarbageCollected<ReceiveStream>(
    script_state_, web_transport_, stream_id, std::move(readable));
    s->Init(PassThroughException(isolate));
    stream_to_enqueue = s;
    incoming_stream = s->GetIncomingStream();
    }
    Nidhi Jaju . resolved
    nit: We can reduce code duplication:
    ```suggestion
        auto init_stream = [&](auto* s) {
          s->Init(PassThroughException(isolate));
          stream_to_enqueue = s;
          incoming_stream = s->GetIncomingStream();
        };
        if (RuntimeEnabledFeatures::WebTransportReceiveStreamEnabled(
                ExecutionContext::From(script_state_))) {
          init_stream(MakeGarbageCollected<WebTransportReceiveStream>(
              script_state_, web_transport_, stream_id, std::move(readable)));
        } else {
          init_stream(MakeGarbageCollected<ReceiveStream>(
              script_state_, web_transport_, stream_id, std::move(readable)));
        }
    ```
    Himanshu Panwar

    Updated as per suggestion.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Rice
    • Nidhi Jaju
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I67faef82f29598833353bff76bfb896d3d418c22
      Gerrit-Change-Number: 7817014
      Gerrit-PatchSet: 10
      Gerrit-Owner: Himanshu Panwar <himp...@microsoft.com>
      Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
      Gerrit-Reviewer: Himanshu Panwar <himp...@microsoft.com>
      Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
      Gerrit-Attention: Adam Rice <ri...@chromium.org>
      Gerrit-Comment-Date: Mon, 18 May 2026 09:35:08 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Nidhi Jaju <nidh...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nidhi Jaju (Gerrit)

      unread,
      May 18, 2026, 7:35:10 PM (10 hours ago) May 18
      to Himanshu Panwar, Adam Rice, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
      Attention needed from Adam Rice and Himanshu Panwar

      Nidhi Jaju voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Adam Rice
      • Himanshu Panwar
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I67faef82f29598833353bff76bfb896d3d418c22
      Gerrit-Change-Number: 7817014
      Gerrit-PatchSet: 14
      Gerrit-Owner: Himanshu Panwar <himp...@microsoft.com>
      Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
      Gerrit-Reviewer: Himanshu Panwar <himp...@microsoft.com>
      Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>
      Gerrit-Attention: Adam Rice <ri...@chromium.org>
      Gerrit-Comment-Date: Mon, 18 May 2026 23:34:43 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages