Forward declare ChildURLLoaderFactoryBundle in local_frame_client.h [chromium/src : main]
0 views
Skip to first unread message
David Sanders (Gerrit)
Nov 21, 2025, 5:31:58 PM (yesterday) Nov 21
to Raphael Kubo da Costa, Kentaro Hara, Nate Chapin, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from David Sanders
Message from David Sanders![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- David Sanders
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Sanders (Gerrit)
Nov 21, 2025, 5:33:08 PM (yesterday) Nov 21
to Nate Chapin, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from Nate Chapin
David Sanders voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Chapin (Gerrit)
Nov 21, 2025, 5:42:52 PM (yesterday) Nov 21
to David Sanders, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from David Sanders
Nate Chapin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- David Sanders
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Sanders (Gerrit)
Nov 21, 2025, 5:56:35 PM (yesterday) Nov 21
to Nate Chapin, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
David Sanders voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 21, 2025, 6:10:48 PM (yesterday) Nov 21
to David Sanders, Nate Chapin, Raphael Kubo da Costa, Kentaro Hara, AyeAye, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Forward declare ChildURLLoaderFactoryBundle in local_frame_client.h
Should save ~39 MiB of compiler input size.
Adds missing includes as needed to fix the build.
Bug: 429365675
Change-Id: I2d19fe1dfa4194e7147d3a106eccdf1192c24056
Reviewed-by: Nate Chapin <jap...@chromium.org>
Commit-Queue: David Sanders <dsand...@ucsbalum.com>
Cr-Commit-Position: refs/heads/main@{#1548754}
Files:
- M third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
- M third_party/blink/renderer/core/frame/local_frame_client.h
- M third_party/blink/renderer/core/loader/empty_clients.h
- M third_party/blink/renderer/core/loader/resource/font_resource_test.cc
Change size: XS
Delta: 4 files changed, 4 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Chapin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages