Forward declare ChildURLLoaderFactoryBundle in local_frame_client.h [chromium/src : main]

0 views
Skip to first unread message

David Sanders (Gerrit)

unread,
Nov 21, 2025, 5:31:58 PM (yesterday) Nov 21
to Raphael Kubo da Costa, Kentaro Hara, Nate Chapin, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from David Sanders

Message from David Sanders

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2d19fe1dfa4194e7147d3a106eccdf1192c24056
Gerrit-Change-Number: 7188689
Gerrit-PatchSet: 5
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Fri, 21 Nov 2025 22:31:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Sanders (Gerrit)

unread,
Nov 21, 2025, 5:33:08 PM (yesterday) Nov 21
to Nate Chapin, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from Nate Chapin

David Sanders voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nate Chapin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2d19fe1dfa4194e7147d3a106eccdf1192c24056
Gerrit-Change-Number: 7188689
Gerrit-PatchSet: 5
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Fri, 21 Nov 2025 22:33:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Chapin (Gerrit)

unread,
Nov 21, 2025, 5:42:52 PM (yesterday) Nov 21
to David Sanders, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from David Sanders

Nate Chapin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2d19fe1dfa4194e7147d3a106eccdf1192c24056
Gerrit-Change-Number: 7188689
Gerrit-PatchSet: 5
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Fri, 21 Nov 2025 22:42:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

David Sanders (Gerrit)

unread,
Nov 21, 2025, 5:56:35 PM (yesterday) Nov 21
to Nate Chapin, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org

David Sanders voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2d19fe1dfa4194e7147d3a106eccdf1192c24056
Gerrit-Change-Number: 7188689
Gerrit-PatchSet: 5
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Fri, 21 Nov 2025 22:56:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 21, 2025, 6:10:48 PM (yesterday) Nov 21
to David Sanders, Nate Chapin, Raphael Kubo da Costa, Kentaro Hara, AyeAye, blink-revie...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Forward declare ChildURLLoaderFactoryBundle in local_frame_client.h

Should save ~39 MiB of compiler input size.

Adds missing includes as needed to fix the build.
Bug: 429365675
Change-Id: I2d19fe1dfa4194e7147d3a106eccdf1192c24056
Reviewed-by: Nate Chapin <jap...@chromium.org>
Commit-Queue: David Sanders <dsand...@ucsbalum.com>
Cr-Commit-Position: refs/heads/main@{#1548754}
Files:
  • M third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
  • M third_party/blink/renderer/core/frame/local_frame_client.h
  • M third_party/blink/renderer/core/loader/empty_clients.h
  • M third_party/blink/renderer/core/loader/resource/font_resource_test.cc
Change size: XS
Delta: 4 files changed, 4 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nate Chapin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2d19fe1dfa4194e7147d3a106eccdf1192c24056
Gerrit-Change-Number: 7188689
Gerrit-PatchSet: 6
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages