post support [chromium/src : main]

0 views
Skip to first unread message

Sam Goto (Gerrit)

unread,
Feb 9, 2026, 1:17:21 PM (2 days ago) Feb 9
to Christian Biesinger, Kentaro Hara, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, webauthn...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, derinel+wat...@google.com, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org
Attention needed from Christian Biesinger

Sam Goto added 1 comment

File content/browser/webid/identity_registry.h
Line 28, Patchset 4 (Latest): blink::mojom::FedCmRedirectMethod method,
Sam Goto . unresolved

Can we avoid this prefix? Isn't there a namespace that we can add ourselves to avoid this?

Open in Gerrit

Related details

Attention is currently required from:
  • Christian Biesinger
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ice8d823006d965863a1ec3d5159f77566ea47edb
Gerrit-Change-Number: 7545720
Gerrit-PatchSet: 4
Gerrit-Owner: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Sam Goto <go...@chromium.org>
Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>
Gerrit-Comment-Date: Mon, 09 Feb 2026 18:17:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Christian Biesinger (Gerrit)

unread,
Feb 9, 2026, 8:12:29 PM (2 days ago) Feb 9
to Christian Biesinger, Sam Goto, Kentaro Hara, Raphael Kubo da Costa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, webauthn...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, derinel+wat...@google.com, blink-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, npm+...@chromium.org, yigu+...@chromium.org
Attention needed from Sam Goto

Christian Biesinger added 1 comment

File content/browser/webid/identity_registry.h
Line 28, Patchset 4 (Latest): blink::mojom::FedCmRedirectMethod method,
Sam Goto . unresolved

Can we avoid this prefix? Isn't there a namespace that we can add ourselves to avoid this?

Christian Biesinger

https://chromium-review.googlesource.com/c/chromium/src/+/7559219 but that was not trivial. Still need to figure out a presubmit failure before sending it for review.

Open in Gerrit

Related details

Attention is currently required from:
  • Sam Goto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ice8d823006d965863a1ec3d5159f77566ea47edb
Gerrit-Change-Number: 7545720
Gerrit-PatchSet: 4
Gerrit-Owner: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Sam Goto <go...@chromium.org>
Gerrit-Attention: Sam Goto <go...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Feb 2026 01:12:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam Goto <go...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages