Make all Element types part of the same enum. [chromium/src : main]

0 views

Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,

Apr 1, 2026, 6:30:51 AM (yesterday) Apr 1

to Raphael Kubo da Costa, Kenneth Rohde Christiansen, Stephen Chenney, srirama chandra sekhar, Olga Gerchikov, chromium...@chromium.org, Fredrik Söderquist, Menard, Alexis, Kentaro Hara, Dirk Schulze, blink-re...@chromium.org, dbaro...@chromium.org, blink-rev...@chromium.org, dgroga...@chromium.org, gl...@chromium.org, fmalit...@chromium.org, silv...@chromium.org, apavlo...@chromium.org, pdr+svgw...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, eric.c...@apple.com, blink-revie...@chromium.org, blink-...@chromium.org, kouhe...@chromium.org, dominicc+...@chromium.org, dom+...@chromium.org

Steinar H Gunderson has uploaded the change for review

Commit message

Make all Element types part of the same enum.

Include SVG and MathML element types into the HTMLElementType enum
(which is now renamed ElementType). This gives them the same benefits
of cheaper downcast testing, and will also let the StyleAdjuster
switch on them in the future instead of having to treat “not an HTML
element” as one big bucket to be distinguished in other ways.

Change-Id: Icec12881888a12a31cf61000eca7e1cd5ce01a47

Change diff

Change information

Files:

M third_party/blink/renderer/bindings/core/v8/v8_html_constructor.cc
M third_party/blink/renderer/bindings/core/v8/v8_html_constructor.h
M third_party/blink/renderer/bindings/scripts/bind_gen/interface.py
A third_party/blink/renderer/build/scripts/make_element_type_enum.py
M third_party/blink/renderer/build/scripts/make_element_type_helpers.py
M third_party/blink/renderer/build/scripts/scripts.gni
M third_party/blink/renderer/build/scripts/templates/element_type_enum.h.tmpl
M third_party/blink/renderer/build/scripts/templates/element_type_helpers.cc.tmpl
M third_party/blink/renderer/build/scripts/templates/element_type_helpers.h.tmpl
M third_party/blink/renderer/core/BUILD.gn
M third_party/blink/renderer/core/css/resolver/style_adjuster.cc
M third_party/blink/renderer/core/dom/element.h
M third_party/blink/renderer/core/dom/node.h
M third_party/blink/renderer/core/html/canvas/html_canvas_element.h
M third_party/blink/renderer/core/html/custom/custom_element.cc
M third_party/blink/renderer/core/html/custom/custom_element_registry.cc
M third_party/blink/renderer/core/html/fenced_frame/html_fenced_frame_element.h
M third_party/blink/renderer/core/html/forms/html_button_element.h
M third_party/blink/renderer/core/html/forms/html_data_list_element.h
M third_party/blink/renderer/core/html/forms/html_field_set_element.h
M third_party/blink/renderer/core/html/forms/html_form_element.h
M third_party/blink/renderer/core/html/forms/html_input_element.h
M third_party/blink/renderer/core/html/forms/html_label_element.h
M third_party/blink/renderer/core/html/forms/html_legend_element.h
M third_party/blink/renderer/core/html/forms/html_opt_group_element.h
M third_party/blink/renderer/core/html/forms/html_option_element.h
M third_party/blink/renderer/core/html/forms/html_output_element.h
M third_party/blink/renderer/core/html/forms/html_select_element.h
M third_party/blink/renderer/core/html/forms/html_selected_content_element.h
M third_party/blink/renderer/core/html/forms/html_text_area_element.h
M third_party/blink/renderer/core/html/html_anchor_element.h
M third_party/blink/renderer/core/html/html_area_element.h
M third_party/blink/renderer/core/html/html_base_element.h
M third_party/blink/renderer/core/html/html_bdi_element.h
M third_party/blink/renderer/core/html/html_body_element.h
M third_party/blink/renderer/core/html/html_br_element.h
M third_party/blink/renderer/core/html/html_credential_element.h
M third_party/blink/renderer/core/html/html_data_element.h
M third_party/blink/renderer/core/html/html_details_element.h
M third_party/blink/renderer/core/html/html_dialog_element.h
M third_party/blink/renderer/core/html/html_directory_element.h
M third_party/blink/renderer/core/html/html_div_element.h
M third_party/blink/renderer/core/html/html_dlist_element.h
M third_party/blink/renderer/core/html/html_element.h
M third_party/blink/renderer/core/html/html_embed_element.h
M third_party/blink/renderer/core/html/html_font_element.h
M third_party/blink/renderer/core/html/html_frame_element.h
M third_party/blink/renderer/core/html/html_frame_set_element.h
M third_party/blink/renderer/core/html/html_geolocation_element.h
M third_party/blink/renderer/core/html/html_head_element.h
M third_party/blink/renderer/core/html/html_heading_element.h
M third_party/blink/renderer/core/html/html_hr_element.h
M third_party/blink/renderer/core/html/html_html_element.h
M third_party/blink/renderer/core/html/html_iframe_element.h
M third_party/blink/renderer/core/html/html_image_element.h
M third_party/blink/renderer/core/html/html_install_element.h
M third_party/blink/renderer/core/html/html_li_element.h
M third_party/blink/renderer/core/html/html_link_element.h
M third_party/blink/renderer/core/html/html_login_element.h
M third_party/blink/renderer/core/html/html_map_element.h
M third_party/blink/renderer/core/html/html_marquee_element.h
M third_party/blink/renderer/core/html/html_menu_bar_element.h
M third_party/blink/renderer/core/html/html_menu_element.h
M third_party/blink/renderer/core/html/html_menu_item_element.h
M third_party/blink/renderer/core/html/html_menu_list_element.h
M third_party/blink/renderer/core/html/html_meta_element.h
M third_party/blink/renderer/core/html/html_meter_element.h
M third_party/blink/renderer/core/html/html_mod_element.h
M third_party/blink/renderer/core/html/html_no_embed_element.h
M third_party/blink/renderer/core/html/html_no_script_element.h
M third_party/blink/renderer/core/html/html_object_element.h
M third_party/blink/renderer/core/html/html_olist_element.h
M third_party/blink/renderer/core/html/html_paragraph_element.h
M third_party/blink/renderer/core/html/html_param_element.h
M third_party/blink/renderer/core/html/html_picture_element.h
M third_party/blink/renderer/core/html/html_pre_element.h
M third_party/blink/renderer/core/html/html_progress_element.h
M third_party/blink/renderer/core/html/html_quote_element.h
M third_party/blink/renderer/core/html/html_script_element.h
M third_party/blink/renderer/core/html/html_search_element.h
M third_party/blink/renderer/core/html/html_slot_element.h
M third_party/blink/renderer/core/html/html_source_element.h
M third_party/blink/renderer/core/html/html_span_element.h
M third_party/blink/renderer/core/html/html_style_element.h
M third_party/blink/renderer/core/html/html_summary_element.h
M third_party/blink/renderer/core/html/html_table_caption_element.h
M third_party/blink/renderer/core/html/html_table_cell_element.h
M third_party/blink/renderer/core/html/html_table_col_element.h
M third_party/blink/renderer/core/html/html_table_element.h
M third_party/blink/renderer/core/html/html_table_row_element.h
M third_party/blink/renderer/core/html/html_table_section_element.h
M third_party/blink/renderer/core/html/html_template_element.h
M third_party/blink/renderer/core/html/html_time_element.h
M third_party/blink/renderer/core/html/html_title_element.h
M third_party/blink/renderer/core/html/html_ulist_element.h
M third_party/blink/renderer/core/html/html_unknown_element.h
M third_party/blink/renderer/core/html/html_user_media_element.h
M third_party/blink/renderer/core/html/html_wbr_element.h
M third_party/blink/renderer/core/html/media/html_audio_element.h
M third_party/blink/renderer/core/html/media/html_video_element.h
M third_party/blink/renderer/core/html/track/html_track_element.h
M third_party/blink/renderer/core/mathml/mathml_fraction_element.h
M third_party/blink/renderer/core/mathml/mathml_row_element.h
M third_party/blink/renderer/core/mathml/mathml_scripts_element.h
M third_party/blink/renderer/core/mathml/mathml_space_element.h
M third_party/blink/renderer/core/mathml/mathml_table_cell_element.h
M third_party/blink/renderer/core/mathml/mathml_token_element.h
M third_party/blink/renderer/core/svg/svg_a_element.h
M third_party/blink/renderer/core/svg/svg_animate_element.h
M third_party/blink/renderer/core/svg/svg_animate_motion_element.h
M third_party/blink/renderer/core/svg/svg_circle_element.h
M third_party/blink/renderer/core/svg/svg_clip_path_element.h
M third_party/blink/renderer/core/svg/svg_defs_element.h
M third_party/blink/renderer/core/svg/svg_desc_element.h
M third_party/blink/renderer/core/svg/svg_ellipse_element.h
M third_party/blink/renderer/core/svg/svg_fe_blend_element.h
M third_party/blink/renderer/core/svg/svg_fe_color_matrix_element.h
M third_party/blink/renderer/core/svg/svg_fe_component_transfer_element.h
M third_party/blink/renderer/core/svg/svg_fe_composite_element.h
M third_party/blink/renderer/core/svg/svg_fe_convolve_matrix_element.h
M third_party/blink/renderer/core/svg/svg_fe_diffuse_lighting_element.h
M third_party/blink/renderer/core/svg/svg_fe_displacement_map_element.h
M third_party/blink/renderer/core/svg/svg_fe_distant_light_element.h
M third_party/blink/renderer/core/svg/svg_fe_drop_shadow_element.h
M third_party/blink/renderer/core/svg/svg_fe_flood_element.h
M third_party/blink/renderer/core/svg/svg_fe_func_a_element.h
M third_party/blink/renderer/core/svg/svg_fe_func_b_element.h
M third_party/blink/renderer/core/svg/svg_fe_func_g_element.h
M third_party/blink/renderer/core/svg/svg_fe_func_r_element.h
M third_party/blink/renderer/core/svg/svg_fe_gaussian_blur_element.h
M third_party/blink/renderer/core/svg/svg_fe_image_element.h
M third_party/blink/renderer/core/svg/svg_fe_merge_element.h
M third_party/blink/renderer/core/svg/svg_fe_merge_node_element.h
M third_party/blink/renderer/core/svg/svg_fe_morphology_element.h
M third_party/blink/renderer/core/svg/svg_fe_offset_element.h
M third_party/blink/renderer/core/svg/svg_fe_point_light_element.h
M third_party/blink/renderer/core/svg/svg_fe_specular_lighting_element.h
M third_party/blink/renderer/core/svg/svg_fe_spot_light_element.h
M third_party/blink/renderer/core/svg/svg_fe_tile_element.h
M third_party/blink/renderer/core/svg/svg_fe_turbulence_element.h
M third_party/blink/renderer/core/svg/svg_filter_element.h
M third_party/blink/renderer/core/svg/svg_foreign_object_element.h
M third_party/blink/renderer/core/svg/svg_g_element.h
M third_party/blink/renderer/core/svg/svg_image_element.h
M third_party/blink/renderer/core/svg/svg_line_element.h
M third_party/blink/renderer/core/svg/svg_linear_gradient_element.h
M third_party/blink/renderer/core/svg/svg_marker_element.h
M third_party/blink/renderer/core/svg/svg_mask_element.h
M third_party/blink/renderer/core/svg/svg_metadata_element.h
M third_party/blink/renderer/core/svg/svg_mpath_element.h
M third_party/blink/renderer/core/svg/svg_path_element.h
M third_party/blink/renderer/core/svg/svg_pattern_element.h
M third_party/blink/renderer/core/svg/svg_polygon_element.h
M third_party/blink/renderer/core/svg/svg_polyline_element.h
M third_party/blink/renderer/core/svg/svg_radial_gradient_element.h
M third_party/blink/renderer/core/svg/svg_rect_element.h
M third_party/blink/renderer/core/svg/svg_script_element.h
M third_party/blink/renderer/core/svg/svg_stop_element.h
M third_party/blink/renderer/core/svg/svg_style_element.h
M third_party/blink/renderer/core/svg/svg_svg_element.h
M third_party/blink/renderer/core/svg/svg_switch_element.h
M third_party/blink/renderer/core/svg/svg_symbol_element.h
M third_party/blink/renderer/core/svg/svg_text_element.h
M third_party/blink/renderer/core/svg/svg_text_path_element.h
M third_party/blink/renderer/core/svg/svg_title_element.h
M third_party/blink/renderer/core/svg/svg_tspan_element.h
M third_party/blink/renderer/core/svg/svg_unknown_element.h
M third_party/blink/renderer/core/svg/svg_use_element.h
M third_party/blink/renderer/core/svg/svg_view_element.h

Change size: L

Delta: 169 files changed, 529 insertions(+), 267 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fredrik Söderquist (Gerrit)

unread,

Apr 1, 2026, 11:07:27 AM (20 hours ago) Apr 1

to Steinar H Gunderson, Ian Kilpatrick, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Stephen Chenney, srirama chandra sekhar, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dbaro...@chromium.org, dgroga...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, fmalit...@chromium.org, gl...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, silv...@chromium.org

Attention needed from Ian Kilpatrick and Steinar H Gunderson

Fredrik Söderquist voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Ian Kilpatrick
Steinar H Gunderson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Steinar H Gunderson (Gerrit)

unread,

Apr 1, 2026, 11:39:43 AM (19 hours ago) Apr 1

to Fredrik Söderquist, Ian Kilpatrick, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Stephen Chenney, srirama chandra sekhar, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dbaro...@chromium.org, dgroga...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, fmalit...@chromium.org, gl...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, silv...@chromium.org

Attention needed from Ian Kilpatrick

Steinar H Gunderson voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Ian Kilpatrick

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Ian Kilpatrick (Gerrit)

unread,

Apr 1, 2026, 1:09:13 PM (18 hours ago) Apr 1

to Steinar H Gunderson, Chromium LUCI CQ, Fredrik Söderquist, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Stephen Chenney, srirama chandra sekhar, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dbaro...@chromium.org, dgroga...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, fmalit...@chromium.org, gl...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, silv...@chromium.org

Attention needed from Steinar H Gunderson

Ian Kilpatrick voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Steinar H Gunderson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 1, 2026, 1:37:27 PM (17 hours ago) Apr 1

to Steinar H Gunderson, Ian Kilpatrick, Fredrik Söderquist, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Stephen Chenney, srirama chandra sekhar, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dbaro...@chromium.org, dgroga...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, fmalit...@chromium.org, gl...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, silv...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Make all Element types part of the same enum.

Include SVG and MathML element types into the HTMLElementType enum
(which is now renamed ElementType). This gives them the same benefits
of cheaper downcast testing, and will also let the StyleAdjuster
switch on them in the future instead of having to treat “not an HTML
element” as one big bucket to be distinguished in other ways.

Change-Id: Icec12881888a12a31cf61000eca7e1cd5ce01a47

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7718142

Reviewed-by: Fredrik Söderquist <f...@opera.com>

Commit-Queue: Steinar H Gunderson <se...@chromium.org>

Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1608635}

Files:

M third_party/blink/renderer/core/mathml/mathml_operator_element.h
M third_party/blink/renderer/core/mathml/mathml_padded_element.h
M third_party/blink/renderer/core/mathml/mathml_radical_element.h

M third_party/blink/renderer/core/mathml/mathml_row_element.h
M third_party/blink/renderer/core/mathml/mathml_scripts_element.h
M third_party/blink/renderer/core/mathml/mathml_space_element.h
M third_party/blink/renderer/core/mathml/mathml_table_cell_element.h
M third_party/blink/renderer/core/mathml/mathml_token_element.h

M third_party/blink/renderer/core/mathml/mathml_under_over_element.h

M third_party/blink/renderer/core/svg/svg_a_element.h
M third_party/blink/renderer/core/svg/svg_animate_element.h
M third_party/blink/renderer/core/svg/svg_animate_motion_element.h

M third_party/blink/renderer/core/svg/svg_animate_transform_element.h

M third_party/blink/renderer/core/svg/svg_set_element.h

M third_party/blink/renderer/core/svg/svg_stop_element.h
M third_party/blink/renderer/core/svg/svg_style_element.h
M third_party/blink/renderer/core/svg/svg_svg_element.h
M third_party/blink/renderer/core/svg/svg_switch_element.h
M third_party/blink/renderer/core/svg/svg_symbol_element.h
M third_party/blink/renderer/core/svg/svg_text_element.h
M third_party/blink/renderer/core/svg/svg_text_path_element.h
M third_party/blink/renderer/core/svg/svg_title_element.h
M third_party/blink/renderer/core/svg/svg_tspan_element.h
M third_party/blink/renderer/core/svg/svg_unknown_element.h
M third_party/blink/renderer/core/svg/svg_use_element.h
M third_party/blink/renderer/core/svg/svg_view_element.h

Change size: L

Delta: 175 files changed, 546 insertions(+), 267 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Fredrik Söderquist, +1 by Ian Kilpatrick

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages