Fix format. [chromium/src : main]

0 views
Skip to first unread message

Guido Urdaneta (Gerrit)

unread,
Jun 25, 2026, 7:22:26 AM (2 days ago) Jun 25
to Leonardo Evi, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, video-networking...@google.com
Attention needed from Leonardo Evi

Guido Urdaneta added 7 comments

File third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_frame.cc
Line 286, Patchset 2 (Latest): sb.AppendNumber(timestamp());
Guido Urdaneta . unresolved

This looks incorrect. We shouldn't be using `timestamp()`. We can expose the RtpTimestamp if available (i.e., including offset).

File third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_frame.idl
Line 13, Patchset 2 (Latest): [Measure, CallWith=ExecutionContext, RaisesException]
Guido Urdaneta . unresolved

This needs to be behind a flag.
Add an RTCEncodedFrameConstructors flag to runtime_enabled_flags.json5

File third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_frame_delegate.h
Line 86, Patchset 2 (Latest): std::optional<webrtc::RtpTimestampInfo> rtp_timestamp;
Guido Urdaneta . unresolved

rename field to rtp_timestamp_info

File third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_frame_init.idl
Line 6, Patchset 2 (Latest): boolean isSpeech = true;
Guido Urdaneta . unresolved

replace with enum, as discussed offline

Line 11, Patchset 2 (Latest): required ArrayBuffer payloadData;
Guido Urdaneta . unresolved

rename to data

Line 15, Patchset 2 (Latest): DOMString mimeType; // could be removed, better to keep it, not necessary for sending
Guido Urdaneta . unresolved

Remove comments.

Line 20, Patchset 2 (Latest):// TransformableOutgoingAudioFrame
Guido Urdaneta . unresolved

Remove these comments

Open in Gerrit

Related details

Attention is currently required from:
  • Leonardo Evi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I361783a18b28da48b1f80b86c964c0aca217c3c7
Gerrit-Change-Number: 7979160
Gerrit-PatchSet: 2
Gerrit-Owner: Leonardo Evi <ev...@chromium.org>
Gerrit-CC: Guido Urdaneta <gui...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Leonardo Evi <ev...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Jun 2026 11:21:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Guido Urdaneta (Gerrit)

unread,
Jun 25, 2026, 7:22:51 AM (2 days ago) Jun 25
to Leonardo Evi, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, video-networking...@google.com
Attention needed from Leonardo Evi

Guido Urdaneta added 1 comment

File third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_frame.cc
Line 10, Patchset 2 (Latest):#include <cstdio>
Guido Urdaneta . unresolved

remove this include

Open in Gerrit

Related details

Attention is currently required from:
  • Leonardo Evi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I361783a18b28da48b1f80b86c964c0aca217c3c7
Gerrit-Change-Number: 7979160
Gerrit-PatchSet: 2
Gerrit-Owner: Leonardo Evi <ev...@chromium.org>
Gerrit-CC: Guido Urdaneta <gui...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Leonardo Evi <ev...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Jun 2026 11:22:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Guido Urdaneta (Gerrit)

unread,
Jun 25, 2026, 7:26:24 AM (2 days ago) Jun 25
to Leonardo Evi, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, video-networking...@google.com
Attention needed from Leonardo Evi

Guido Urdaneta added 1 comment

File third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_frame.h
Line 60, Patchset 2 (Latest): // TODO : deprecete and only use metadata standardized attribute!
Guido Urdaneta . unresolved

Remove this TODO.

Open in Gerrit

Related details

Attention is currently required from:
  • Leonardo Evi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I361783a18b28da48b1f80b86c964c0aca217c3c7
Gerrit-Change-Number: 7979160
Gerrit-PatchSet: 2
Gerrit-Owner: Leonardo Evi <ev...@chromium.org>
Gerrit-CC: Guido Urdaneta <gui...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Leonardo Evi <ev...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Jun 2026 11:26:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Leonardo Evi (Gerrit)

unread,
Jun 25, 2026, 12:44:02 PM (2 days ago) Jun 25
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Guido Urdaneta, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, kinuko...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, video-networking...@google.com
Attention needed from Guido Urdaneta and Leonardo Evi

Leonardo Evi voted and added 9 comments

Votes added by Leonardo Evi

Commit-Queue+1

9 comments

File third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_frame.h
Line 60, Patchset 2: // TODO : deprecete and only use metadata standardized attribute!
Guido Urdaneta . resolved

Remove this TODO.

Leonardo Evi

Done

File third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_frame.cc
Line 10, Patchset 2:#include <cstdio>
Guido Urdaneta . resolved

remove this include

Leonardo Evi

Done

Line 286, Patchset 2: sb.AppendNumber(timestamp());
Guido Urdaneta . resolved

This looks incorrect. We shouldn't be using `timestamp()`. We can expose the RtpTimestamp if available (i.e., including offset).

Leonardo Evi

Done

File third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_frame.idl
Line 13, Patchset 2: [Measure, CallWith=ExecutionContext, RaisesException]
Guido Urdaneta . resolved

This needs to be behind a flag.
Add an RTCEncodedFrameConstructors flag to runtime_enabled_flags.json5

Leonardo Evi

Done

File third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_frame_delegate.h
Line 86, Patchset 2: std::optional<webrtc::RtpTimestampInfo> rtp_timestamp;
Guido Urdaneta . resolved

rename field to rtp_timestamp_info

Leonardo Evi

Done

File third_party/blink/renderer/modules/peerconnection/rtc_encoded_audio_frame_init.idl
Line 6, Patchset 2: boolean isSpeech = true;
Guido Urdaneta . resolved

replace with enum, as discussed offline

Leonardo Evi

Done

Line 11, Patchset 2: required ArrayBuffer payloadData;
Guido Urdaneta . resolved

rename to data

Leonardo Evi

Done

Line 15, Patchset 2: DOMString mimeType; // could be removed, better to keep it, not necessary for sending
Guido Urdaneta . resolved

Remove comments.

Leonardo Evi

Done

Line 20, Patchset 2:// TransformableOutgoingAudioFrame
Guido Urdaneta . resolved

Remove these comments

Leonardo Evi

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Guido Urdaneta
  • Leonardo Evi
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I361783a18b28da48b1f80b86c964c0aca217c3c7
    Gerrit-Change-Number: 7979160
    Gerrit-PatchSet: 3
    Gerrit-Owner: Leonardo Evi <ev...@chromium.org>
    Gerrit-Reviewer: Leonardo Evi <ev...@chromium.org>
    Gerrit-CC: Guido Urdaneta <gui...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Attention: Leonardo Evi <ev...@chromium.org>
    Gerrit-Comment-Date: Thu, 25 Jun 2026 16:43:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Guido Urdaneta <gui...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages