Stop generating Dictionary::setField(const String&) for IDL enumerations [chromium/src : main]
0 views
Skip to first unread message
Fredrik Söderquist (Gerrit)
Sep 26, 2025, 9:12:54 AM (10 days ago) Sep 26
to Yuki Shiino, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, fuzzin...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, video-networking...@google.com
Attention needed from Yuki Shiino
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Yuki Shiino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuki Shiino (Gerrit)
Sep 26, 2025, 9:03:25 PM (9 days ago) Sep 26
to Fredrik Söderquist, Yuki Shiino, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, fuzzin...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, video-networking...@google.com
Attention needed from Fredrik Söderquist
Yuki Shiino voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yuki Shiino
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
Sep 29, 2025, 5:56:30 AM (7 days ago) Sep 29
to Yuki Shiino, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, fuzzin...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, video-networking...@google.com
Fredrik Söderquist voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 29, 2025, 7:04:40 AM (7 days ago) Sep 29
to Fredrik Söderquist, Yuki Shiino, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, fuzzin...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, video-networking...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Stop generating Dictionary::setField(const String&) for IDL enumerations
In the relatively few remaining uses where the setField(V8EnumType)
version isn't practical to use (would require duplication), explicitly
call V8EnumType::Create(const String&) instead. These could potentially
be cleaned up to use a generic helper defined outside of the generated
enumeration class, but that is for a future CL (if at all).
Bug: 430171134, 40126515
Change-Id: I6fedadd4074980c06d75a3b8e6692cb5bf7e6e68
Reviewed-by: Yuki Shiino <yukis...@chromium.org>
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Cr-Commit-Position: refs/heads/main@{#1522104}
Files:
- M third_party/blink/renderer/bindings/scripts/bind_gen/dictionary.py
- M third_party/blink/renderer/modules/media_capabilities/media_capabilities_fuzzer.cc
- M third_party/blink/renderer/modules/peerconnection/rtc_session_description_request_impl.cc
- M third_party/blink/renderer/modules/peerconnection/rtc_session_description_request_promise_impl.cc
- M third_party/blink/renderer/modules/peerconnection/rtc_stats_report.cc
- M third_party/blink/renderer/modules/webcodecs/fuzzer_utils.cc
- M third_party/blink/renderer/modules/webcodecs/fuzzer_utils.h
- M third_party/blink/renderer/modules/webcodecs/image_decoder_fuzzer.cc
Change size: L
Delta: 8 files changed, 181 insertions(+), 139 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuki Shiino
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages