SimulateFrame() for RunSnapshotPostLayoutStateSteps [chromium/src : main]

0 views
Skip to first unread message

Rune Lillesveen (Gerrit)

unread,
Jan 12, 2026, 5:06:45 PM (2 days ago) Jan 12
to Rune Lillesveen, Kevin Ellis, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Ellis

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Ellis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I452b9b83bd881977fa9777aa100368c67ba8138f
Gerrit-Change-Number: 7456868
Gerrit-PatchSet: 1
Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Kevin Ellis <kev...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 22:06:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kevin Ellis (Gerrit)

unread,
Jan 13, 2026, 8:48:25 AM (yesterday) Jan 13
to Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen

Kevin Ellis voted and added 1 comment

Votes added by Kevin Ellis

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I452b9b83bd881977fa9777aa100368c67ba8138f
    Gerrit-Change-Number: 7456868
    Gerrit-PatchSet: 1
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 13:48:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Jan 13, 2026, 8:48:49 AM (yesterday) Jan 13
    to Rune Lillesveen, Kevin Ellis, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org

    Rune Lillesveen voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I452b9b83bd881977fa9777aa100368c67ba8138f
    Gerrit-Change-Number: 7456868
    Gerrit-PatchSet: 1
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 13:48:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 13, 2026, 9:12:21 AM (yesterday) Jan 13
    to Rune Lillesveen, Kevin Ellis, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    SimulateFrame() for RunSnapshotPostLayoutStateSteps

    With RunSnapshotPostLayoutStateSteps enabled, scroll timelines are
    updated during the resizeObserver loop after the style and layout has
    been updated. Thus, we need to invoke UpdateAllLifecyclePhasesForTest to
    apply scroll timeline changes when the scroll position changes.

    Additionally, events are only dispatched during "update animations and
    send events", which will happen for the next frame with the mentioned
    runtime flag enabled.

    This makes all ScrollTimelineTests pass with the flag enabled.

    Bug: 384523570
    Change-Id: I452b9b83bd881977fa9777aa100368c67ba8138f
    Reviewed-by: Kevin Ellis <kev...@chromium.org>
    Commit-Queue: Rune Lillesveen <fut...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1568361}
    Files:
    • M third_party/blink/renderer/core/animation/scroll_timeline_test.cc
    Change size: S
    Delta: 1 file changed, 11 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kevin Ellis
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I452b9b83bd881977fa9777aa100368c67ba8138f
    Gerrit-Change-Number: 7456868
    Gerrit-PatchSet: 2
    Gerrit-Owner: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages