[scroll-animations] Create DeferredTimelines lazily [chromium/src : main]
0 views
Skip to first unread message
Anders Hartvoll Ruud (Gerrit)
Jan 13, 2026, 11:28:18 AM (yesterday) Jan 13
to David Awogbemila, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from David Awogbemila
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- David Awogbemila
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Awogbemila (Gerrit)
12:00 AM (16 hours ago) 12:00 AM
to Anders Hartvoll Ruud, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
David Awogbemila voted and added 2 comments![]( "Open in Gerrit")
Votes added by David Awogbemila
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/renderer/core/animation/deferred_timeline.h
Line 25, Patchset 3 (Latest):
// https://drafts.csswg.org/scroll-animations-1/#timeline-name-scopeDavid Awogbemila . resolved
`timeline-scope`?
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
5:03 AM (11 hours ago) 5:03 AM
to David Awogbemila, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org
Anders Hartvoll Ruud voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anders Hartvoll Ruud
| Commit-Queue | +2 |
1 comment
File third_party/blink/renderer/core/animation/deferred_timeline.h
David Awogbemila . resolved
`timeline-scope`?
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:59 AM (10 hours ago) 5:59 AM
to Anders Hartvoll Ruud, David Awogbemila, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/animation/deferred_timeline.h
Insertions: 1, Deletions: 1.
@@ -22,7 +22,7 @@
// their state from) are later attached by the animation update of a descendant
// element (see CSSAnimations::CalculateTimelineAttachmentUpdate()).
//
-// https://drafts.csswg.org/scroll-animations-1/#timeline-name-scope
+// https://drafts.csswg.org/scroll-animations-1/#timeline-scope
class CORE_EXPORT DeferredTimeline : public ScrollSnapshotTimeline {
public:
explicit DeferredTimeline(Document*);
```
Change information
Commit message:
[scroll-animations] Create DeferredTimelines lazily
The timeline-scope property currently accepts a list of names,
and each such name results in a DeferredTimeline being eagerly created
on the relevant element. This approach does not work for
timeline-scope:all; eagerly creating all possible timelines
on an element isn't viable.
Instead, each element now holds a CSSDeferredTimelineMap, which
logically contains all possible DeferredTimelines by default
(but doesn't really), and timeline-scope merely *filters* the subset
of DeferredTimelines that are reachable.
When looking for a DeferredTimeline to attach to in the ancestor chain
(CalculateTimelineAttachmentUpdate()), the act of looking for it will
now *create* it (if needed) behind the scenes---provided that
the lookup matches the specified filter. This makes it obvious how
to implement 'all': just use a CSSDeferredTimelineMap with no filter.
Note that CSSDeferredTimelineMap holds DeferredTimelines internally
using weak references. This means that "unused" DeferredTimelines will
disappear from the CSSDeferredTimelineMap during GC. This is assumed
to be fine; a non-retained DeferredTimeline implies that no scroll/view
timeline is attached to it, *and* that no animations are playing on it.
Note also that DeferredTimelines cannot be held (directly) by JS,
and they are generally not exposed through APIs; see DeferredTimeline::
ExposedTimeline().
Bug: 41488030
Change-Id: I166127fef1a68cb7939a8bcab859a8a4b0a29f27
Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
Reviewed-by: David Awogbemila <awogb...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1569013}
Files:
- M third_party/blink/renderer/core/animation/BUILD.gn
- M third_party/blink/renderer/core/animation/css/css_animation_update.cc
- M third_party/blink/renderer/core/animation/css/css_animation_update.h
- M third_party/blink/renderer/core/animation/css/css_animations.cc
- M third_party/blink/renderer/core/animation/css/css_animations.h
- M third_party/blink/renderer/core/animation/css/css_animations_test.cc
- A third_party/blink/renderer/core/animation/css/css_timeline_map.cc
- M third_party/blink/renderer/core/animation/css/css_timeline_map.h
- M third_party/blink/renderer/core/animation/deferred_timeline.h
Change size: L
Delta: 9 files changed, 198 insertions(+), 99 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Awogbemila
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages