[css-transition] A singular-valued matrix break transitionability [chromium/src : main]
AI Code Reviewer (Gerrit)
AI Code Reviewer added 1 comment![]( "Open in Gerrit")
Variable 'end_value' is assigned 'start.interpolable_value', which is misleading and likely a copy-paste error. Did you mean 'end.interpolable_value'? (Blink Style Guide: Naming - Be Descriptive)
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Ellis (Gerrit)
Kevin Ellis added 1 comment![]( "Open in Gerrit")
Variable 'end_value' is assigned 'start.interpolable_value', which is misleading and likely a copy-paste error. Did you mean 'end.interpolable_value'? (Blink Style Guide: Naming - Be Descriptive)
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Done
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Ellis (Gerrit)
Kevin Ellis added 1 comment![]( "Open in Gerrit")
Related details
- David Awogbemila
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Awogbemila (Gerrit)
David Awogbemila voted and added 2 comments![]( "Open in Gerrit")
Votes added by David Awogbemila
| Code-Review | +1 |
2 comments
LGTM
// A singular matrix can also be encountered when forced to call back onWas this meant to be fall back?
Related details
- Kevin Ellis
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Ellis (Gerrit)
Kevin Ellis added 1 comment![]( "Open in Gerrit")
// A singular matrix can also be encountered when forced to call back onWas this meant to be fall back?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Ellis (Gerrit)
Kevin Ellis voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/animation/css/css_animations.cc
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
[css-transition] A singular-valued matrix break transitionability
From css-transitions-1:
When comparing the before-change style and after-change style for a
given property, the property values are transitionable if they have an
animation type that is neither not animatable nor discrete.
Discrete animations are permitted only if transition-behavior is set
to allow-discrete. Previously we inferred discrete behavior solely
from the property type, however, a transform animation will be
discrete if blending a singular-valued matrix since it cannot be
decomposed into translate, scale, rotate, and skew operations.
This patch adds detection of singular-valued matrices in the blend
operation. If found, we abort the process of starting a css-
transition.
- M third_party/blink/renderer/core/animation/css/css_animations.cc
- M third_party/blink/renderer/platform/transforms/transform_operations.cc
- M third_party/blink/renderer/platform/transforms/transform_operations.h
- D third_party/blink/web_tests/external/wpt/css/css-transforms/animation/transform-interpolation-007-expected.txt
- D third_party/blink/web_tests/external/wpt/css/css-transforms/animation/transform-non-invertible-no-transition-expected.txt
Code-Review: +1 by David Awogbemila
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |