[text-indent] Use `CSSPrimitiveValue` when possible [chromium/src : main]
0 views
Skip to first unread message
Koji Ishii (Gerrit)
12:47 AM (16 hours ago) 12:47 AM
to Kent Tamura, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, kinuko...@chromium.org, jmedle...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Kent Tamura
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
1:45 AM (15 hours ago) 1:45 AM
to Koji Ishii, Kent Tamura, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, kinuko...@chromium.org, jmedle...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Koji Ishii
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
3:01 AM (13 hours ago) 3:01 AM
to Kent Tamura, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, kinuko...@chromium.org, jmedle...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Koji Ishii voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:04 AM (13 hours ago) 3:04 AM
to Koji Ishii, Kent Tamura, AyeAye, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, kinuko...@chromium.org, jmedle...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[text-indent] Use `CSSPrimitiveValue` when possible
This patch changes the CSS parser to use the `CSSPrimitiveValue`
instead of the `CSSValueList` with one entry when possible,
to reduce memory and some CPU cycles.
This patch should have no behavior changes.
Bug: 434361099
Change-Id: I1395d397a324d365f5a3e469639ef0d6fc7dd945
Commit-Queue: Koji Ishii <ko...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568953}
Files:
- M third_party/blink/renderer/core/animation/css_text_indent_interpolation_type.cc
- M third_party/blink/renderer/core/css/cssom/style_value_factory.cc
- M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: M
Delta: 4 files changed, 43 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kent Tamura
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages