Set Ready For Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
I see that Safari already shipped this. I guess that means it's likely safe without any compat research?
Adding andruud@ for a second opinion
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
I see that Safari already shipped this. I guess that means it's likely safe without any compat research?
Adding andruud@ for a second opinion
OK, but then let's land this immediately _after_ the M145 branch (approx. Jan 12, 2026) for maximum bake time.
lgtm; withholding the Core-Review vote until after the M145 branch.
You should mention that Safari already shipped this.
return MakeGarbageCollected<V8UnionCSSStyleValueOrUndefined>(
ToV8UndefinedGenerator());Maybe `ToV8UnionCSSStyleValueOrUndefined(nullptr)` is a bit nicer here? (Also in many other places.)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
lgtm; withholding the Core-Review vote until after the M145 branch.
*Code-Review
Anders Hartvoll RuudI see that Safari already shipped this. I guess that means it's likely safe without any compat research?
Adding andruud@ for a second opinion
OK, but then let's land this immediately _after_ the M145 branch (approx. Jan 12, 2026) for maximum bake time.
Sounds good. I will wait until the M145 branch to land this. Thanks!
You should mention that Safari already shipped this.
Thank you so much for your review. I've updated it.
return MakeGarbageCollected<V8UnionCSSStyleValueOrUndefined>(
ToV8UndefinedGenerator());Maybe `ToV8UnionCSSStyleValueOrUndefined(nullptr)` is a bit nicer here? (Also in many other places.)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
return MakeGarbageCollected<V8UnionCSSStyleValueOrUndefined>(
ToV8UndefinedGenerator());Suyeon JiMaybe `ToV8UnionCSSStyleValueOrUndefined(nullptr)` is a bit nicer here? (Also in many other places.)
Thanks. Done.
My apologies for the confusion. I realized that the tests were actually failing because this type is guarded by a DCHECK, which prevents using nullptr. I think we should use ToV8UndefinedGenerator instead to handle this correctly.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruudlgtm; withholding the Core-Review vote until after the M145 branch.
Suyeon Ji*Code-Review
Hi, It appears the M145 branch point has passed. Could you please take a look for the Core-Review vote now?
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |