actions revamp: Let ETB observe ETVM [chromium/src : main]

[Masa Fujita (Gerrit)]

Attention needed from David Bokan

Masa Fujita has uploaded the change for review

Masa Fujita would like David Bokan to review this change.

Commit message

actions revamp: Let ETB observe ETVM

`ToolbarActionViewModel` (and hence `ExtensionActionViewModel`) allows
us to register a callback to get notified about updates to the model, so
we can use this to update the Java UI in reaction to for example tab
changes.

Bug: 473396591

Change-Id: I04ad67cbd6d5381f7bc0feb47bc08a37065e16e2

Change diff

Change information

Files:

• M chrome/browser/ui/android/extensions/extensions_toolbar_bridge.cc
• M chrome/browser/ui/android/extensions/extensions_toolbar_bridge.h

Change size: S

Delta: 2 files changed, 27 insertions(+), 0 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• David Bokan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I04ad67cbd6d5381f7bc0feb47bc08a37065e16e2

Gerrit-Change-Number: 7474627

Gerrit-PatchSet: 1

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: David Bokan <bo...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Avi Drissman <a...@chromium.org>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Hu, Ningxin <ningx...@intel.com>

Gerrit-CC: Jiewei Qian <q...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Permissions Reviews <permissio...@chromium.org>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Sophie Chang <sophi...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-Attention: David Bokan <bo...@chromium.org>

[Masa Fujita (Gerrit)]

Masa Fujita has uploaded the change for review

Masa Fujita removed Permissions Reviews, Olga Gerchikov, Hu, Ningxin, chromium...@chromium.org, Andrew Rayskiy, Akihiro Ota, Chromium Metrics Reviews, prerendering-reviews, devtools...@chromium.org, David Bokan, Simon Hangl, Sophie Chang, Avi Drissman, (Julie)Jeongeun Kim, Menard, Alexis, Jiewei Qian, Kentaro Hara, cc-...@chromium.org, vakh+safe_br...@chromium.org, zackha...@chromium.org, translat...@chromium.org, feature-me...@chromium.org, chromeos-ca...@google.com, ios-r...@chromium.org, yuzo+...@chromium.org, kyungjunle...@google.com, blink-...@chromium.org, subresource-f...@chromium.org, print-rev...@chromium.org, mfoltz+wa...@chromium.org, cros-print...@google.com, croissant-...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, jmedle...@chromium.org, vasilii+watchlis...@chromium.org, lizeb...@chromium.org, blink-re...@chromium.org, druber...@chromium.org, apavlo...@chromium.org, francisjp...@google.com, josiah...@chromium.org, peilinwa...@google.com, dullweb...@chromium.org, ajwong...@chromium.org, rmcelra...@chromium.org, steimel+...@chromium.org, jdonnel...@chromium.org, nicolas...@chromium.org, blink-re...@chromium.org, tbarzi...@chromium.org, asvitkine...@chromium.org, nwoked...@chromium.org, spang...@chromium.org, chrome-gr...@chromium.org, bartek...@chromium.org, gavin...@chromium.org, ydago...@chromium.org, katie...@chromium.org, creis...@chromium.org, nektar...@chromium.org, tracing...@chromium.org, lingqi...@chromium.org, wfh+...@chromium.org, oshima...@chromium.org, abigailbk...@google.com, dtseng...@chromium.org, tburkar...@chromium.org, hanxi...@chromium.org, grt+...@chromium.org, xiaochen...@chromium.org, xinghui...@chromium.org, andysjl...@chromium.org, dewitt...@chromium.org, webauthn...@chromium.org, lize...@chromium.org, hirokisa...@chromium.org, gcasto+w...@chromium.org, ipc-securi...@chromium.org, marq+...@chromium.org, msrame...@chromium.org, tote-eng...@google.com, yuezhang...@chromium.org, omnibox-...@chromium.org, rrsilva+wat...@google.com, derinel+wat...@google.com, rginda...@chromium.org, mac-r...@chromium.org, blink-revie...@chromium.org, ios-revie...@chromium.org, mdjone...@chromium.org, mfoltz+wa...@chromium.org, ayman...@chromium.org and extension...@chromium.org from reviewers of this change.

Commit message

actions revamp: Let ETB observe ETVM

`ToolbarActionViewModel` (and hence `ExtensionActionViewModel`) allows
us to register a callback to get notified about updates to the model, so
we can use this to update the Java UI in reaction to for example tab
changes.

Bug: 473396591

Change-Id: I04ad67cbd6d5381f7bc0feb47bc08a37065e16e2

Change diff

Change information

Files:

• M chrome/browser/ui/android/extensions/extensions_toolbar_bridge.cc
• M chrome/browser/ui/android/extensions/extensions_toolbar_bridge.h

Change size: S

Delta: 2 files changed, 27 insertions(+), 0 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement