Use StrongAlias for SanitizeScriptErrors [chromium/src : master]

0 views
Skip to first unread message

Yutaka Hirano (Gerrit)

unread,
Jul 16, 2019, 3:15:24 AM7/16/19
to Hiroshige Hayashizaki, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, caseq...@chromium.org, dominicc+...@chromium.org, falken...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, jbroma...@chromium.org, joelhock...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, shimazu...@chromium.org, Yutaka Hirano

Yutaka Hirano would like Hiroshige Hayashizaki to review this change.

View Change

Use StrongAlias for SanitizeScriptErrors

Change-Id: Id368a3acec35f14d674b26a0715b1b476ce68796
---
M third_party/blink/renderer/DEPS
M third_party/blink/renderer/bindings/core/v8/activity_logger_test.cc
M third_party/blink/renderer/bindings/core/v8/js_event_handler_for_content_attribute.cc
M third_party/blink/renderer/bindings/core/v8/module_record_test.cc
M third_party/blink/renderer/bindings/core/v8/rejected_promises.cc
M third_party/blink/renderer/bindings/core/v8/sanitize_script_errors.h
M third_party/blink/renderer/bindings/core/v8/scheduled_action.cc
M third_party/blink/renderer/bindings/core/v8/script_controller.cc
M third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
M third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer_test.cc
M third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
M third_party/blink/renderer/bindings/core/v8/v8_script_runner.cc
M third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
M third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.cc
M third_party/blink/renderer/core/execution_context/execution_context.cc
M third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
M third_party/blink/renderer/core/frame/dom_timer_test.cc
M third_party/blink/renderer/core/frame/local_frame_view.cc
M third_party/blink/renderer/core/frame/pausable_script_executor.cc
M third_party/blink/renderer/core/frame/web_local_frame_impl.cc
M third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
M third_party/blink/renderer/core/inspector/inspector_page_agent.cc
M third_party/blink/renderer/core/mojo/tests/js_to_cpp_test.cc
M third_party/blink/renderer/core/resize_observer/resize_observer_test.cc
M third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
M third_party/blink/renderer/core/script/classic_pending_script.cc
M third_party/blink/renderer/core/script/module_script_test.cc
M third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc
M third_party/blink/renderer/core/workers/worker_global_scope.cc
M third_party/blink/renderer/core/xml/document_xml_tree_viewer.cc
M third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope_test.cc
M third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client_test.cc
M third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope_test.cc
M third_party/blink/renderer/modules/csspaint/paint_worklet_proxy_client_test.cc
M third_party/blink/renderer/modules/csspaint/paint_worklet_test.cc
M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
36 files changed, 154 insertions(+), 169 deletions(-)


To view, visit change 1703626. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: master
Gerrit-Change-Id: Id368a3acec35f14d674b26a0715b1b476ce68796
Gerrit-Change-Number: 1703626
Gerrit-PatchSet: 2
Gerrit-Owner: Yutaka Hirano <yhi...@chromium.org>
Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Reviewer: Yutaka Hirano <yhi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Commit Bot <commi...@chromium.org>
Gerrit-CC: Darin Fisher <da...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Majid Valipour <maj...@chromium.org>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-CC: Yi Gu <yi...@chromium.org>
Gerrit-MessageType: newchange

Yutaka Hirano (Gerrit)

unread,
Jul 16, 2019, 3:15:26 AM7/16/19
to Yutaka Hirano, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, caseq...@chromium.org, dominicc+...@chromium.org, falken...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, jbroma...@chromium.org, joelhock...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, shimazu...@chromium.org, Hiroshige Hayashizaki, Commit Bot, Alexis Menard, David Bokan, chromium...@chromium.org, Darin Fisher, devtools...@chromium.org, Kentaro Hara, Majid Valipour, Xida Chen, Yi Gu

This change is ready for review.

View Change

    To view, visit change 1703626. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-Change-Id: Id368a3acec35f14d674b26a0715b1b476ce68796
    Gerrit-Change-Number: 1703626
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yutaka Hirano <yhi...@chromium.org>
    Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
    Gerrit-Reviewer: Yutaka Hirano <yhi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Commit Bot <commi...@chromium.org>
    Gerrit-CC: Darin Fisher <da...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Majid Valipour <maj...@chromium.org>
    Gerrit-CC: Xida Chen <xida...@chromium.org>
    Gerrit-CC: Yi Gu <yi...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Jul 2019 07:15:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Yutaka Hirano (Gerrit)

    unread,
    Jul 16, 2019, 5:05:41 AM7/16/19
    to Yutaka Hirano, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, caseq...@chromium.org, dominicc+...@chromium.org, falken...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, jbroma...@chromium.org, joelhock...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, shimazu...@chromium.org, Hiroshige Hayashizaki, Commit Bot, Alexis Menard, David Bokan, chromium...@chromium.org, Darin Fisher, devtools...@chromium.org, Kentaro Hara, Majid Valipour, Xida Chen, Yi Gu

    For SanitizeScriptErrors, SanitizeScriptErrors(true) may be a bit misleading. I'm wondering if I should introduce a static function "From" to StrongAlias so that I can write SanitizeScriptErrors::From(true).

    View Change

      To view, visit change 1703626. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: master
      Gerrit-Change-Id: Id368a3acec35f14d674b26a0715b1b476ce68796
      Gerrit-Change-Number: 1703626
      Gerrit-PatchSet: 2
      Gerrit-Owner: Yutaka Hirano <yhi...@chromium.org>
      Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
      Gerrit-Reviewer: Yutaka Hirano <yhi...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Commit Bot <commi...@chromium.org>
      Gerrit-CC: Darin Fisher <da...@chromium.org>
      Gerrit-CC: David Bokan <bo...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Majid Valipour <maj...@chromium.org>
      Gerrit-CC: Xida Chen <xida...@chromium.org>
      Gerrit-CC: Yi Gu <yi...@chromium.org>
      Gerrit-Comment-Date: Tue, 16 Jul 2019 09:05:35 +0000

      Hiroshige Hayashizaki (Gerrit)

      unread,
      Jul 18, 2019, 6:28:15 PM7/18/19
      to Yutaka Hirano, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, caseq...@chromium.org, dominicc+...@chromium.org, falken...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, jbroma...@chromium.org, joelhock...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, shimazu...@chromium.org, Commit Bot, Alexis Menard, David Bokan, chromium...@chromium.org, Darin Fisher, devtools...@chromium.org, Kentaro Hara, Majid Valipour, Xida Chen, Yi Gu

      Patch set 2:Code-Review +1

      View Change

      2 comments:

      To view, visit change 1703626. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: master
      Gerrit-Change-Id: Id368a3acec35f14d674b26a0715b1b476ce68796
      Gerrit-Change-Number: 1703626
      Gerrit-PatchSet: 2
      Gerrit-Owner: Yutaka Hirano <yhi...@chromium.org>
      Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
      Gerrit-Reviewer: Yutaka Hirano <yhi...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Commit Bot <commi...@chromium.org>
      Gerrit-CC: Darin Fisher <da...@chromium.org>
      Gerrit-CC: David Bokan <bo...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Majid Valipour <maj...@chromium.org>
      Gerrit-CC: Xida Chen <xida...@chromium.org>
      Gerrit-CC: Yi Gu <yi...@chromium.org>
      Gerrit-Comment-Date: Thu, 18 Jul 2019 22:28:11 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Hiroshige Hayashizaki (Gerrit)

      unread,
      Jul 18, 2019, 7:45:02 PM7/18/19
      to Yutaka Hirano, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, caseq...@chromium.org, dominicc+...@chromium.org, falken...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, jbroma...@chromium.org, joelhock...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, shimazu...@chromium.org, Commit Bot, Alexis Menard, David Bokan, chromium...@chromium.org, Darin Fisher, devtools...@chromium.org, Kentaro Hara, Majid Valipour, Xida Chen, Yi Gu

      Patch Set 2:

      For SanitizeScriptErrors, SanitizeScriptErrors(true) may be a bit misleading. I'm wondering if I should introduce a static function "From" to StrongAlias so that I can write SanitizeScriptErrors::From(true).

      I think this is because of the name, SanitizeScriptErrors.
      If the current code looks misleading, then how about renaming to e.g.
      SanitizeScriptErrorsFlag(true)?

      I'm neutral about this, but probably I'm biased because I already know what SanitizeScriptErrors means.
      If this misleads someone outside our team (try asking a quick question),
      then let's consider improvements.

      View Change

        To view, visit change 1703626. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-Change-Id: Id368a3acec35f14d674b26a0715b1b476ce68796
        Gerrit-Change-Number: 1703626
        Gerrit-PatchSet: 2
        Gerrit-Owner: Yutaka Hirano <yhi...@chromium.org>
        Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
        Gerrit-Reviewer: Yutaka Hirano <yhi...@chromium.org>
        Gerrit-CC: Alexis Menard <alexis...@intel.com>
        Gerrit-CC: Commit Bot <commi...@chromium.org>
        Gerrit-CC: Darin Fisher <da...@chromium.org>
        Gerrit-CC: David Bokan <bo...@chromium.org>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Majid Valipour <maj...@chromium.org>
        Gerrit-CC: Xida Chen <xida...@chromium.org>
        Gerrit-CC: Yi Gu <yi...@chromium.org>
        Gerrit-Comment-Date: Thu, 18 Jul 2019 23:44:56 +0000

        Josip Sokcevic (Gerrit)

        unread,
        Apr 6, 2021, 10:13:00 PM4/6/21
        to Yutaka Hirano, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, caseq...@chromium.org, dominicc+...@chromium.org, falken...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, jbroma...@chromium.org, joelhock...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, shimazu...@chromium.org, Hiroshige Hayashizaki, Alexis Menard, David Bokan, chromium...@chromium.org, Darin Fisher, devtools...@chromium.org, Kentaro Hara, Majid Valipour, Xida Chen, Yi Gu

        Josip Sokcevic abandoned this change.

        View Change

        Abandoned stale CL, restore if still relevant

        To view, visit change 1703626. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: master
        Gerrit-Change-Id: Id368a3acec35f14d674b26a0715b1b476ce68796
        Gerrit-Change-Number: 1703626
        Gerrit-PatchSet: 2
        Gerrit-Owner: Yutaka Hirano <yhi...@chromium.org>
        Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
        Gerrit-Reviewer: Yutaka Hirano <yhi...@chromium.org>
        Gerrit-CC: Alexis Menard <alexis...@intel.com>
        Gerrit-CC: Commit Bot <commi...@chromium.org>
        Gerrit-CC: Darin Fisher <da...@chromium.org>
        Gerrit-CC: David Bokan <bo...@chromium.org>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Majid Valipour <maj...@chromium.org>
        Gerrit-CC: Xida Chen <xida...@chromium.org>
        Gerrit-CC: Yi Gu <yi...@chromium.org>
        Gerrit-MessageType: abandon
        Reply all
        Reply to author
        Forward
        0 new messages