[CodeHealth] Make ScrollableArea::SetScrollOffset non-virtual [chromium/src : main]

0 views
Skip to first unread message

Mustaq Ahmed (Gerrit)

unread,
Jan 12, 2026, 4:54:10 PM (2 days ago) Jan 12
to David Awogbemila, Chromium LUCI CQ, Menard, Alexis, David Bokan, chromium...@chromium.org, Olga Gerchikov, Kenneth Rohde Christiansen, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from David Awogbemila

Mustaq Ahmed added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Mustaq Ahmed . resolved

Hi David, ptal.

Open in Gerrit

Related details

Attention is currently required from:
  • David Awogbemila
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I45e6e574ae972168b242380ae2948f887a49afef
Gerrit-Change-Number: 7457269
Gerrit-PatchSet: 2
Gerrit-Owner: Mustaq Ahmed <mus...@chromium.org>
Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
Gerrit-Reviewer: Mustaq Ahmed <mus...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: David Awogbemila <awogb...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 21:54:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Awogbemila (Gerrit)

unread,
10:56 AM (5 hours ago) 10:56 AM
to Mustaq Ahmed, Chromium LUCI CQ, Menard, Alexis, David Bokan, chromium...@chromium.org, Olga Gerchikov, Kenneth Rohde Christiansen, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Mustaq Ahmed

David Awogbemila voted and added 1 comment

Votes added by David Awogbemila

Code-Review+1

1 comment

Patchset-level comments
David Awogbemila . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Mustaq Ahmed
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I45e6e574ae972168b242380ae2948f887a49afef
    Gerrit-Change-Number: 7457269
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mustaq Ahmed <mus...@chromium.org>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Mustaq Ahmed <mus...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Mustaq Ahmed <mus...@chromium.org>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 15:56:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages