Issue 1484043 in chromium: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-deactivate.tentative.https.window.html

[kebalaji via monorail]

Updates:
Cc: kuan...@chromium.org dreww...@google.com cas...@google.com
Labels: Top-Flakes Test-Flaky

Comment #4 on issue 1484043 by keba...@chromium.org: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-deactivate.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1484043#c4

This bug contributed to 16 Sheriff builds failing in the last 7 days. Please prioritize fixing this bug to help improve stability of Chrome CI/CQ.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[Git Watcher via monorail]

Comment #5 on issue 1484043 by Git Watcher: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-deactivate.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1484043#c5

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/e3b82357f7558365cbf3fa50f226d127460847bb

commit e3b82357f7558365cbf3fa50f226d127460847bb
Author: L. David Baron <dba...@chromium.org>
Date: Tue Sep 19 14:59:24 2023

[Gardener] Mark fetch/fetch-later/send-on-deactivate.tentative.https.window.html as flaky timeout on all Mac/Win.

Bug: 1484043
Change-Id: I6e42c30890d44b0c72d6cf16d36da1541b911e02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4876961
Reviewed-by: Titouan Rigoudy <tit...@chromium.org>
Auto-Submit: David Baron <dba...@chromium.org>
Commit-Queue: David Baron <dba...@chromium.org>
Commit-Queue: Titouan Rigoudy <tit...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1198381}

[modify] https://crrev.com/e3b82357f7558365cbf3fa50f226d127460847bb/third_party/blink/web_tests/TestExpectations

[kuanhuang via monorail]

Updates:
Labels: Test-Disabled

Comment #6 on issue 1484043 by kuan...@chromium.org: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-deactivate.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1484043#c6

(No comment was entered for this change.)

[sadapala via monorail]

Comment #7 on issue 1484043 by sada...@google.com: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-deactivate.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1484043#c7

virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-deactivate.tentative.https.window.html

Timeout failure on linux-bfcache-rel builder

Test History Link:
https://ci.chromium.org/ui/test/chromium%3Aci/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fvirtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-deactivate.tentative.https.window.html?q=VHASH%3A7a6a3f3d13a3be84

Dashboard:
https://data.corp.google.com/sites/chrome_generic_flakiness_dashboard_datasite/top_flakes/?f=test_id:eq:ninja:%2F%2F:blink_wpt_tests%2Fvirtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-deactivate.tentative.https.window.html&f=realm:in:(null)&f=variant_test_suite:in:blink_wpt_tests&can=2

and average 14.44% flaky rate in runs mostly on Linux builders

[Git Watcher via monorail]

Comment #8 on issue 1484043 by Git Watcher: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-deactivate.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1484043#c8

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/49bd5aef5eca2eb476fad6e05d006790f1e138e2

commit 49bd5aef5eca2eb476fad6e05d006790f1e138e2
Author: Ming-Ying Chung <my...@chromium.org>
Date: Tue Oct 10 19:54:49 2023

Extract common fetch logic out of FetchManager::Loader

This CL does 2 things:

1. extract common fetch logic, i.e. the ones not related to
ThreadableLoader/ThreadableLoaderClient, out into an abstract
base class, so that it can be shared between Fetch/FetchLater.
2. Move FetchLater related logic out into FetchLaterManager.

- No functional change to Fetch request handling.
- FetchLater request sending & relevant tests are disabled in this
CL. Will be re-enabled once the child CL that uses the new mojo
is submitted.

Bug: 1465781,1483059,1484043,626703
Fuchsia-Binary-Size: Size increase is unavoidable.
Change-Id: Iddfdb501a56af7318e2e52c8f6609124b5a70566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4909373
Commit-Queue: Ming-Ying Chung <my...@chromium.org>
Reviewed-by: Adam Rice <ri...@chromium.org>
Reviewed-by: Nidhi Jaju <nidh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1207849}

[add] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/web_tests/external/wpt/fetch/fetch-later/__dir__.ini
[modify] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/renderer/core/fetch/fetch_manager.cc
[modify] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/renderer/core/fetch/fetch_manager.h
[modify] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/content/browser/loader/keep_alive_url_browsertest.cc
[modify] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/renderer/core/fetch/global_fetch.cc
[modify] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/renderer/core/fetch/fetch_manager_test.cc
[add] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/web_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/__dir__.ini

[Git Watcher via monorail]

Comment #9 on issue 1484043 by Git Watcher: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-deactivate.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1484043#c9

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/82131e1739c285fadfb9b0bc0298866f548213b4

commit 82131e1739c285fadfb9b0bc0298866f548213b4
Author: Yoshisato Yanagisawa <yyana...@chromium.org>
Date: Wed Oct 11 06:59:57 2023

gardener: Mark virtual/fetch-later tests Timeout.

Bug: 1484043
Change-Id: Idbd1a85a4c291d728c5419169b60f591e3bd1d94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4930593
Commit-Queue: Yoshisato Yanagisawa <yyana...@chromium.org>
Reviewed-by: Takashi Sakamoto <ta...@google.com>
Cr-Commit-Position: refs/heads/main@{#1208102}

[modify] https://crrev.com/82131e1739c285fadfb9b0bc0298866f548213b4/third_party/blink/web_tests/TestExpectations

[Git Watcher via monorail]

Comment #10 on issue 1484043 by Git Watcher: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-deactivate.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1484043#c10

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/923ca508bd156e69210d2d807bb2cc5e11086487

commit 923ca508bd156e69210d2d807bb2cc5e11086487
Author: Ming-Ying Chung <my...@chromium.org>
Date: Wed Oct 11 09:22:03 2023

[fetch-later] Fix failures from https://crrev.com/c/4909373

1. CHECK failure from ClusterFuzz test
https://clusterfuzz.com/testcase-detail/6737959759577088

2. WPT failures due to incomplete refactoring https://ci.chromium.org/ui/p/chromium/builders/ci/Mac11%20Tests/21765/overview

Bug: 1491655,1465781,1484043
Change-Id: I8b241785934b6a02880267e3e913c441f3a45217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4930591
Auto-Submit: Ming-Ying Chung <my...@chromium.org>

Commit-Queue: Ming-Ying Chung <my...@chromium.org>
Reviewed-by: Adam Rice <ri...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1208149}

[modify] https://crrev.com/923ca508bd156e69210d2d807bb2cc5e11086487/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/923ca508bd156e69210d2d807bb2cc5e11086487/third_party/blink/renderer/core/fetch/global_fetch.cc
[add] https://crrev.com/923ca508bd156e69210d2d807bb2cc5e11086487/third_party/blink/web_tests/external/wpt/fetch/fetch-later/basic.tentative.https.worker.js

[mych via monorail]

Updates:
Status: Fixed

Comment #11 on issue 1484043 by my...@google.com: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-deactivate.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1484043#c11

The test has been disabled for now as a major refactoring is ongoing. Once it's re-enabled, the flakiness should be fixed.

[mych via monorail]

Updates:
Blocking: 1465781

Comment #12 on issue 1484043 by my...@google.com: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-deactivate.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1484043#c12

(No comment was entered for this change.)