Issue 1483059 in chromium: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html

1,248 views
Skip to first unread message

hiroshige via monorail

unread,
Sep 15, 2023, 1:37:55 PM9/15/23
to blink-ne...@chromium.org
Updates:
Labels: Sheriff-Chromium

Comment #3 on issue 1483059 by hiro...@chromium.org: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c3

(No comment was entered for this change.)

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

sadapala via monorail

unread,
Sep 15, 2023, 2:10:50 PM9/15/23
to blink-ne...@chromium.org

Comment #5 on issue 1483059 by sada...@google.com: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c5

virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html

Timeout Failures on WebKit Win10 builder

Test History Link:
https://ci.chromium.org/ui/test/chromium%3Aci/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fvirtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-discard.tentative.https.window.html?q=VHASH%3A3767ecdffabc49e7

Dashboard:
https://data.corp.google.com/sites/chrome_generic_flakiness_dashboard_datasite/top_flakes/?f=test_id:eq:ninja:%2F%2F:blink_wpt_tests%2Fvirtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-discard.tentative.https.window.html&f=realm:in:(null)&f=variant_test_suite:in:blink_wpt_tests&can=2

and average 19.58% flaky rate in runs mostly on win builders

hiroshige via monorail

unread,
Sep 15, 2023, 2:18:51 PM9/15/23
to blink-ne...@chromium.org

Comment #7 on issue 1483059 by hiro...@chromium.org: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c7

To be marked as flaky: https://chromium-review.googlesource.com/c/chromium/src/+/4868742

Git Watcher via monorail

unread,
Sep 15, 2023, 2:31:25 PM9/15/23
to blink-ne...@chromium.org

Comment #8 on issue 1483059 by Git Watcher: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c8

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/1df95cd2c4f2e94de3431fae8b4dc2dce8093d5d

commit 1df95cd2c4f2e94de3431fae8b4dc2dce8093d5d
Author: Hiroshige Hayashizaki <hiro...@chromium.org>
Date: Fri Sep 15 18:30:27 2023

Mark send-on-discard.tentative.https.window.html flaky on Mac

Bug: 1483059
Change-Id: I55663bf08faca0fc8ce5eddbdbefdfba0cc58556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4868742
Commit-Queue: Hao Liu <hao...@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Hao Liu <hao...@chromium.org>
Auto-Submit: Hiroshige Hayashizaki <hiro...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1197273}

[modify] https://crrev.com/1df95cd2c4f2e94de3431fae8b4dc2dce8093d5d/third_party/blink/web_tests/TestExpectations

hiroshige via monorail

unread,
Sep 15, 2023, 3:32:17 PM9/15/23
to blink-ne...@chromium.org
Updates:
Labels: -Sheriff-Chromium

Comment #9 on issue 1483059 by hiro...@chromium.org: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c9


(No comment was entered for this change.)

hiroshige via monorail

unread,
Sep 15, 2023, 3:33:59 PM9/15/23
to blink-ne...@chromium.org
Updates:
Owner: my...@chromium.org

Comment #10 on issue 1483059 by hiro...@chromium.org: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c10

hiroshige via monorail

unread,
Sep 15, 2023, 3:34:08 PM9/15/23
to blink-ne...@chromium.org
Updates:
Status: Assigned

Comment #11 on issue 1483059 by hiro...@chromium.org: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c11

kuanhuang via monorail

unread,
Sep 18, 2023, 1:32:28 PM9/18/23
to blink-ne...@chromium.org

Comment #12 on issue 1483059 by kuan...@chromium.org: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c12

This test is also failing on linux and windows.

https://ci.chromium.org/ui/b/8769638427406977729/test-results?q=ID:ninja%3A%2F%2F%3Ablink_wpt_tests%2Fvirtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-discard.tentative.https.window.html
https://ci.chromium.org/ui/b/8769630966866075889/test-results?q=ID:ninja%3A%2F%2F%3Ablink_wpt_tests%2Fvirtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-discard.tentative.https.window.html
https://ci.chromium.org/ui/b/8769650249231985777/test-results?q=ID:ninja%3A%2F%2F%3Ablink_wpt_tests%2Fvirtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-discard.tentative.https.window.html

sadapala via monorail

unread,
Sep 18, 2023, 2:47:08 PM9/18/23
to blink-ne...@chromium.org

Comment #13 on issue 1483059 by sada...@google.com: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c13

virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html

Text Failures on WebKit Win10 and Win10 Tests x64 builder

Test History Link:
WebKit Win10:
https://ci.chromium.org/ui/test/chromium%3Aci/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fvirtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-discard.tentative.https.window.html?q=VHASH%3A3767ecdffabc49e7

Win10 Tests x64 : https://ci.chromium.org/ui/test/chromium%3Aci/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fvirtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-discard.tentative.https.window.html?q=VHASH%3A504318dffd1770f6
and average 33.17% flaky rate in runs mostly on win builders

kebalaji via monorail

unread,
Sep 19, 2023, 8:20:31 AM9/19/23
to blink-ne...@chromium.org
Updates:
Cc: kuan...@chromium.org dreww...@google.com cas...@google.com
Labels: Top-Flakes Test-Flaky Pri-1

Comment #14 on issue 1483059 by keba...@chromium.org: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c14

This bug contributed to 56 Sheriff builds failing in the last 7 days. Please prioritize fixing this bug to help improve stability of Chrome CI/CQ.

sadapala via monorail

unread,
Sep 19, 2023, 3:30:55 PM9/19/23
to blink-ne...@chromium.org

Comment #15 on issue 1483059 by sada...@google.com: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c15

virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html

Text Failures on linux-bfcache-rel and Linux Tests builder

Test History Link:
linux-bfcache-rel:
https://ci.chromium.org/ui/test/chromium%3Aci/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fvirtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-discard.tentative.https.window.html?q=VHASH%3A7a6a3f3d13a3be84

Linux Tests:
https://ci.chromium.org/ui/test/chromium%3Aci/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fvirtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-discard.tentative.https.window.html?q=VHASH%3A3d5d684c6208939e
and average 35.76% flaky rate in runs mostly on Win, Mac and Linux builders

kuanhuang via monorail

unread,
Sep 27, 2023, 6:09:19 PM9/27/23
to blink-ne...@chromium.org
Updates:
Labels: Test-Disabled

Comment #16 on issue 1483059 by kuan...@chromium.org: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c16


(No comment was entered for this change.)

sadapala via monorail

unread,
Oct 2, 2023, 7:23:23 PM10/2/23
to blink-ne...@chromium.org

Comment #17 on issue 1483059 by sada...@google.com: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c17

virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html

Text Failures on Linux Tests builder

Test History Link:
and average 28.30% flaky rate in runs mostly on Linux builders

aanala via monorail

unread,
Oct 5, 2023, 2:44:25 PM10/5/23
to blink-ne...@chromium.org
Updates:
Labels: top_100_web_platform_test_flake

Comment #18 on issue 1483059 by aan...@google.com: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c18

Below tests are flaky across all builders and It is on Chrome top 100 flakes dashboard:
https://dashboards.corp.google.com/_dc381665_673d_4e9f_bd12_1095a7f44a21

virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html - rank number 73

Dashboard:
https://data.corp.google.com/sites/chrome_generic_flakiness_dashboard_datasite/top_flakes/?f=test_id:eq:(null)&f=realm:in:(null)&f=date:pd:10&f=shorten_test_name:in:virtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-discard.tentative.https.window.html&can=2
Average 29.26% flaky rate in runs

sadapala via monorail

unread,
Oct 9, 2023, 12:59:32 PM10/9/23
to blink-ne...@chromium.org

Comment #19 on issue 1483059 by sada...@google.com: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c19

virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html

Text Failures on linux-bfcache-rel Linux Tests builder

Test History Link:
linux-bfcache-rel:
https://ci.chromium.org/ui/test/chromium%3Aci/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fvirtual%2Ffetch-later%2Fexternal%2Fwpt%2Ffetch%2Ffetch-later%2Fsend-on-discard.tentative.https.window.html?q=VHASH%3A7a6a3f3d13a3be84
and average 36.34% flaky rate in runs mostly on Linux builders

Git Watcher via monorail

unread,
Oct 9, 2023, 2:18:14 PM10/9/23
to blink-ne...@chromium.org

Comment #20 on issue 1483059 by Git Watcher: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c20


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/d17480d9a93406147f76fec60e5e4bc52ac8a071

commit d17480d9a93406147f76fec60e5e4bc52ac8a071
Author: vivianz <viv...@google.com>
Date: Mon Oct 09 18:16:23 2023

Suppress blink fetchapi top web test flakes on all os platform

Bug: 1483059
Change-Id: I27acafb2c238d859c7390bb47978f2b4f9773134
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4923272
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Vivian Zhi <viv...@google.com>
Cr-Commit-Position: refs/heads/main@{#1207164}

[modify] https://crrev.com/d17480d9a93406147f76fec60e5e4bc52ac8a071/third_party/blink/web_tests/TestExpectations

Git Watcher via monorail

unread,
Oct 10, 2023, 3:55:23 PM10/10/23
to blink-ne...@chromium.org

Comment #21 on issue 1483059 by Git Watcher: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c21


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/49bd5aef5eca2eb476fad6e05d006790f1e138e2

commit 49bd5aef5eca2eb476fad6e05d006790f1e138e2
Author: Ming-Ying Chung <my...@chromium.org>
Date: Tue Oct 10 19:54:49 2023

Extract common fetch logic out of FetchManager::Loader

This CL does 2 things:

1. extract common fetch logic, i.e. the ones not related to
ThreadableLoader/ThreadableLoaderClient, out into an abstract
base class, so that it can be shared between Fetch/FetchLater.
2. Move FetchLater related logic out into FetchLaterManager.

- No functional change to Fetch request handling.
- FetchLater request sending & relevant tests are disabled in this
CL. Will be re-enabled once the child CL that uses the new mojo
is submitted.

Bug: 1465781,1483059,1484043,626703
Fuchsia-Binary-Size: Size increase is unavoidable.
Change-Id: Iddfdb501a56af7318e2e52c8f6609124b5a70566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4909373
Commit-Queue: Ming-Ying Chung <my...@chromium.org>
Reviewed-by: Adam Rice <ri...@chromium.org>
Reviewed-by: Nidhi Jaju <nidh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1207849}

[add] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/web_tests/external/wpt/fetch/fetch-later/__dir__.ini
[modify] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/renderer/core/fetch/fetch_manager.cc
[modify] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/renderer/core/fetch/fetch_manager.h
[modify] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/content/browser/loader/keep_alive_url_browsertest.cc
[modify] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/renderer/core/fetch/global_fetch.cc
[modify] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/renderer/core/fetch/fetch_manager_test.cc
[add] https://crrev.com/49bd5aef5eca2eb476fad6e05d006790f1e138e2/third_party/blink/web_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/__dir__.ini

mych via monorail

unread,
Oct 11, 2023, 10:26:59 PM10/11/23
to blink-ne...@chromium.org
Updates:
Status: Fixed

Comment #22 on issue 1483059 by my...@google.com: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c22

The test is disabled for now as there is a refactoring ongoing. Once it's re-enabled, it should be fixed.

mych via monorail

unread,
Oct 11, 2023, 10:29:35 PM10/11/23
to blink-ne...@chromium.org
Updates:
Blocking: 1465781

Comment #23 on issue 1483059 by my...@google.com: Tests are failing: ninja://:blink_wpt_tests/virtual/fetch-later/external/wpt/fetch/fetch-later/send-on-discard.tentative.https.window.html
https://bugs.chromium.org/p/chromium/issues/detail?id=1483059#c23


(No comment was entered for this change.)

Reply all
Reply to author
Forward
0 new messages