Issue 1141459 in chromium: Shutdown AgentSchedulingGroup and free its resources after use

[kouhei via monorail]

Updates:
Cc: blink-iso...@chromium.org
Labels: Pri-1

Comment #1 on issue 1141459 by kou...@chromium.org: Shutdown AgentSchedulingGroup and free its resources after use
https://bugs.chromium.org/p/chromium/issues/detail?id=1141459#c1

(No comment was entered for this change.)

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[bugdroid via monorail]

Comment #2 on issue 1141459 by bugdroid: Shutdown AgentSchedulingGroup and free its resources after use
https://bugs.chromium.org/p/chromium/issues/detail?id=1141459#c2

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/f38b35b826dbcaceebe08d7b9af2c62546156e14

commit f38b35b826dbcaceebe08d7b9af2c62546156e14
Author: kouhei <kou...@chromium.org>
Date: Thu Nov 12 06:19:21 2020

AgentSchedulingGroupHost: Introduce lifecycle statemachine

This CL introduces a lifecycle statemachine to AgentSchedulingGroupHost.
The `AgentSchedulingGroupHost::state_` makes it explicit which lifestage
the AgentSchedulingGroupHost is currently at, and checks if each method
is called on one of the assumed states.

This is a preparatory work to introducing AgentSchedulingGroupHost
shutdown, which will add more states to the state machine.

Bug: 1141459
Change-Id: Ic8c4f4f85322b52612510b3354d5ae6828311263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492281
Commit-Queue: Kouhei Ueno <kou...@chromium.org>
Auto-Submit: Kouhei Ueno <kou...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Reviewed-by: Dominic Farolino <d...@chromium.org>
Reviewed-by: Tal Pressman <ta...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826664}

[modify] https://crrev.com/f38b35b826dbcaceebe08d7b9af2c62546156e14/content/browser/renderer_host/agent_scheduling_group_host.cc
[modify] https://crrev.com/f38b35b826dbcaceebe08d7b9af2c62546156e14/content/browser/renderer_host/agent_scheduling_group_host.h

[dom via monorail]

Updates:
Blocking: 1149830
Components: Blink>Scheduling

Comment #4 on issue 1141459 by d...@chromium.org: Shutdown AgentSchedulingGroup and free its resources after use
https://bugs.chromium.org/p/chromium/issues/detail?id=1141459#c4

Before AgentSchedulingGroupHost-per-SiteInstance mode [1] [2] is fully implemented, we need an AgentSchedulingGroupHostObserver, which seems best tracked by this issue since it deals with shutting down an ASG(H) and its resources. We need this observer for consumers of AgentSchedulingGroupHost that assume they can track the lifetime of the AgentSchedulingGroupHost via RenderProcessHostObserver, which breaks in per-SiteInstance mode since AgentSchedulingGroupHost can go away before RenderProcessHosts do. Therefore I'll mark this as blocking crbug/1149830.

[1]: https://source.chromium.org/chromium/chromium/src/+/main:content/public/common/content_features.h;l=120-124;drc=98ba871a3912b3e4c1342780efe7506618779329
[2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1149830

[shaseley via monorail]

Updates:
Labels: Pri-2

Comment #5 on issue 1141459 by shas...@chromium.org: Shutdown AgentSchedulingGroup and free its resources after use
https://bugs.chromium.org/p/chromium/issues/detail?id=1141459#c5

[p1 triage] @kouhei: is this work still ongoing? I'm going to mark as P2 for now since there's been no movement/update in quite a while, but please update if that's not accurate.