MBI: Push back `mbi-mode` flag expiration [chromium/src : main]

9 views
Skip to first unread message

Dominic Farolino (Gerrit)

unread,
Sep 3, 2021, 4:26:20 PM9/3/21
to Kentaro Hara, blink-iso...@chromium.org

Attention is currently required from: Kentaro Hara.

Dominic Farolino would like Kentaro Hara to review this change.

View Change

MBI: Push back `mbi-mode` flag expiration

We have not revisited the prioritization of the Multiple Blink Isolates
project, so until we have more information, this CL pushes the flag
expiration back 10 milestones.

Change-Id: I3497742de3cad3f7a88932d9e49cb10d8e7fa15a
---
M chrome/browser/flag-metadata.json
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index c99f89a..820ff9f 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -3740,7 +3740,7 @@
{
"name": "mbi-mode",
"owners": [ "dom", "blink-iso...@chromium.org" ],
- "expiry_milestone": 93
+ "expiry_milestone": 103
},
{
"name": "media-app-handles-audio",

To view, visit change 3142030. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3497742de3cad3f7a88932d9e49cb10d8e7fa15a
Gerrit-Change-Number: 3142030
Gerrit-PatchSet: 3
Gerrit-Owner: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-MessageType: newchange

Dominic Farolino (Gerrit)

unread,
Sep 3, 2021, 4:26:27 PM9/3/21
to blink-iso...@chromium.org, Kentaro Hara

Attention is currently required from: Kentaro Hara.

Patch set 3:Commit-Queue +1

View Change

    To view, visit change 3142030. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3497742de3cad3f7a88932d9e49cb10d8e7fa15a
    Gerrit-Change-Number: 3142030
    Gerrit-PatchSet: 3
    Gerrit-Owner: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
    Gerrit-Attention: Kentaro Hara <har...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Sep 2021 20:26:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Kentaro Hara (Gerrit)

    unread,
    Sep 3, 2021, 5:40:55 PM9/3/21
    to Dominic Farolino, blink-iso...@chromium.org, Chromium LUCI CQ

    Attention is currently required from: Dominic Farolino.

    Patch set 3:Code-Review +1

    View Change

    1 comment:

    To view, visit change 3142030. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3497742de3cad3f7a88932d9e49cb10d8e7fa15a
    Gerrit-Change-Number: 3142030
    Gerrit-PatchSet: 3
    Gerrit-Owner: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
    Gerrit-Attention: Dominic Farolino <d...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Sep 2021 21:40:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Dominic Farolino (Gerrit)

    unread,
    Sep 3, 2021, 7:23:04 PM9/3/21
    to blink-iso...@chromium.org, Kentaro Hara, Chromium LUCI CQ

    Patch set 3:Commit-Queue +2

    View Change

      To view, visit change 3142030. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3497742de3cad3f7a88932d9e49cb10d8e7fa15a
      Gerrit-Change-Number: 3142030
      Gerrit-PatchSet: 3
      Gerrit-Owner: Dominic Farolino <d...@chromium.org>
      Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
      Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
      Gerrit-Comment-Date: Fri, 03 Sep 2021 23:22:56 +0000

      Chromium LUCI CQ (Gerrit)

      unread,
      Sep 3, 2021, 7:27:36 PM9/3/21
      to Dominic Farolino, blink-iso...@chromium.org, Kentaro Hara

      Chromium LUCI CQ submitted this change.

      View Change


      Approvals: Kentaro Hara: Looks good to me Dominic Farolino: Commit
      MBI: Push back `mbi-mode` flag expiration

      We have not revisited the prioritization of the Multiple Blink Isolates
      project, so until we have more information, this CL pushes the flag
      expiration back 10 milestones.

      Change-Id: I3497742de3cad3f7a88932d9e49cb10d8e7fa15a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3142030
      Reviewed-by: Kentaro Hara <har...@chromium.org>
      Commit-Queue: Dominic Farolino <d...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#918292}

      ---
      M chrome/browser/flag-metadata.json
      1 file changed, 1 insertion(+), 1 deletion(-)

      
      
      diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
      index 2aa3f74..4aa0d0e 100644

      --- a/chrome/browser/flag-metadata.json
      +++ b/chrome/browser/flag-metadata.json
      @@ -3740,7 +3740,7 @@
      {
      "name": "mbi-mode",
      "owners": [ "dom", "blink-iso...@chromium.org" ],
      - "expiry_milestone": 93
      + "expiry_milestone": 103
      },
      {
      "name": "media-app-handles-audio",

      To view, visit change 3142030. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3497742de3cad3f7a88932d9e49cb10d8e7fa15a
      Gerrit-Change-Number: 3142030
      Gerrit-PatchSet: 4
      Gerrit-Owner: Dominic Farolino <d...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
      Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
      Gerrit-MessageType: merged
      Reply all
      Reply to author
      Forward
      0 new messages