NEEDMANUALREBASELINE inside TestExpectations

[Aleks Totic]

Last Monday, https://chromium-review.googlesource.com/c/chromium/src/+/695801 introduced 81 tests with expectation of "NEEDMANUALREBASELINE".

These tests pass, and are now showing up as "Unexpected Passes" on our bots. This makes it hard to judge the effect of our patches. 

Can they go away? I've thought that NEEDMANUALREBASELINE is a short term flag.

Aleks

[Chris Harrelson]

They were marked as such temporarily while waiting for a v8 roll that updated the --harmony-function-tostring flag... has that happened yet?

[Josh Wolfe]

--harmony-function-tostring shipped[1], and then was reverted when a bot found a gc bug. that has been fixed[2], but now newly added tests to the chromium test suite have found a missing feature in the --harmony-function-tostring code, so a fix for that is out for review now[3].

tldr: We're still working on it (and the holidays are probably causing some slowdown in the review process).

[1] https://bugs.chromium.org/p/v8/issues/detail?id=4958#c29
[2] https://chromium-review.googlesource.com/c/v8/v8/+/832454
[3] https://chromium-review.googlesource.com/c/v8/v8/+/837641

[Daniel Ehrenberg]

Hi Chris, Aleks,

I uploaded a revert [1] the NeedsManualRebaseline patch to allow the
bots to catch any new test failures while we develop the fix to
--harmony-function-tostring. As Josh says, the slowness here is
largely due to the holidays making reviews take a long time.

Dan

[1] https://chromium-review.googlesource.com/c/chromium/src/+/844574

[Chris Harrelson]

Makes sense, thanks. Happy holidays to all!